Add SkipValidationAttribute to Microsoft.Extensions.Validation

Author: oroztocil

src/Shared/RoslynUtils/WellKnownTypeData.cs

@@ -123,6 +123,7 @@ public enum WellKnownType
         System_ComponentModel_DataAnnotations_ValidationAttribute,
         System_ComponentModel_DataAnnotations_RequiredAttribute,
         System_ComponentModel_DataAnnotations_CustomValidationAttribute,
+        Microsoft_Extensions_Validation_SkipValidationAttribute,
         System_Type,
     }
 
@@ -244,6 +245,7 @@ public enum WellKnownType
         "System.ComponentModel.DataAnnotations.ValidationAttribute",
         "System.ComponentModel.DataAnnotations.RequiredAttribute",
         "System.ComponentModel.DataAnnotations.CustomValidationAttribute",
+        "Microsoft.Extensions.Validation.SkipValidationAttribute",
         "System.Type",
     ];
 }

src/Validation/gen/Parsers/ValidationsGenerator.TypesParser.cs

@@ -5,6 +5,7 @@
 using System.Collections.Immutable;
 using System.Linq;
 using Microsoft.AspNetCore.Analyzers.Infrastructure;
+using Microsoft.AspNetCore.Analyzers.RouteEmbeddedLanguage.Infrastructure;
 using Microsoft.AspNetCore.App.Analyzers.Infrastructure;
 using Microsoft.AspNetCore.Http.RequestDelegateGenerator.StaticRouteHandlerModel;
 using Microsoft.CodeAnalysis;
@@ -114,6 +115,8 @@ internal ImmutableArray<ValidatableProperty> ExtractValidatableMembers(ITypeSymb
             WellKnownTypeData.WellKnownType.Microsoft_AspNetCore_Http_Metadata_IFromServiceMetadata);
         var fromKeyedServiceAttributeSymbol = wellKnownTypes.Get(
             WellKnownTypeData.WellKnownType.Microsoft_Extensions_DependencyInjection_FromKeyedServicesAttribute);
+        var skipValidationAttributeSymbol = wellKnownTypes.Get(
+            WellKnownTypeData.WellKnownType.Microsoft_Extensions_Validation_SkipValidationAttribute);
 
         // Special handling for record types to extract properties from
         // the primary constructor.
@@ -148,6 +151,12 @@ internal ImmutableArray<ValidatableProperty> ExtractValidatableMembers(ITypeSymb
                             continue;
                         }
 
+                        // Skip parameter if it or its type are annotated with SkipValidationAttribute
+                        if (SymbolOrTypeHasAttribute(parameter, parameter.Type, skipValidationAttributeSymbol))
+                        {
+                            continue;
+                        }
+
                         // Check if the property's type is validatable, this resolves
                         // validatable types in the inheritance hierarchy
                         var hasValidatableType = TryExtractValidatableType(
@@ -186,6 +195,12 @@ internal ImmutableArray<ValidatableProperty> ExtractValidatableMembers(ITypeSymb
                 continue;
             }
 
+            // Skip property if it or its type are annotated with SkipValidationAttribute
+            if (SymbolOrTypeHasAttribute(member, member.Type, skipValidationAttributeSymbol))
+            {
+                continue;
+            }
+
             var hasValidatableType = TryExtractValidatableType(member.Type, wellKnownTypes, ref validatableTypes, ref visitedTypes);
             var attributes = ExtractValidationAttributes(member, wellKnownTypes, out var isRequired);
 
@@ -228,4 +243,10 @@ internal static ImmutableArray<ValidationAttribute> ExtractValidationAttributes(
                 NamedArguments: attribute.NamedArguments.ToDictionary(namedArgument => namedArgument.Key, namedArgument => namedArgument.Value.ToCSharpString()),
                 IsCustomValidationAttribute: SymbolEqualityComparer.Default.Equals(attribute.AttributeClass, wellKnownTypes.Get(WellKnownTypeData.WellKnownType.System_ComponentModel_DataAnnotations_CustomValidationAttribute))))];
     }
+
+    private static bool SymbolOrTypeHasAttribute(ISymbol symbol, ITypeSymbol typeSymbol, INamedTypeSymbol attributeSymbol)
+    {
+        return symbol.HasAttribute(attributeSymbol)
+            || typeSymbol.GetAttributes().Any(attr => SymbolEqualityComparer.Default.Equals(attr.AttributeClass, attributeSymbol));
+    }
 }

src/Validation/src/PublicAPI.Unshipped.txt

@@ -5,6 +5,8 @@ Microsoft.Extensions.Validation.IValidatableInfo.ValidateAsync(object? value, Mi
 Microsoft.Extensions.Validation.IValidatableInfoResolver
 Microsoft.Extensions.Validation.IValidatableInfoResolver.TryGetValidatableParameterInfo(System.Reflection.ParameterInfo! parameterInfo, out Microsoft.Extensions.Validation.IValidatableInfo? validatableInfo) -> bool
 Microsoft.Extensions.Validation.IValidatableInfoResolver.TryGetValidatableTypeInfo(System.Type! type, out Microsoft.Extensions.Validation.IValidatableInfo? validatableInfo) -> bool
+Microsoft.Extensions.Validation.SkipValidationAttribute
+Microsoft.Extensions.Validation.SkipValidationAttribute.SkipValidationAttribute() -> void
 Microsoft.Extensions.Validation.ValidatableParameterInfo
 Microsoft.Extensions.Validation.ValidatableParameterInfo.ValidatableParameterInfo(System.Type! parameterType, string! name, string! displayName) -> void
 Microsoft.Extensions.Validation.ValidatablePropertyInfo

src/Validation/src/SkipValidationAttribute.cs

@@ -0,0 +1,13 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace Microsoft.Extensions.Validation;
+
+/// <summary>
+/// Indicates that an object property should be skipped for validation.
+/// The generator will not generate validation code for this property and its type.
+/// </summary>
+[AttributeUsage(AttributeTargets.Class | AttributeTargets.Parameter | AttributeTargets.Property | AttributeTargets.Field)]
+public sealed class SkipValidationAttribute : Attribute
+{
+}