Skip to content

Commit 0712e4c

Browse files
Copilotilonatommy
andcommitted
Fix test assets and clean up test code as requested
Co-authored-by: ilonatommy <[email protected]>
1 parent c10c0d4 commit 0712e4c

File tree

3 files changed

+38
-57
lines changed

3 files changed

+38
-57
lines changed

src/Components/Components/test/Routing/RouterTest.cs

Lines changed: 0 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -346,47 +346,4 @@ public class MultiSegmentRouteComponent : ComponentBase { }
346346
[Route("not-found")]
347347
public class NotFoundTestComponent : ComponentBase { }
348348

349-
public class TestLogger<T> : ILogger<T>
350-
{
351-
public List<LogEntry> LogEntries { get; } = new List<LogEntry>();
352-
353-
public IDisposable BeginScope<TState>(TState state) => null;
354-
355-
public bool IsEnabled(LogLevel logLevel) => true;
356-
357-
public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception exception, Func<TState, Exception, string> formatter)
358-
{
359-
LogEntries.Add(new LogEntry
360-
{
361-
LogLevel = logLevel,
362-
EventId = eventId,
363-
Message = formatter(state, exception),
364-
Exception = exception
365-
});
366-
}
367-
}
368-
369-
public class LogEntry
370-
{
371-
public LogLevel LogLevel { get; set; }
372-
public EventId EventId { get; set; }
373-
public string Message { get; set; }
374-
public Exception Exception { get; set; }
375-
}
376-
377-
public class TestLoggerFactory : ILoggerFactory
378-
{
379-
private readonly ILogger _logger;
380-
381-
public TestLoggerFactory(ILogger logger)
382-
{
383-
_logger = logger;
384-
}
385-
386-
public void AddProvider(ILoggerProvider provider) { }
387-
388-
public ILogger CreateLogger(string categoryName) => _logger;
389-
390-
public void Dispose() { }
391-
}
392349
}

src/Components/test/testassets/Components.TestServer/RazorComponents/App.razor

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,25 @@
3030
<HeadOutlet />
3131
</head>
3232
<body>
33-
<Router AppAssembly="@typeof(App).Assembly" AdditionalAssemblies="new[] { typeof(TestContentPackage.NotFound.NotFoundPage).Assembly }" NotFoundPage="NotFoundPageType">
34-
<Found Context="routeData">
35-
<RouteView RouteData="@routeData" />
36-
<FocusOnNavigate RouteData="@routeData" Selector="[data-focus-on-navigate]" />
37-
</Found>
38-
<NotFound><p id="not-found-fragment">There's nothing here</p></NotFound>
39-
</Router>
33+
@if (NotFoundPageType != null)
34+
{
35+
<Router AppAssembly="@typeof(App).Assembly" AdditionalAssemblies="new[] { typeof(TestContentPackage.NotFound.NotFoundPage).Assembly }" NotFoundPage="NotFoundPageType">
36+
<Found Context="routeData">
37+
<RouteView RouteData="@routeData" />
38+
<FocusOnNavigate RouteData="@routeData" Selector="[data-focus-on-navigate]" />
39+
</Found>
40+
</Router>
41+
}
42+
else
43+
{
44+
<Router AppAssembly="@typeof(App).Assembly" AdditionalAssemblies="new[] { typeof(TestContentPackage.NotFound.NotFoundPage).Assembly }">
45+
<Found Context="routeData">
46+
<RouteView RouteData="@routeData" />
47+
<FocusOnNavigate RouteData="@routeData" Selector="[data-focus-on-navigate]" />
48+
</Found>
49+
<NotFound><p id="not-found-fragment">There's nothing here</p></NotFound>
50+
</Router>
51+
}
4052
<script>
4153
// This script must come before blazor.web.js to test that
4254
// the framework does the right thing when an element is already focused.

src/Components/test/testassets/Components.WasmMinimal/Routes.razor

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,22 @@
2323
}
2424
}
2525

26-
<Router AppAssembly="@typeof(Program).Assembly" AdditionalAssemblies="new[] { typeof(TestContentPackage.NotFound.NotFoundPage).Assembly }" NotFoundPage="NotFoundPageType">
27-
<Found Context="routeData">
28-
<RouteView RouteData="@routeData" />
29-
<FocusOnNavigate RouteData="@routeData" Selector="h1" />
30-
</Found>
31-
<NotFound><p id="not-found-fragment">There's nothing here</p></NotFound>
32-
</Router>
26+
@if (NotFoundPageType != null)
27+
{
28+
<Router AppAssembly="@typeof(Program).Assembly" AdditionalAssemblies="new[] { typeof(TestContentPackage.NotFound.NotFoundPage).Assembly }" NotFoundPage="NotFoundPageType">
29+
<Found Context="routeData">
30+
<RouteView RouteData="@routeData" />
31+
<FocusOnNavigate RouteData="@routeData" Selector="h1" />
32+
</Found>
33+
</Router>
34+
}
35+
else
36+
{
37+
<Router AppAssembly="@typeof(Program).Assembly" AdditionalAssemblies="new[] { typeof(TestContentPackage.NotFound.NotFoundPage).Assembly }">
38+
<Found Context="routeData">
39+
<RouteView RouteData="@routeData" />
40+
<FocusOnNavigate RouteData="@routeData" Selector="h1" />
41+
</Found>
42+
<NotFound><p id="not-found-fragment">There's nothing here</p></NotFound>
43+
</Router>
44+
}

0 commit comments

Comments
 (0)