Skip to content

Commit 09dbad8

Browse files
committed
Apply feedback.
1 parent 6c178f0 commit 09dbad8

File tree

1 file changed

+15
-16
lines changed

1 file changed

+15
-16
lines changed

src/Components/test/E2ETest/Tests/CircuitTests.cs

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,7 @@ public void ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit(string i
4343
var targetButton = Browser.Exists(By.Id(id));
4444
targetButton.Click();
4545

46-
// Triggering an error will show the exception UI
47-
Browser.Exists(By.CssSelector("#blazor-error-ui[style='display: block;']"));
48-
49-
// Dismiss the error UI by clicking the dismiss button
50-
var dismissButton = Browser.Exists(By.CssSelector("#blazor-error-ui .dismiss"));
51-
dismissButton.Click();
52-
53-
// Wait for error UI to be hidden
54-
Browser.Exists(By.CssSelector("#blazor-error-ui[style='display: none;']"));
46+
DismissBlazorErrorUI();
5547

5648
// Clicking the button again will trigger a server disconnect
5749
targetButton.Click();
@@ -72,14 +64,8 @@ public void ComponentDisposeMethodThrowsExceptionTerminatesTheCircuit()
7264
targetButton.Click();
7365
// Clicking it again hides the component and invokes the rethrow which triggers the exception
7466
targetButton.Click();
75-
Browser.Exists(By.CssSelector("#blazor-error-ui[style='display: block;']"));
76-
77-
// Dismiss the error UI by clicking the dismiss button
78-
var dismissButton = Browser.Exists(By.CssSelector("#blazor-error-ui .dismiss"));
79-
dismissButton.Click();
8067

81-
// Wait for error UI to be hidden
82-
Browser.Exists(By.CssSelector("#blazor-error-ui[style='display: none;']"));
68+
DismissBlazorErrorUI();
8369

8470
// Clicking it again causes the circuit to disconnect
8571
targetButton.Click();
@@ -107,4 +93,17 @@ void AssertLogContains(params string[] messages)
10793
Assert.Contains(log, entry => entry.Message.Contains(message));
10894
}
10995
}
96+
97+
void DismissBlazorErrorUI()
98+
{
99+
// Triggering an error will show the exception UI
100+
Browser.Exists(By.CssSelector("#blazor-error-ui[style='display: block;']"));
101+
102+
// Dismiss the error UI by clicking the dismiss button
103+
var dismissButton = Browser.Exists(By.CssSelector("#blazor-error-ui .dismiss"));
104+
dismissButton.Click();
105+
106+
// Wait for error UI to be hidden
107+
Browser.Exists(By.CssSelector("#blazor-error-ui[style='display: none;']"));
108+
}
110109
}

0 commit comments

Comments
 (0)