address PR comments

Author: DeagleGross

src/Http/Owin/src/DictionaryStringArrayWrapper.cs

@@ -55,11 +55,11 @@ void ICollection<KeyValuePair<string, string[]>>.CopyTo(KeyValuePair<string, str
         }
     }
 
-    public Enumerator GetEnumerator() => new Enumerator(Inner);
+    public ConvertingEnumerator GetEnumerator() => new ConvertingEnumerator(Inner);
 
-    IEnumerator<KeyValuePair<string, string[]>> IEnumerable<KeyValuePair<string, string[]>>.GetEnumerator() => new Enumerator(Inner);
+    IEnumerator<KeyValuePair<string, string[]>> IEnumerable<KeyValuePair<string, string[]>>.GetEnumerator() => new ConvertingEnumerator(Inner);
 
-    IEnumerator IEnumerable.GetEnumerator() => new Enumerator(Inner);
+    IEnumerator IEnumerable.GetEnumerator() => new ConvertingEnumerator(Inner);
 
     bool ICollection<KeyValuePair<string, string[]>>.Remove(KeyValuePair<string, string[]> item) => Inner.Remove(Convert(item));
 
@@ -77,12 +77,12 @@ bool IDictionary<string, string[]>.TryGetValue(string key, out string[] value)
         return false;
     }
 
-    public struct Enumerator : IEnumerator<KeyValuePair<string, string[]>>, IEnumerator
+    public struct ConvertingEnumerator : IEnumerator<KeyValuePair<string, string[]>>, IEnumerator
     {
         private IEnumerator<KeyValuePair<string, StringValues>> _inner;
         private KeyValuePair<string, string[]> _current;
 
-        internal Enumerator(IDictionary<string, StringValues> inner)
+        internal ConvertingEnumerator(IDictionary<string, StringValues> inner)
         {
             _inner = inner.GetEnumerator();
             _current = default;

src/Http/Owin/src/DictionaryStringValuesWrapper.cs

@@ -100,11 +100,11 @@ void ICollection<KeyValuePair<string, StringValues>>.CopyTo(KeyValuePair<string,
         }
     }
 
-    public Enumerator GetEnumerator() => new Enumerator(Inner);
+    public ConvertingEnumerator GetEnumerator() => new ConvertingEnumerator(Inner);
 
-    IEnumerator<KeyValuePair<string, StringValues>> IEnumerable<KeyValuePair<string, StringValues>>.GetEnumerator() => new Enumerator(Inner);
+    IEnumerator<KeyValuePair<string, StringValues>> IEnumerable<KeyValuePair<string, StringValues>>.GetEnumerator() => new ConvertingEnumerator(Inner);
 
-    IEnumerator IEnumerable.GetEnumerator() => new Enumerator(Inner);
+    IEnumerator IEnumerable.GetEnumerator() => new ConvertingEnumerator(Inner);
 
     bool ICollection<KeyValuePair<string, StringValues>>.Remove(KeyValuePair<string, StringValues> item) => Inner.Remove(Convert(item));
 
@@ -122,12 +122,12 @@ bool IDictionary<string, StringValues>.TryGetValue(string key, out StringValues
         return false;
     }
 
-    public struct Enumerator : IEnumerator<KeyValuePair<string, StringValues>>, IEnumerator
+    public struct ConvertingEnumerator : IEnumerator<KeyValuePair<string, StringValues>>, IEnumerator
     {
         private IEnumerator<KeyValuePair<string, string[]>> _inner;
         private KeyValuePair<string, StringValues> _current;
 
-        internal Enumerator(IDictionary<string, string[]> inner)
+        internal ConvertingEnumerator(IDictionary<string, string[]> inner)
         {
             _inner = inner.GetEnumerator();
             _current = default;

src/Http/Owin/src/OwinEnvironment.cs

@@ -555,7 +555,7 @@ public bool Remove(string key)
 
             if (_entries.ContainsKey(key) || _contextDependentEntries.ContainsKey(key))
             {
-                _deletedKeys ??= new HashSet<string>();
+                _deletedKeys ??= new HashSet<string>(StringComparer.Ordinal);
                 return _deletedKeys.Add(key);
             }
 
@@ -606,11 +606,11 @@ void InitializeContextEntries(bool emptyCollection = false)
         {
             if (emptyCollection)
             {
-                _contextEntries = new Dictionary<string, FeatureMap>();
+                _contextEntries = new Dictionary<string, FeatureMap>(StringComparer.Ordinal);
                 return;
             }
 
-            _contextEntries = new Dictionary<string, FeatureMap>(_entries);
+            _contextEntries = new Dictionary<string, FeatureMap>(_entries, StringComparer.Ordinal);
             foreach (var entry in _contextDependentEntries)
             {
                 _contextEntries[entry.Key] = entry.Value;