init

Author: DeagleGross

src/Servers/Kestrel/Core/src/Middleware/TlsListener.cs

@@ -94,6 +94,13 @@ private static ClientHelloParseState TryParseClientHello(ReadOnlySequence<byte>
             return ClientHelloParseState.NotEnoughData;
         }
 
+        // this means we finally got a full tls record, so we can return without parsing again
+        if (recordLength != -1)
+        {
+            clientHelloBytes = buffer.Slice(0, 5 + recordLength);
+            return ClientHelloParseState.ValidTlsClientHello;
+        }
+
         if (buffer.Length < 6)
         {
             return ClientHelloParseState.NotEnoughData;

src/Servers/Kestrel/Core/test/TlsListenerMiddlewareTests.cs renamed to src/Servers/Kestrel/Core/test/TlsListenerTests.cs

@@ -28,7 +28,7 @@
 
 namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests;
 
-public class TlsListenerMiddlewareTests
+public class TlsListenerTests
 {
     [Theory]
     [MemberData(nameof(ValidClientHelloData))]
@@ -50,6 +50,29 @@ public Task OnTlsClientHelloAsync_ValidData_MultipleSegments(int id, List<byte[]
     public Task OnTlsClientHelloAsync_InvalidData_MultipleSegments(int id, List<byte[]> packets)
         => RunTlsClientHelloCallbackTest_WithMultipleSegments(id, packets, tlsClientHelloCallbackExpected: false);
 
+    [Fact]
+    public async Task RunTlsClientHelloCallbackTest_WithPreCancelledToken()
+    {
+        var serviceContext = new TestServiceContext();
+
+        var pipe = new Pipe();
+        var writer = pipe.Writer;
+        var reader = new ObservablePipeReader(pipe.Reader);
+
+        var transport = new DuplexPipe(reader, writer);
+        var transportConnection = new DefaultConnectionContext("test", transport, transport);
+
+        var tlsClientHelloCallbackInvoked = false;
+        var middleware = new TlsListener((ctx, data) => { tlsClientHelloCallbackInvoked = true; });
+
+        var cts = new CancellationTokenSource();
+        cts.Cancel();
+
+        await writer.WriteAsync(new byte[1] { 0x16 });
+        await middleware.OnTlsClientHelloAsync(transportConnection, cts.Token);
+        Assert.False(tlsClientHelloCallbackInvoked);
+    }
+
     [Fact]
     public async Task RunTlsClientHelloCallbackTest_DeterministicallyReads()
     {

src/Servers/Kestrel/test/InMemory.FunctionalTests/TlsListenerMiddlewareTests.cs renamed to src/Servers/Kestrel/test/InMemory.FunctionalTests/TlsListenerTests.cs

@@ -21,7 +21,7 @@
 
 namespace InMemory.FunctionalTests;
 
-public class TlsListenerMiddlewareTests : TestApplicationErrorLoggerLoggedTest
+public class TlsListenerTests : TestApplicationErrorLoggerLoggedTest
 {
     private static readonly X509Certificate2 _x509Certificate2 = TestResources.GetTestCertificate();