Feedback

Author: captainsafia

src/Shared/RoslynUtils/SymbolExtensions.cs

@@ -129,17 +129,7 @@ public static bool HasAttributeInheritingFrom(this ISymbol symbol, INamedTypeSym
 
     public static bool TryGetAttributeInheritingFrom(this ISymbol symbol, INamedTypeSymbol baseType, [NotNullWhen(true)] out AttributeData? matchedAttribute)
     {
-        foreach (var attributeData in symbol.GetAttributes())
-        {
-            if (attributeData.AttributeClass is not null && attributeData.AttributeClass.InheritsFrom(baseType))
-            {
-                matchedAttribute = attributeData;
-                return true;
-            }
-        }
-
-        matchedAttribute = null;
-        return false;
+        return symbol.GetAttributes().TryGetAttributeInheritingFrom(baseType, out matchedAttribute);
     }
 
     public static bool HasAttributeInheritingFrom(this ImmutableArray<AttributeData> attributes, INamedTypeSymbol baseType)

src/SignalR/server/Core/src/Internal/HubMethodDescriptor.cs

@@ -88,7 +88,7 @@ public HubMethodDescriptor(ObjectMethodExecutor methodExecutor, IServiceProvider
                         markedParameter = true;
                         MarkServiceParameter(index);
                     }
-                    else if (typeof(FromKeyedServicesAttribute).IsAssignableFrom(attribute.GetType()) && attribute is FromKeyedServicesAttribute keyedServicesAttribute)
+                    else if (attribute is FromKeyedServicesAttribute keyedServicesAttribute)
                     {
                         ThrowIfMarked(markedParameter);
                         markedParameter = true;