Add explanatory comment

amcasey · JamesNK · web-flow · commit 1393ecc26677 · 2024-09-19T10:18:14.000-07:00
Co-authored-by: James Newton-King &lt;james@newtonking.com&gt;
diff --git a/src/Servers/Kestrel/Core/src/Internal/Http3/Http3Connection.cs b/src/Servers/Kestrel/Core/src/Internal/Http3/Http3Connection.cs
@@ -927,7 +927,8 @@ internal WebTransportSession OpenNewWebTransportSession(Http3Stream http3Stream)
 
     private Http3ErrorCode GetErrorCodeOrNoError()
     {
-        return _errorCodeFeature.Error <= 0 ? Http3ErrorCode.NoError : (Http3ErrorCode)_errorCodeFeature.Error;
+        // The default error value is -1. If it hasn't been changed before abort is called then default to HTTP/3's NoError value.
+        return _errorCodeFeature.Error == -1 ? Http3ErrorCode.NoError : (Http3ErrorCode)_errorCodeFeature.Error;
     }
 
     private static class GracefulCloseInitiator

Original file line number	Diff line number	Diff line change
`@@ -927,7 +927,8 @@ internal WebTransportSession OpenNewWebTransportSession(Http3Stream http3Stream)`
`927`	`927`
`928`	`928`	`private Http3ErrorCode GetErrorCodeOrNoError()`
`929`	`929`	`{`
`930`		`- return _errorCodeFeature.Error <= 0 ? Http3ErrorCode.NoError : (Http3ErrorCode)_errorCodeFeature.Error;`
	`930`	`+ // The default error value is -1. If it hasn't been changed before abort is called then default to HTTP/3's NoError value.`
	`931`	`+ return _errorCodeFeature.Error == -1 ? Http3ErrorCode.NoError : (Http3ErrorCode)_errorCodeFeature.Error;`
`931`	`932`	`}`
`932`	`933`
`933`	`934`	`private static class GracefulCloseInitiator`