Make PersistAsync and TryTake methods internal for custom serializers

Co-authored-by: javiercn <[email protected]>

Author: Copilot

src/Components/Components/src/PersistentComponentState.cs

@@ -119,7 +119,7 @@ internal void PersistAsJson(string key, object instance, [DynamicallyAccessedMem
     /// <param name="instance">The instance to persist.</param>
     /// <param name="serializer">The custom serializer to use for serialization.</param>
     /// <param name="cancellationToken">A cancellation token that can be used to cancel the serialization operation.</param>
-    public async Task PersistAsync<TValue>(string key, TValue instance, IPersistentComponentStateSerializer<TValue> serializer, CancellationToken cancellationToken = default)
+    internal async Task PersistAsync<TValue>(string key, TValue instance, IPersistentComponentStateSerializer<TValue> serializer, CancellationToken cancellationToken = default)
     {
         ArgumentNullException.ThrowIfNull(key);
         ArgumentNullException.ThrowIfNull(serializer);
@@ -194,7 +194,7 @@ internal bool TryTakeFromJson(string key, [DynamicallyAccessedMembers(JsonSerial
     /// <param name="serializer">The custom serializer to use for deserialization.</param>
     /// <param name="instance">The persisted instance.</param>
     /// <returns><c>true</c> if the state was found; <c>false</c> otherwise.</returns>
-    public bool TryTake<TValue>(string key, IPersistentComponentStateSerializer<TValue> serializer, [MaybeNullWhen(false)] out TValue instance)
+    internal bool TryTake<TValue>(string key, IPersistentComponentStateSerializer<TValue> serializer, [MaybeNullWhen(false)] out TValue instance)
     {
         ArgumentNullException.ThrowIfNull(key);
         ArgumentNullException.ThrowIfNull(serializer);

src/Components/Components/src/PersistentStateValueProvider.cs

@@ -49,7 +49,7 @@ public bool CanSupplyValue(in CascadingParameterInfo parameterInfo)
         if (customSerializer != null)
         {
             // Use reflection to call the generic TryTake method with the custom serializer
-            var tryTakeMethod = typeof(PersistentComponentState).GetMethod(nameof(PersistentComponentState.TryTake), BindingFlags.Instance | BindingFlags.Public, [typeof(string), serializerType, parameterInfo.PropertyType.MakeByRefType()]);
+            var tryTakeMethod = typeof(PersistentComponentState).GetMethod(nameof(PersistentComponentState.TryTake), BindingFlags.Instance | BindingFlags.NonPublic, [typeof(string), serializerType, parameterInfo.PropertyType.MakeByRefType()]);
             if (tryTakeMethod != null)
             {
                 var parameters = new object?[] { storageKey, customSerializer, null };
@@ -86,7 +86,7 @@ public void Subscribe(ComponentState subscriber, in CascadingParameterInfo param
                 if (customSerializer != null)
                 {
                     // Use reflection to call the generic PersistAsync method with the custom serializer
-                    var persistMethod = typeof(PersistentComponentState).GetMethod(nameof(PersistentComponentState.PersistAsync), BindingFlags.Instance | BindingFlags.Public, [typeof(string), propertyType, serializerType, typeof(CancellationToken)]);
+                    var persistMethod = typeof(PersistentComponentState).GetMethod(nameof(PersistentComponentState.PersistAsync), BindingFlags.Instance | BindingFlags.NonPublic, [typeof(string), propertyType, serializerType, typeof(CancellationToken)]);
                     if (persistMethod != null)
                     {
                         var task = (Task)persistMethod.Invoke(state, [storageKey, property, customSerializer, CancellationToken.None])!;

src/Components/Components/src/PublicAPI.Unshipped.txt

@@ -24,5 +24,3 @@ virtual Microsoft.AspNetCore.Components.Rendering.ComponentState.GetComponentKey
 Microsoft.AspNetCore.Components.IPersistentComponentStateSerializer<T>
 Microsoft.AspNetCore.Components.IPersistentComponentStateSerializer<T>.PersistAsync(T value, System.Buffers.IBufferWriter<byte>! writer, System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.Task!
 Microsoft.AspNetCore.Components.IPersistentComponentStateSerializer<T>.Restore(System.Buffers.ReadOnlySequence<byte> data) -> T
-Microsoft.AspNetCore.Components.PersistentComponentState.PersistAsync<TValue>(string! key, TValue instance, Microsoft.AspNetCore.Components.IPersistentComponentStateSerializer<TValue>! serializer, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task!
-Microsoft.AspNetCore.Components.PersistentComponentState.TryTake<TValue>(string! key, Microsoft.AspNetCore.Components.IPersistentComponentStateSerializer<TValue>! serializer, out TValue instance) -> bool