Skip to content

Commit 16be480

Browse files
authored
Quarantine tests and bump Helix timeouts (#23762)
- see #23756 and #23757 for more info on quarantined tests - see #23760 for more info on Helix timeouts
1 parent d0ab959 commit 16be480

File tree

9 files changed

+12
-1
lines changed

9 files changed

+12
-1
lines changed

eng/targets/Helix.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
<PropertyGroup>
1313
<CreateHelixPayload>true</CreateHelixPayload>
1414
<HelixTimeout>00:30:00</HelixTimeout>
15+
<HelixTimeout Condition="$(HelixTargetQueue.StartsWith('Windows.10.Amd64'))">00:40:00</HelixTimeout>
1516
<RunQuarantinedTests>false</RunQuarantinedTests>
1617
<IsWindowsHelixQueue>false</IsWindowsHelixQueue>
1718
<IsWindowsHelixQueue Condition="$(HelixTargetQueue.Contains('Windows')) or $(HelixTargetQueue.Contains('windows'))">true</IsWindowsHelixQueue>

src/Components/test/E2ETest/Tests/EventBubblingTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ public void PreventDefault_WorksOnAncestorElement()
165165
}
166166

167167
[Fact]
168+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23757")]
168169
public void PreventDefaultCanBlockKeystrokes()
169170
{
170171
// By default, the textbox accepts keystrokes

src/Components/test/E2ETest/Tests/EventTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,7 @@ public void InputEvent_RespondsOnKeystrokes()
185185
}
186186

187187
[Fact]
188+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23757")]
188189
public void InputEvent_RespondsOnKeystrokes_EvenIfUpdatesAreLaggy()
189190
{
190191
// This test doesn't mean much on WebAssembly - it just shows that even if the CPU is locked

src/Razor/Microsoft.NET.Sdk.Razor/integrationtests/MvcBuildIntegrationTestLegacy.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ public async Task PublishingProject_CopyToPublishDirectoryItems()
125125
}
126126

127127
[Fact]
128+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23756")]
128129
public virtual async Task Publish_IncludesRefAssemblies_WhenCopyRefAssembliesToPublishDirectoryIsSet()
129130
{
130131
using (CreateTestProject())

src/Razor/Microsoft.NET.Sdk.Razor/integrationtests/StaticWebAssetsIntegrationTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ public async Task Build_DoesNotEmbedManifestWhen_NoStaticResourcesAvailable()
166166
}
167167

168168
[Fact]
169+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23756")]
169170
[InitializeTestProject("AppWithPackageAndP2PReference", language: "C#", additionalProjects: new[] { "ClassLibrary", "ClassLibrary2" })]
170171
public async Task Clean_Success_RemovesManifestAndCache()
171172
{

src/Razor/Microsoft.NET.Sdk.Razor/integrationtests/Wasm/WasmCompressionTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ public async Task Publish_WithoutLinkerAndCompression_UpdatesFilesWhenSourcesCha
8181
}
8282

8383
[Fact]
84+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23756")]
8485
public async Task Publish_WithLinkerAndCompression_IsIncremental()
8586
{
8687
// Arrange

src/Razor/Microsoft.NET.Sdk.Razor/integrationtests/Wasm/WasmPublishIntegrationTest.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@ public async Task Publish_WithTrimmingdDisabled_Works()
232232
}
233233

234234
[Fact]
235+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23756")]
235236
public async Task Publish_SatelliteAssemblies_AreCopiedToBuildOutput()
236237
{
237238
// Arrange
@@ -325,6 +326,7 @@ public async Task Publish_HostedApp_DefaultSettings_Works()
325326
}
326327

327328
[Fact]
329+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23756")]
328330
public async Task Publish_HostedApp_ProducesBootJsonDataWithExpectedContent()
329331
{
330332
// Arrange

src/Razor/Microsoft.NET.Sdk.Razor/integrationtests/Wasm/WasmPwaManifestTests.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
using System.Text.Json;
77
using System.Text.RegularExpressions;
88
using System.Threading.Tasks;
9+
using Microsoft.AspNetCore.Testing;
910
using Xunit;
1011
using static Microsoft.AspNetCore.Razor.Design.IntegrationTests.ServiceWorkerAssert;
1112

@@ -47,7 +48,7 @@ public async Task Build_ServiceWorkerAssetsManifest_Works()
4748
var entries = assets.EnumerateArray().Select(e => e.GetProperty("url").GetString()).OrderBy(e => e).ToArray();
4849
Assert.All(entries, e => expectedExtensions.Contains(Path.GetExtension(e)));
4950

50-
VerifyServiceWorkerFiles(result,
51+
VerifyServiceWorkerFiles(result,
5152
Path.Combine(buildOutputDirectory, "wwwroot"),
5253
serviceWorkerPath: Path.Combine("serviceworkers", "my-service-worker.js"),
5354
serviceWorkerContent: "// This is the development service worker",
@@ -110,6 +111,7 @@ public async Task PublishWithPWA_ProducesAssets()
110111
}
111112

112113
[Fact]
114+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23756")]
113115
public async Task PublishHostedWithPWA_ProducesAssets()
114116
{
115117
// Arrange

src/Servers/IIS/IIS/test/FunctionalTest.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
<PropertyGroup>
44
<HelixTimeout>00:45:00</HelixTimeout>
5+
<HelixTimeout Condition="$(HelixTargetQueue.StartsWith('Windows.10.Amd64'))">01:00:00</HelixTimeout>
56
</PropertyGroup>
67

78
<ItemGroup>

0 commit comments

Comments
 (0)