Skip to content

Commit 1770dcf

Browse files
authored
Skip WebSocketOutOfProcessTests on Windows.Amd64.Server2022.Open (#59112)
* Skip WebSocketOutOfProcessTests on Windows.Amd64.Server2022.Open * Use if-def from base class * Fix in-proc and remove attributes from abstract class
1 parent 04c0bc3 commit 1770dcf

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

src/Servers/IIS/IIS/test/Common.FunctionalTests/WebSocketInProcessTests.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,12 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
2323

2424
[Collection(IISTestSiteCollectionInProc.Name)]
2525
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "No WebSocket supported on Win7")]
26-
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
26+
#if IISEXPRESS_FUNCTIONALS
27+
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open")]
28+
#else
29+
// These queues do not have websockets enabled currently for full IIS
30+
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;Windows.Amd64.Server2022.Open")]
31+
#endif
2732
public class WebSocketsInProcessTests : WebSocketsTests
2833
{
2934
public WebSocketsInProcessTests(IISTestSiteFixture fixture, ITestOutputHelper testOutput) : base(fixture, testOutput)

src/Servers/IIS/IIS/test/Common.FunctionalTests/WebSocketOutOfProcessTests.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,12 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
2323

2424
[Collection(IISTestSiteCollectionOutOfProc.Name)]
2525
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "No WebSocket supported on Win7")]
26-
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
26+
#if IISEXPRESS_FUNCTIONALS
27+
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open")]
28+
#else
29+
// These queues do not have websockets enabled currently for full IIS
30+
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;Windows.Amd64.Server2022.Open")]
31+
#endif
2732
public class WebSocketsOutOfProcessTests : WebSocketsTests
2833
{
2934
public WebSocketsOutOfProcessTests(IISTestSiteFixture fixture, ITestOutputHelper testOutput) : base(fixture, testOutput)

src/Servers/IIS/IIS/test/Common.FunctionalTests/WebSocketTests.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,6 @@ namespace Microsoft.AspNetCore.Server.IIS.NewShim.FunctionalTests;
2828
namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
2929
#endif
3030

31-
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "No WebSocket supported on Win7")]
32-
#if IISEXPRESS_FUNCTIONALS
33-
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open")]
34-
#else
35-
// These queues do not have websockets enabled currently for full IIS
36-
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;Windows.Amd64.Server2022.Open")]
37-
#endif
3831
public abstract class WebSocketsTests : FunctionalTestsBase
3932
{
4033
public IISTestSiteFixture Fixture { get; }

0 commit comments

Comments
 (0)