feedback

Author: pavelsavara

src/Components/Components/src/ComponentsActivitySource.cs

@@ -11,9 +11,9 @@ namespace Microsoft.AspNetCore.Components;
 internal class ComponentsActivitySource
 {
     internal const string Name = "Microsoft.AspNetCore.Components";
-    internal const string OnCircuitName = $"{Name}.OnCircuit";
-    internal const string OnRouteName = $"{Name}.OnRoute";
-    internal const string OnEventName = $"{Name}.OnEvent";
+    internal const string OnCircuitName = $"{Name}.CircuitStart";
+    internal const string OnRouteName = $"{Name}.RouteChange";
+    internal const string OnEventName = $"{Name}.Event";
 
     private ActivityContext _httpContext;
     private ActivityContext _circuitContext;
@@ -146,7 +146,7 @@ public void FailCircuitActivity(Activity? activity, Exception ex)
                 }
             }
 
-            activity.DisplayName = $"Event {attributeName ?? "[unknown]"} -> {componentType ?? "[unknown]"}.{methodName ?? "[unknown]"}";
+            activity.DisplayName = $"Event {attributeName ?? "[unknown attribute]"} -> {componentType ?? "[unknown component]"}.{methodName ?? "[unknown method]"}";
             activity.Start();
         }
         return activity;

src/Components/Components/src/ComponentsMetrics.cs

@@ -64,7 +64,7 @@ public ComponentsMetrics(IMeterFactory meterFactory)
             "aspnetcore.components.update_parameters.duration",
             unit: "s",
             description: "Duration of processing component parameters.",
-            advice: new InstrumentAdvice<double> { HistogramBucketBoundaries = MetricsConstants.ShortSecondsBucketBoundaries });
+            advice: new InstrumentAdvice<double> { HistogramBucketBoundaries = MetricsConstants.BlazorParametersUpdateSecondsBucketBoundaries });
 
         _parametersException = _lifeCycleMeter.CreateCounter<long>(
             "aspnetcore.components.update_parameters.exceptions",
@@ -75,7 +75,7 @@ public ComponentsMetrics(IMeterFactory meterFactory)
             "aspnetcore.components.rendering.batch.duration",
             unit: "s",
             description: "Duration of rendering batch.",
-            advice: new InstrumentAdvice<double> { HistogramBucketBoundaries = MetricsConstants.ShortSecondsBucketBoundaries });
+            advice: new InstrumentAdvice<double> { HistogramBucketBoundaries = MetricsConstants.BlazorBatchDiffSecondsBucketBoundaries });
 
         _batchException = _lifeCycleMeter.CreateCounter<long>(
             "aspnetcore.components.rendering.batch.exceptions",
@@ -140,7 +140,7 @@ public void BatchDuration(long startTimestamp, int diffLength)
     {
         var tags = new TagList
         {
-            { "diff.length.bucket", BucketEditLength(diffLength) }
+            { "diff.approximate.length", BucketEditLength(diffLength) }
         };
 
         var duration = Stopwatch.GetElapsedTime(startTimestamp);

src/Components/Components/test/ComponentsMetricsTest.cs

@@ -94,7 +94,7 @@ public void BatchDuration_RecordsDuration()
 
         Assert.Single(measurements);
         Assert.True(measurements[0].Value > 0);
-        Assert.Equal(50, measurements[0].Tags["diff.length.bucket"]);
+        Assert.Equal(50, measurements[0].Tags["diff.approximate.length"]);
     }
 
     [Fact]

src/Components/Server/src/Circuits/CircuitMetrics.cs

@@ -42,7 +42,7 @@ public CircuitMetrics(IMeterFactory meterFactory)
             "aspnetcore.components.circuits.duration",
             unit: "s",
             description: "Duration of circuit.",
-            advice: new InstrumentAdvice<double> { HistogramBucketBoundaries = MetricsConstants.VeryLongSecondsBucketBoundaries });
+            advice: new InstrumentAdvice<double> { HistogramBucketBoundaries = MetricsConstants.BlazorCircuitSecondsBucketBoundaries });
     }
 
     public void OnCircuitOpened()

src/Shared/Metrics/MetricsConstants.cs

@@ -11,6 +11,12 @@ internal static class MetricsConstants
     // Not based on a standard. Larger bucket sizes for longer lasting operations, e.g. HTTP connection duration. See https://github.com/open-telemetry/semantic-conventions/issues/336
     public static readonly IReadOnlyList<double> LongSecondsBucketBoundaries = [0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1, 2, 5, 10, 30, 60, 120, 300];
 
+    // For blazor rendering, which should be very fast.
+    public static readonly IReadOnlyList<double> BlazorParametersUpdateSecondsBucketBoundaries = [0.000001, 0.00001, 0.0001, 0.001, 0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1, 2.5, 5, 7.5, 10];
+
+    // For blazor rendering, which should be very fast.
+    public static readonly IReadOnlyList<double> BlazorBatchDiffSecondsBucketBoundaries = [0.000001, 0.00001, 0.0001, 0.001, 0.01, 0.1, 1];
+
     // For blazor circuit sessions, which can last a long time.
-    public static readonly IReadOnlyList<double> VeryLongSecondsBucketBoundaries = [1, 10, 30, 1 * 60, 2 * 60, 3 * 60, 4 * 60, 5 * 60, 6 * 60, 7 * 60, 8 * 60, 9 * 60, 10 * 60, 1 * 60 * 60, 2 * 60 * 60, 3 * 60 * 60, 6 * 60 * 60, 12 * 60 * 60, 24 * 60 * 60];
+    public static readonly IReadOnlyList<double> BlazorCircuitSecondsBucketBoundaries = [1, 3, 10, 30, 1 * 60, 3 * 60, 10 * 60, 30 * 60, 1 * 60 * 60, 3 * 60 * 60, 10 * 60 * 60, 24 * 60 * 60];
 }