Log StatusCode explicitly as an integer in the LoggingHttpMessageHandler

sschneider · rynowak · commit 1ddae6607447 · 2019-11-26T12:57:57.000-08:00
\n\nCommit migrated from dotnet/extensions@d8c0d59
diff --git a/src/HttpClientFactory/Http/src/Logging/LoggingHttpMessageHandler.cs b/src/HttpClientFactory/Http/src/Logging/LoggingHttpMessageHandler.cs
@@ -64,7 +64,7 @@ public static class EventIds
                 EventIds.RequestStart,
                 "Sending HTTP request {HttpMethod} {Uri}");
 
-            private static readonly Action<ILogger, double, HttpStatusCode, Exception> _requestEnd = LoggerMessage.Define<double, HttpStatusCode>(
+            private static readonly Action<ILogger, double, int, Exception> _requestEnd = LoggerMessage.Define<double, int>(
                 LogLevel.Information,
                 EventIds.RequestEnd,
                 "Received HTTP response headers after {ElapsedMilliseconds}ms - {StatusCode}");
@@ -86,7 +86,7 @@ public static void RequestStart(ILogger logger, HttpRequestMessage request)
 
             public static void RequestEnd(ILogger logger, HttpResponseMessage response, TimeSpan duration)
             {
-                _requestEnd(logger, duration.TotalMilliseconds, response.StatusCode, null);
+                _requestEnd(logger, duration.TotalMilliseconds, (int)response.StatusCode, null);
 
                 if (logger.IsEnabled(LogLevel.Trace))
                 {

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ public static class EventIds`
`64`	`64`	`EventIds.RequestStart,`
`65`	`65`	`"Sending HTTP request {HttpMethod} {Uri}");`
`66`	`66`
`67`		`- private static readonly Action<ILogger, double, HttpStatusCode, Exception> _requestEnd = LoggerMessage.Define<double, HttpStatusCode>(`
	`67`	`+ private static readonly Action<ILogger, double, int, Exception> _requestEnd = LoggerMessage.Define<double, int>(`
`68`	`68`	`LogLevel.Information,`
`69`	`69`	`EventIds.RequestEnd,`
`70`	`70`	`"Received HTTP response headers after {ElapsedMilliseconds}ms - {StatusCode}");`
`@@ -86,7 +86,7 @@ public static void RequestStart(ILogger logger, HttpRequestMessage request)`
`86`	`86`
`87`	`87`	`public static void RequestEnd(ILogger logger, HttpResponseMessage response, TimeSpan duration)`
`88`	`88`	`{`
`89`		`- _requestEnd(logger, duration.TotalMilliseconds, response.StatusCode, null);`
	`89`	`+ _requestEnd(logger, duration.TotalMilliseconds, (int)response.StatusCode, null);`
`90`	`90`
`91`	`91`	`if (logger.IsEnabled(LogLevel.Trace))`
`92`	`92`	`{`