Update

Author: JamesNK

src/Identity/Core/src/SignInManagerMetrics.cs

@@ -30,7 +30,7 @@ public SignInManagerMetrics(IMeterFactory meterFactory)
     {
         _meter = meterFactory.Create(MeterName);
 
-        _authenticateDuration = _meter.CreateHistogram<double>(AuthenticateDurationName, "s", "The number of authenticate attempts. The authenticate counter is incremented by sign in methods such as PasswordSignInAsync and TwoFactorSignInAsync.");
+        _authenticateDuration = _meter.CreateHistogram<double>(AuthenticateDurationName, "s", "The duration of authenticate attempts. The authenticate metrics is recorded by sign in methods such as PasswordSignInAsync and TwoFactorSignInAsync.");
         _rememberTwoFactorClientCounter = _meter.CreateCounter<long>(RememberedTwoFactorCounterName, "{client}", "The number of two factor clients remembered.");
         _forgetTwoFactorCounter = _meter.CreateCounter<long>(ForgottenTwoFactorCounterName, "{client}", "The number of two factor clients forgotten.");
         _checkPasswordCounter = _meter.CreateCounter<long>(CheckPasswordAttemptsCounterName, "{attempts}", "The number of check password attempts. Checks that the account is in a state that can log in and that the password is valid using the UserManager.CheckPasswordAsync method.");

src/Identity/Extensions.Core/src/UserManagerMetrics.cs

@@ -18,7 +18,7 @@ internal sealed class UserManagerMetrics : IDisposable
     public const string CreateDurationName = "aspnetcore.identity.user.create.duration";
     public const string UpdateDurationName = "aspnetcore.identity.user.update.duration";
     public const string DeleteDurationName = "aspnetcore.identity.user.delete.duration";
-    public const string CheckPasswordCounterName = "aspnetcore.identity.user.check_password_attempts";
+    public const string CheckPasswordAttemptsCounterName = "aspnetcore.identity.user.check_password_attempts";
     public const string VerifyTokenAttemptsCounterName = "aspnetcore.identity.user.verify_token_attempts";
     public const string GenerateTokensCounterName = "aspnetcore.identity.user.generated_tokens";
 
@@ -33,10 +33,10 @@ internal sealed class UserManagerMetrics : IDisposable
     public UserManagerMetrics(IMeterFactory meterFactory)
     {
         _meter = meterFactory.Create(MeterName);
-        _createDuration = _meter.CreateHistogram<double>(CreateDurationName, "s", "The number of users created.");
-        _updateDuration = _meter.CreateHistogram<double>(UpdateDurationName, "s", "The number of users updated.");
-        _deleteDuration = _meter.CreateHistogram<double>(DeleteDurationName, "s", "The number of users deleted.");
-        _checkPasswordAttemptsCounter = _meter.CreateCounter<long>(CheckPasswordCounterName, "{attempt}", "The number of check password attempts. Only checks whether the password is valid and not whether the user account is in a state that can log in.");
+        _createDuration = _meter.CreateHistogram<double>(CreateDurationName, "s", "The duration of creating users.");
+        _updateDuration = _meter.CreateHistogram<double>(UpdateDurationName, "s", "The duration of updating users.");
+        _deleteDuration = _meter.CreateHistogram<double>(DeleteDurationName, "s", "The duration of deleting users.");
+        _checkPasswordAttemptsCounter = _meter.CreateCounter<long>(CheckPasswordAttemptsCounterName, "{attempt}", "The number of check password attempts. Only checks whether the password is valid and not whether the user account is in a state that can log in.");
         _verifyTokenAttemptsCounter = _meter.CreateCounter<long>(VerifyTokenAttemptsCounterName, "{attempt}", "The number of token verification attempts.");
         _generateTokensCounter = _meter.CreateCounter<long>(GenerateTokensCounterName, "{count}", "The number of token generations.");
     }

src/Identity/test/Identity.Test/UserManagerTest.cs

@@ -628,7 +628,7 @@ public async Task CheckPasswordWillRehashPasswordWhenNeeded()
         // Setup
         var testMeterFactory = new TestMeterFactory();
         using var updateUser = new MetricCollector<double>(testMeterFactory, "Microsoft.AspNetCore.Identity", UserManagerMetrics.UpdateDurationName);
-        using var checkPassword = new MetricCollector<long>(testMeterFactory, "Microsoft.AspNetCore.Identity", UserManagerMetrics.CheckPasswordCounterName);
+        using var checkPassword = new MetricCollector<long>(testMeterFactory, "Microsoft.AspNetCore.Identity", UserManagerMetrics.CheckPasswordAttemptsCounterName);
 
         var store = new Mock<IUserPasswordStore<PocoUser>>();
         var hasher = new Mock<IPasswordHasher<PocoUser>>();
@@ -864,7 +864,7 @@ public async Task RemovePasskeyAsyncCallsStore()
     public async Task CheckPasswordWithNullUserReturnsFalse()
     {
         var testMeterFactory = new TestMeterFactory();
-        using var checkPassword = new MetricCollector<long>(testMeterFactory, "Microsoft.AspNetCore.Identity", UserManagerMetrics.CheckPasswordCounterName);
+        using var checkPassword = new MetricCollector<long>(testMeterFactory, "Microsoft.AspNetCore.Identity", UserManagerMetrics.CheckPasswordAttemptsCounterName);
 
         var manager = MockHelpers.TestUserManager(new EmptyStore(), meterFactory: testMeterFactory);
         Assert.False(await manager.CheckPasswordAsync(null, "whatevs"));
@@ -970,7 +970,7 @@ public async Task PasswordMethodsFailWhenStoreNotImplemented()
         var testMeterFactory = new TestMeterFactory();
         using var createUser = new MetricCollector<double>(testMeterFactory, "Microsoft.AspNetCore.Identity", UserManagerMetrics.CreateDurationName);
         using var updateUser = new MetricCollector<double>(testMeterFactory, "Microsoft.AspNetCore.Identity", UserManagerMetrics.UpdateDurationName);
-        using var checkPassword = new MetricCollector<long>(testMeterFactory, "Microsoft.AspNetCore.Identity", UserManagerMetrics.CheckPasswordCounterName);
+        using var checkPassword = new MetricCollector<long>(testMeterFactory, "Microsoft.AspNetCore.Identity", UserManagerMetrics.CheckPasswordAttemptsCounterName);
 
         var manager = MockHelpers.TestUserManager(new NoopUserStore(), meterFactory: testMeterFactory);
         Assert.False(manager.SupportsUserPassword);