Skip to content

Commit 233105d

Browse files
committed
Unduplicate
1 parent d3125f6 commit 233105d

File tree

2 files changed

+50
-4
lines changed

2 files changed

+50
-4
lines changed

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,22 @@
3434
<DisablePackageReferenceRestrictions>true</DisablePackageReferenceRestrictions>
3535
</PropertyGroup>
3636

37+
<PropertyGroup>
38+
<GetSharedFrameworkFilesForReadyToRunDependsOn>
39+
$(GetSharedFrameworkFilesForReadyToRunDependsOn);
40+
_AddExtensionsSymbolsToSymbolPack;
41+
</GetSharedFrameworkFilesForReadyToRunDependsOn>
42+
</PropertyGroup>
43+
3744
<ItemGroup>
3845
<PackageReference Include="Microsoft.Internal.Runtime.AspNetCore.Transport"
39-
Version="$(MicrosoftInternalRuntimeAspNetCoreTransportVersion)" />
46+
Version="$(MicrosoftInternalRuntimeAspNetCoreTransportVersion)"
47+
ExcludeAssets="All"
48+
GeneratePathProperty="true" />
4049
</ItemGroup>
4150

4251
<ItemGroup>
43-
<Reference Include="@(AspNetCoreAppReference);@(AspNetCoreAppReferenceAndPackage)">
52+
<Reference Include="@(AspNetCoreAppReference);@(AspNetCoreAppReferenceAndPackage);@(ExternalAspNetCoreAppReference)">
4453
<IncludeAssets>Runtime;Native</IncludeAssets>
4554
</Reference>
4655
</ItemGroup>
@@ -92,6 +101,20 @@
92101
Include="$(ArtifactsBinDir)InProcessRequestHandler\$(NativePlatform)\$(Configuration)\aspnetcorev2_inprocess.pdb" />
93102
</ItemGroup>
94103

104+
<Target Name="_AddExtensionsSymbolsToSymbolPack">
105+
<!-- Explicitly include symbols for libraries we redistribute from runtime -->
106+
<ItemGroup>
107+
<_TransportPdbs Include="$(PkgMicrosoft_Internal_Runtime_AspNetCore_Transport)\**\*.pdb"
108+
Exclude="$(PkgMicrosoft_Internal_Runtime_AspNetCore_Transport)\**\*.ni.pdb" />
109+
110+
<_TransportPdbsWithName Include="@(_TransportPdbs)"
111+
Name="%(Filename)" />
112+
113+
<_SymbolFilesToPackage Include="@(_TransportPdbsWithName)"
114+
Condition="'@(ExternalAspNetCoreAppReference->AnyHaveMetadataValue('Identity', '%(Name)'))' == 'true'" />
115+
</ItemGroup>
116+
</Target>
117+
95118
<Target Name="_WarnAboutUnbuiltNativeDependencies"
96119
BeforeTargets="Build"
97120
Condition=" '$(UseIisNativeAssets)' == 'true' AND !$(BuildNative) AND

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,22 @@
5050
<GenerateVSInsertionPackages>true</GenerateVSInsertionPackages>
5151
</PropertyGroup>
5252

53+
<PropertyGroup>
54+
<GetSharedFrameworkFilesForReadyToRunDependsOn>
55+
$(GetSharedFrameworkFilesForReadyToRunDependsOn);
56+
_AddExtensionsSymbolsToSymbolPack;
57+
</GetSharedFrameworkFilesForReadyToRunDependsOn>
58+
</PropertyGroup>
59+
5360
<ItemGroup>
5461
<PackageReference Include="Microsoft.Internal.Runtime.AspNetCore.Transport"
55-
Version="$(MicrosoftInternalRuntimeAspNetCoreTransportVersion)" />
62+
Version="$(MicrosoftInternalRuntimeAspNetCoreTransportVersion)"
63+
ExcludeAssets="All"
64+
GeneratePathProperty="true" />
5665
</ItemGroup>
5766

5867
<ItemGroup>
59-
<Reference Include="@(AspNetCoreAppReference);@(AspNetCoreAppReferenceAndPackage)">
68+
<Reference Include="@(AspNetCoreAppReference);@(AspNetCoreAppReferenceAndPackage);@(ExternalAspNetCoreAppReference)">
6069
<IncludeAssets>Runtime;Native</IncludeAssets>
6170
</Reference>
6271
</ItemGroup>
@@ -88,6 +97,20 @@
8897
Include="$(ArtifactsBinDir)InProcessRequestHandler\$(NativePlatform)\$(Configuration)\aspnetcorev2_inprocess.pdb" />
8998
</ItemGroup>
9099

100+
<Target Name="_AddExtensionsSymbolsToSymbolPack">
101+
<!-- Explicitly include symbols for libraries we redistribute from runtime -->
102+
<ItemGroup>
103+
<_TransportPdbs Include="$(PkgMicrosoft_Internal_Runtime_AspNetCore_Transport)\**\*.pdb"
104+
Exclude="$(PkgMicrosoft_Internal_Runtime_AspNetCore_Transport)\**\*.ni.pdb" />
105+
106+
<_TransportPdbsWithName Include="@(_TransportPdbs)"
107+
Name="%(Filename)" />
108+
109+
<_SymbolFilesToPackage Include="@(_TransportPdbsWithName)"
110+
Condition="'@(ExternalAspNetCoreAppReference->AnyHaveMetadataValue('Identity', '%(Name)'))' == 'true'" />
111+
</ItemGroup>
112+
</Target>
113+
91114
<Target Name="_WarnAboutUnbuiltNativeDependencies"
92115
BeforeTargets="Build"
93116
Condition=" '$(UseIisNativeAssets)' == 'true' AND !$(BuildNative) AND

0 commit comments

Comments
 (0)