Skip to content

Commit 25e3e3a

Browse files
Fix SkipOnHelix skipping tests that had ';' at the end of the Queues list (#60183)
1 parent 9660fb4 commit 25e3e3a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/Testing/src/xunit/SkipOnHelixAttribute.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ private bool ShouldSkip()
6868

6969
// We have "QueueName" and "QueueName.Open" queues for internal and public builds
7070
// If we want to skip the test in the public queue, we want to skip it in the internal queue, and vice versa
71-
return Queues.ToLowerInvariant().Split(';').Any(q => q.Equals(targetQueue, StringComparison.Ordinal) || q.StartsWith(targetQueue, StringComparison.Ordinal) ||
71+
return Queues.ToLowerInvariant().Split([';'], StringSplitOptions.RemoveEmptyEntries)
72+
.Any(q => q.Equals(targetQueue, StringComparison.Ordinal) || q.StartsWith(targetQueue, StringComparison.Ordinal) ||
7273
targetQueue.StartsWith(q, StringComparison.Ordinal));
7374
}
7475

0 commit comments

Comments
 (0)