Fix record resolution and update tests

Author: captainsafia

src/Validation/gen/Parsers/ValidationsGenerator.TypesParser.cs

@@ -131,12 +131,6 @@ internal ImmutableArray<ValidatableProperty> ExtractValidatableMembers(ITypeSymb
                 // Process all parameters in constructor order to maintain parameter ordering
                 foreach (var parameter in primaryConstructor.Parameters)
                 {
-                    // Skip parameters that are injected as services
-                    if (parameter.IsServiceParameter(fromServiceMetadataSymbol, fromKeyedServiceAttributeSymbol))
-                    {
-                        continue;
-                    }
-
                     // Find the corresponding property in this type, we ignore
                     // base types here since that will be handled by the inheritance
                     // checks in the default ValidatableTypeInfo implementation.
@@ -148,6 +142,12 @@ internal ImmutableArray<ValidatableProperty> ExtractValidatableMembers(ITypeSymb
                     {
                         resolvedRecordProperty.Add(correspondingProperty);
 
+                        // Skip parameters that are injected as services
+                        if (parameter.IsServiceParameter(fromServiceMetadataSymbol, fromKeyedServiceAttributeSymbol))
+                        {
+                            continue;
+                        }
+
                         // Check if the property's type is validatable, this resolves
                         // validatable types in the inheritance hierarchy
                         var hasValidatableType = TryExtractValidatableType(
@@ -173,8 +173,8 @@ internal ImmutableArray<ValidatableProperty> ExtractValidatableMembers(ITypeSymb
         {
             // Skip compiler generated properties and properties already processed via
             // the record processing logic above.
-            if (member.IsImplicitlyDeclared 
-                || member.IsEqualityContract(wellKnownTypes) 
+            if (member.IsImplicitlyDeclared
+                || member.IsEqualityContract(wellKnownTypes)
                 || resolvedRecordProperty.Contains(member, SymbolEqualityComparer.Default))
             {
                 continue;

src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/ValidationsGenerator.RecordType.cs

@@ -50,6 +50,10 @@ public record SubTypeWithoutConstructor
 
     [StringLength(10)]
     public string? StringWithLength { get; set; }
+
+    [FromServices]
+    [Required]
+    public TestService ServiceProperty { get; set; } = null!;
 }
 
 public static class CustomValidators