Skip to content

Commit 314941f

Browse files
committed
Remove changes delegated to a separate PR.
1 parent 0b76124 commit 314941f

File tree

3 files changed

+4
-23
lines changed

3 files changed

+4
-23
lines changed

src/Components/Web.JS/src/Boot.Web.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,13 @@ function boot(options?: Partial<WebStartOptions>) : Promise<void> {
6565
},
6666
};
6767

68+
attachComponentDescriptorHandler(rootComponentManager);
69+
attachStreamingRenderingListener(options?.ssr, navigationEnhancementCallbacks);
70+
6871
if (!options?.ssr?.disableDomPreservation) {
6972
attachProgressivelyEnhancedNavigationListener(navigationEnhancementCallbacks);
7073
}
7174

72-
attachComponentDescriptorHandler(rootComponentManager);
73-
attachStreamingRenderingListener(options?.ssr, navigationEnhancementCallbacks);
74-
7575
enableFocusOnNavigate(jsEventRegistry);
7676

7777
// Wait until the initial page response completes before activating interactive components.

src/Components/Web.JS/src/Services/NavigationEnhancement.ts

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -37,18 +37,11 @@ const acceptHeader = 'text/html; blazor-enhanced-nav=on';
3737
let currentEnhancedNavigationAbortController: AbortController | null;
3838
let navigationEnhancementCallbacks: NavigationEnhancementCallbacks;
3939
let performingEnhancedPageLoad: boolean;
40-
let navigationEnhancementCallbacksPromise: Promise<NavigationEnhancementCallbacks> | null = null;
41-
let navigationEnhancementCallbacksResolver: ((callbacks: NavigationEnhancementCallbacks) => void) | null = null;
4240

4341
// This gets initialized to the current URL when we load.
4442
// After that, it gets updated every time we successfully complete a navigation.
4543
let currentContentUrl = location.href;
4644

47-
// Initialize the promise for waiting for navigation enhancement callbacks
48-
navigationEnhancementCallbacksPromise = new Promise<NavigationEnhancementCallbacks>((resolve) => {
49-
navigationEnhancementCallbacksResolver = resolve;
50-
});
51-
5245
export interface NavigationEnhancementCallbacks {
5346
enhancedNavigationStarted: () => void;
5447
documentUpdated: () => void;
@@ -65,14 +58,6 @@ export function hasNeverStartedAnyEnhancedPageLoad() {
6558

6659
export function attachProgressivelyEnhancedNavigationListener(callbacks: NavigationEnhancementCallbacks) {
6760
navigationEnhancementCallbacks = callbacks;
68-
69-
// Resolve the promise so any waiting performEnhancedPageLoad calls can proceed
70-
if (navigationEnhancementCallbacksResolver) {
71-
navigationEnhancementCallbacksResolver(callbacks);
72-
navigationEnhancementCallbacksResolver = null;
73-
navigationEnhancementCallbacksPromise = null;
74-
}
75-
7661
document.addEventListener('click', onDocumentClick);
7762
document.addEventListener('submit', onDocumentSubmit);
7863
window.addEventListener('popstate', onPopState);
@@ -210,10 +195,6 @@ function onDocumentSubmit(event: SubmitEvent) {
210195
export async function performEnhancedPageLoad(internalDestinationHref: string, interceptedLink: boolean, fetchOptions?: RequestInit, treatAsRedirectionFromMethod?: 'get' | 'post', changeUrl: boolean = true) {
211196
performingEnhancedPageLoad = true;
212197

213-
if (!navigationEnhancementCallbacks && navigationEnhancementCallbacksPromise) {
214-
navigationEnhancementCallbacks = await navigationEnhancementCallbacksPromise;
215-
}
216-
217198
// First, stop any preceding enhanced page load
218199
currentEnhancedNavigationAbortController?.abort();
219200

src/Components/test/E2ETest/ServerRenderingTests/NoInteractivityTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ private void AssertNotFoundRendered_ResponseNotStarted(bool hasCustomNotFoundPag
227227
public void NotFoundSetOnFormSubmit_ResponseNotStarted_SSR(bool hasReExecutionMiddleware, bool hasCustomNotFoundPageSet)
228228
{
229229
string reexecution = hasReExecutionMiddleware ? "/reexecution" : "";
230-
string testUrl = $"{ServerPathBase}{reexecution}/post-not-found-ssr?useCustomNotFoundPage={hasCustomNotFoundPageSet}";
230+
string testUrl = $"{ServerPathBase}{reexecution}/post-not-found-ssr-streaming?useCustomNotFoundPage={hasCustomNotFoundPageSet}";
231231
Navigate(testUrl);
232232
Browser.FindElement(By.Id("not-found-form")).FindElement(By.TagName("button")).Click();
233233

0 commit comments

Comments
 (0)