Skip to content

Commit 3290913

Browse files
akoeplingercaptainsafia
authored andcommitted
Remove setting IsStableBuild in Directory.Build.props (#59310)
It is a no-op. Arcade already sets this in https://github.com/dotnet/arcade/blob/7fff497cdf80039a4f2996699e5561e50812d948/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L55-L57 and as we discovered in #59309 the DotNetFinalVersionKind property isn't even set at that point.
1 parent d8e84af commit 3290913

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

Directory.Build.props

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,6 @@
4747
'$(IsBenchmarkProject)' == 'true' OR
4848
'$(IsPublishedAppTestProject)' == 'true' OR
4949
$(IsUnitTestProject) ">false</IsShipping>
50-
51-
<!--
52-
Following logic mimics core-setup approach as well as
53-
https://github.com/dotnet/arcade/blob/694d59f090b743f894779d04a7ffe11cbaf352e7/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L30-L31
54-
$(DotNetFinalVersionKind) is set globally when doing final aka stable builds. Arcade infrastructure should pick
55-
up $(IsStableBuild) automatically; property is also used to control prerelease branding.
56-
-->
57-
<IsStableBuild>false</IsStableBuild>
58-
<IsStableBuild Condition=" '$(DotNetFinalVersionKind)' == 'release' ">true</IsStableBuild>
5950
</PropertyGroup>
6051

6152
<!-- Disable logging of some task parameters or metadata to reduce binlog size.

0 commit comments

Comments
 (0)