Skip to content

Commit 36d1e8d

Browse files
jkoritzinskycaptainsafia
authored andcommitted
Do a few tricks to shorten the intermediate output paths for the runtime packs (#59479)
* Do a few tricks to shorten the intermediate output paths for the runtime packs The Wix tooling can't handle long paths, which is blocking VMR integration. This change gets our paths to be short enough that even a long-named analyzer's resource DLL won't go past MAX_PATH in a VMR build. * Set OutDirName for the ref pack as well. * Adjust path to RuntimeList
1 parent a6b73f9 commit 36d1e8d

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<Project>
2+
<PropertyGroup>
3+
<OutDirName Condition="'$(MSBuildProjectName)' == 'Microsoft.AspNetCore.App.Ref'">aspnetcore-ref</OutDirName>
4+
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
5+
</PropertyGroup>
6+
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.props))\Directory.Build.props" />
7+
</Project>
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<Project>
2+
<PropertyGroup>
3+
<OutDirName Condition="'$(MSBuildProjectName)' == 'Microsoft.AspNetCore.App.Runtime'">aspnetcore-sfx</OutDirName>
4+
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
5+
</PropertyGroup>
6+
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.props))\Directory.Build.props" />
7+
</Project>

src/Framework/test/Microsoft.AspNetCore.App.UnitTests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
This depends on internal implementation details of the SharedFramework SDK and should be changed to use a supported mechanism
1717
to discover the runtime list.
1818
-->
19-
<None Include="$(ArtifactsObjDir)Microsoft.AspNetCore.App.Runtime\$(Configuration)\$(DefaultNetCoreTargetFramework)\$(TargetRuntimeIdentifier)\RuntimeList.xml"
19+
<None Include="$(ArtifactsObjDir)aspnetcore-sfx\$(Configuration)\$(TargetRuntimeIdentifier)\RuntimeList.xml"
2020
CopyToOutputDirectory="PreserveNewest" />
2121

2222
<!-- Ignore aspnetcorev2_inprocess because tests expect only managed assemblies in this item group. -->

0 commit comments

Comments
 (0)