Skip to content

Commit 37d01d2

Browse files
committed
Fix incorrect tests
1 parent b74bff1 commit 37d01d2

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

src/OpenApi/test/Microsoft.AspNetCore.OpenApi.Tests/Services/OpenApiDocumentProviderTests.cs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public async Task GenerateAsync_ShouldRetrieveOptionsInACaseInsensitiveManner()
3636
{
3737
// Arrange
3838
var documentName = "CaseSensitive";
39-
var serviceProvider = CreateServiceProvider(["casesensitive"]);
39+
var serviceProvider = CreateServiceProvider(["casesensitive"], OpenApiSpecVersion.OpenApi2_0);
4040
var documentProvider = new OpenApiDocumentProvider(serviceProvider);
4141
var stringWriter = new StringWriter();
4242

@@ -78,11 +78,7 @@ public async Task GenerateAsync_ShouldRetrieveOpenApiDocumentServiceWithACaseIns
7878
// It's registered as "casesensitive" but we're passing in "CaseSensitive", which doesn't exist.
7979
// Therefore, if the test doesn't throw, we know it has passed correctly.
8080
// We still do a small check to validate the document, just in case. But the main test is that it doesn't throw.
81-
ValidateOpenApiDocument(stringWriter, document =>
82-
{
83-
Assert.Equal($"{nameof(OpenApiDocumentProviderTests)} | {documentName}", document.Info.Title);
84-
Assert.Equal("1.0.0", document.Info.Version);
85-
});
81+
ValidateOpenApiDocument(stringWriter, _ => { });
8682
}
8783

8884
[Fact]
@@ -111,7 +107,7 @@ private static void ValidateOpenApiDocument(StringWriter stringWriter, Action<Op
111107
action(document);
112108
}
113109

114-
private static IServiceProvider CreateServiceProvider(string[] documentNames)
110+
private static IServiceProvider CreateServiceProvider(string[] documentNames, OpenApiSpecVersion openApiSpecVersion = OpenApiSpecVersion.OpenApi3_0)
115111
{
116112
var hostEnvironment = new HostEnvironment() { ApplicationName = nameof(OpenApiDocumentProviderTests) };
117113
var serviceProviderIsService = new ServiceProviderIsService();
@@ -121,7 +117,7 @@ private static IServiceProvider CreateServiceProvider(string[] documentNames)
121117
.AddSingleton(CreateApiDescriptionGroupCollectionProvider());
122118
foreach (var documentName in documentNames)
123119
{
124-
serviceCollection.AddOpenApi(documentName);
120+
serviceCollection.AddOpenApi(documentName, x => x.OpenApiVersion = openApiSpecVersion);
125121
}
126122
var serviceProvider = serviceCollection.BuildServiceProvider(validateScopes: true);
127123
return serviceProvider;

0 commit comments

Comments
 (0)