Feedback

Author: captainsafia

src/Http/Http.Extensions/src/RequestDelegateFactory.cs

@@ -2001,14 +2001,7 @@ private static Expression CreateDefaultValueExpression(object? defaultValue, Typ
         }
         else if (!targetType.IsAssignableFrom(defaultValue.GetType()))
         {
-            try
-            {
-                converted = Convert.ChangeType(defaultValue, targetType, CultureInfo.InvariantCulture);
-            }
-            catch
-            {
-                converted = targetType.IsValueType ? Activator.CreateInstance(targetType) : null;
-            }
+            converted = Convert.ChangeType(defaultValue, targetType, CultureInfo.InvariantCulture);
         }
 
         var constant = Expression.Constant(converted, targetType);

src/Http/Http.Extensions/test/RequestDelegateGenerator/RequestDelegateCreationTests.SpecialTypes.cs

@@ -197,6 +197,7 @@ public static object[][] DefaultValues
                 ["decimal", "decimal.Zero", decimal.Zero, true],
                 ["long", "long.MaxValue", long.MaxValue, true],
                 ["long", "long.MinValue", long.MinValue, true],
+                ["long", "(long)3.14", (long)3, true],
                 ["short", "short.MaxValue", short.MaxValue, true],
                 ["short", "short.MinValue", short.MinValue, true],
                 ["ulong", "ulong.MaxValue", ulong.MaxValue, true],
@@ -206,6 +207,7 @@ public static object[][] DefaultValues
                 ["TodoStatus", "TodoStatus.Done", TodoStatus.Done, true],
                 ["TodoStatus", "TodoStatus.InProgress", TodoStatus.InProgress, true],
                 ["TodoStatus", "TodoStatus.NotDone", TodoStatus.NotDone, true],
+                ["TodoStatus", "(TodoStatus)1", TodoStatus.Done, true],
                 ["MyEnum", "MyEnum.ValueA", MyEnum.ValueA, true],
                 ["MyEnum", "MyEnum.ValueB", MyEnum.ValueB, true],
                 // Test nullable enum values

src/Shared/RoslynUtils/SymbolExtensions.cs

@@ -250,9 +250,9 @@ private static bool IsEnumType(ITypeSymbol typeSymbol, out ITypeSymbol enumType)
         return typeSymbol.TypeKind == TypeKind.Enum;
     }
 
-    private static bool IsNullableEnumType(ITypeSymbol typeSymbol, out ITypeSymbol underlyingEnumType)
+    private static bool IsNullableEnumType(ITypeSymbol typeSymbol, [NotNullWhen(true)] out ITypeSymbol? underlyingEnumType)
     {
-        underlyingEnumType = null!;
+        underlyingEnumType = null;
         if (typeSymbol.OriginalDefinition?.SpecialType == SpecialType.System_Nullable_T &&
             typeSymbol is INamedTypeSymbol namedType)
         {