Skip to content

Commit 3cef64e

Browse files
Merging main into darc-main-6a500fc6-cc1d-4c69-9b8a-a7d84549614e
2 parents d85ceda + 7641b9f commit 3cef64e

File tree

15 files changed

+110
-20
lines changed

15 files changed

+110
-20
lines changed

.github/policies/resourceManagement.yml

Lines changed: 71 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,45 @@ configuration:
168168
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an `/azp run` comment here (requires commit rights), or by simply closing and reopening.
169169
- addLabel:
170170
label: pending-ci-rerun
171+
- description: '[Idle Issue Management] Tag aspnet-build on dependency PRs (non-weekend)'
172+
frequencies:
173+
- weekday:
174+
day: Tuesday
175+
time: 0:0
176+
- weekday:
177+
day: Wednesday
178+
time: 0:0
179+
- weekday:
180+
day: Thursday
181+
time: 0:0
182+
- weekday:
183+
day: Friday
184+
time: 0:0
185+
filters:
186+
- isPullRequest
187+
- isOpen
188+
- hasLabel:
189+
label: 'build-ops'
190+
- noActivitySince:
191+
days: 1
192+
actions:
193+
- addReply:
194+
reply: This dependency PR has had no activity for a full business day - @dotnet/aspnet-build please take a look if you are on build-ops.
195+
- description: '[Idle Issue Management] Tag aspnet-build on dependency PRs (weekend)'
196+
frequencies:
197+
- weekday:
198+
day: Monday
199+
time: 0:0
200+
filters:
201+
- isPullRequest
202+
- isOpen
203+
- hasLabel:
204+
label: 'build-ops'
205+
- noActivitySince:
206+
days: 3
207+
actions:
208+
- addReply:
209+
reply: This dependency PR has had no activity for a full business day - @dotnet/aspnet-build please take a look if you are on build-ops.
171210
eventResponderTasks:
172211
- if:
173212
- payloadType: Issue_Comment
@@ -247,6 +286,26 @@ configuration:
247286
- approvePullRequest:
248287
comment: Auto-approving dependency update.
249288
description: '[Infrastructure PRs] Add area-infrastructure label to dependency update Pull Requests'
289+
- if:
290+
- payloadType: Pull_Request
291+
- isAction:
292+
action: Opened
293+
- isActivitySender:
294+
user: dotnet-maestro[bot]
295+
issueAuthor: False
296+
- targetsBranch:
297+
branch: main
298+
- or:
299+
- titleContains:
300+
pattern: Update dependencies
301+
isRegex: False
302+
- titleContains:
303+
pattern: Source code updates
304+
isRegex: False
305+
then:
306+
- addLabel:
307+
label: 'build-ops'
308+
description: '[Infrastructure PRs] Add build-ops label to dependency update Pull Requests against main'
250309
- if:
251310
- payloadType: Pull_Request
252311
- isAction:
@@ -264,6 +323,8 @@ configuration:
264323
label: area-infrastructure
265324
- addLabel:
266325
label: 'Type: Merge Forward :fast_forward:'
326+
- addLabel:
327+
label: 'build-ops'
267328
- approvePullRequest:
268329
comment: Auto-approving branch merge.
269330
description: '[Infrastructure PRs] Add area-infrastructure label to auto-merge Pull Requests'
@@ -380,18 +441,18 @@ configuration:
380441
branch: main
381442
then:
382443
- addMilestone:
383-
milestone: 10.0-preview6
444+
milestone: 10.0-preview7
384445
description: '[Milestone Assignments] Assign Milestone to PRs merged to the `main` branch'
385446
- if:
386447
- payloadType: Pull_Request
387448
- isAction:
388449
action: Closed
389450
- targetsBranch:
390-
branch: release/10.0-preview5
451+
branch: release/10.0-preview6
391452
then:
392453
- removeMilestone
393454
- addMilestone:
394-
milestone: 10.0-preview5
455+
milestone: 10.0-preview6
395456
description: '[Milestone Assignments] Assign Milestone to PRs merged to release/10.0-preview1 branch'
396457
- if:
397458
- payloadType: Issues
@@ -495,16 +556,16 @@ configuration:
495556
- isAction:
496557
action: Opened
497558
- targetsBranch:
498-
branch: release/2.1
559+
branch: release/2.3
499560
then:
500561
- addMilestone:
501-
milestone: 2.1.x
562+
milestone: 2.3.x
502563
- addReply:
503564
reply: >-
504565
Hi @${issueAuthor}. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the [servicing process](https://aka.ms/aspnet/servicing) document.
505566
506567
Otherwise, please add `tell-mode` label.
507-
description: Add release/2.1 targeting PRs to the servicing project
568+
description: Add release/2.3 targeting PRs to the servicing project
508569
- if:
509570
- payloadType: Pull_Request
510571
- labelAdded:
@@ -651,6 +712,8 @@ configuration:
651712
label: area-infrastructure
652713
- addLabel:
653714
label: 'Type: Dependency Update :arrow_up_small:'
715+
- addLabel:
716+
label: 'build-ops'
654717
- approvePullRequest:
655718
comment: Auto-approving SDK update.
656719
- enableAutoMerge:
@@ -670,6 +733,8 @@ configuration:
670733
label: area-infrastructure
671734
- addLabel:
672735
label: 'Type: Dependency Update :arrow_up_small:'
736+
- addLabel:
737+
label: 'build-ops'
673738
- approvePullRequest:
674739
comment: Auto-approving dependabot update.
675740
- enableAutoMerge:

.github/workflows/backport.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ permissions:
1414

1515
jobs:
1616
backport:
17-
uses: dotnet/arcade/.github/workflows/backport-base.yml@d237be4630776450573bc588eb995bb8f9ebc04f # 2025-01-13
17+
uses: dotnet/arcade/.github/workflows/backport-base.yml@7a09c1144283309440a7966c664199944198c920 # 2025-01-13
1818
with:
1919
pr_description_template: |
2020
Backport of #%source_pr_number% to %target_branch%

.github/workflows/inter-branch-merge-flow.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ permissions:
1010

1111
jobs:
1212
Merge:
13-
uses: dotnet/arcade/.github/workflows/backport-base.yml@d237be4630776450573bc588eb995bb8f9ebc04f # 2024-06-24
13+
uses: dotnet/arcade/.github/workflows/backport-base.yml@7a09c1144283309440a7966c664199944198c920 # 2024-06-24

eng/Versions.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<AspNetCoreMajorVersion>10</AspNetCoreMajorVersion>
1010
<AspNetCoreMinorVersion>0</AspNetCoreMinorVersion>
1111
<AspNetCorePatchVersion>0</AspNetCorePatchVersion>
12-
<PreReleaseVersionIteration>6</PreReleaseVersionIteration>
12+
<PreReleaseVersionIteration>7</PreReleaseVersionIteration>
1313
<ValidateBaseline>true</ValidateBaseline>
1414
<IdentityModelVersion Condition="'$(IsIdentityModelTestJob)' != 'true'">8.0.1</IdentityModelVersion>
1515
<IdentityModelVersion Condition="'$(IsIdentityModelTestJob)' == 'true'">*-*</IdentityModelVersion>

src/Components/Endpoints/src/DependencyInjection/HttpNavigationManager.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ namespace Microsoft.AspNetCore.Components.Endpoints;
88

99
internal sealed class HttpNavigationManager : NavigationManager, IHostEnvironmentNavigationManager
1010
{
11-
private const string _enableThrowNavigationException = "Microsoft.AspNetCore.Components.Endpoints.NavigationManager.EnableThrowNavigationException";
11+
private const string _disableThrowNavigationException = "Microsoft.AspNetCore.Components.Endpoints.NavigationManager.DisableThrowNavigationException";
1212

13-
[FeatureSwitchDefinition(_enableThrowNavigationException)]
13+
[FeatureSwitchDefinition(_disableThrowNavigationException)]
1414
private static bool _throwNavigationException =>
15-
AppContext.TryGetSwitch(_enableThrowNavigationException, out var switchValue) && switchValue;
15+
!AppContext.TryGetSwitch(_disableThrowNavigationException, out var switchValue) || !switchValue;
1616

1717
private Func<string, Task>? _onNavigateTo;
1818

src/Components/Endpoints/test/EndpointHtmlRendererTest.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -849,9 +849,9 @@ public async Task Rendering_ComponentWithJsInteropThrows()
849849
[Theory]
850850
[InlineData(true)]
851851
[InlineData(false)]
852-
public async Task UriHelperRedirect_ThrowsInvalidOperationException_WhenResponseHasAlreadyStarted(bool expectException)
852+
public async Task UriHelperRedirect_ThrowsInvalidOperationException_WhenResponseHasAlreadyStarted(bool allowException)
853853
{
854-
AppContext.SetSwitch("Microsoft.AspNetCore.Components.Endpoints.NavigationManager.EnableThrowNavigationException", isEnabled: expectException);
854+
AppContext.SetSwitch("Microsoft.AspNetCore.Components.Endpoints.NavigationManager.DisableThrowNavigationException", isEnabled: !allowException);
855855
// Arrange
856856
var ctx = new DefaultHttpContext();
857857
ctx.Request.Scheme = "http";
@@ -867,7 +867,7 @@ public async Task UriHelperRedirect_ThrowsInvalidOperationException_WhenResponse
867867
string redirectUri = "http://localhost/redirect";
868868

869869
// Act
870-
if (expectException)
870+
if (allowException)
871871
{
872872
var exception = await Assert.ThrowsAsync<InvalidOperationException>(async () => await renderer.PrerenderComponentAsync(
873873
httpContext,

src/Components/Server/src/Circuits/RemoteNavigationManager.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ internal sealed partial class RemoteNavigationManager : NavigationManager, IHost
1717
private readonly ILogger<RemoteNavigationManager> _logger;
1818
private IJSRuntime _jsRuntime;
1919
private bool? _navigationLockStateBeforeJsRuntimeAttached;
20-
private const string _enableThrowNavigationException = "Microsoft.AspNetCore.Components.Endpoints.NavigationManager.EnableThrowNavigationException";
20+
private const string _disableThrowNavigationException = "Microsoft.AspNetCore.Components.Endpoints.NavigationManager.DisableThrowNavigationException";
2121

22-
[FeatureSwitchDefinition(_enableThrowNavigationException)]
22+
[FeatureSwitchDefinition(_disableThrowNavigationException)]
2323
private static bool _throwNavigationException =>
24-
AppContext.TryGetSwitch(_enableThrowNavigationException, out var switchValue) && switchValue;
24+
!AppContext.TryGetSwitch(_disableThrowNavigationException, out var switchValue) || !switchValue;
2525
private Func<string, Task>? _onNavigateTo;
2626

2727
public event EventHandler<Exception>? UnhandledException;

src/Components/test/E2ETest/ServerRenderingTests/InteractivityTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1405,7 +1405,7 @@ public void CanPersistMultiplePrerenderedStateDeclaratively_Auto_PersistsOnWebAs
14051405
[InlineData(false)]
14061406
public void NavigatesWithInteractivityByRequestRedirection(bool controlFlowByException)
14071407
{
1408-
AppContext.SetSwitch("Microsoft.AspNetCore.Components.Endpoints.NavigationManager.EnableThrowNavigationException", isEnabled: controlFlowByException);
1408+
AppContext.SetSwitch("Microsoft.AspNetCore.Components.Endpoints.NavigationManager.DisableThrowNavigationException", isEnabled: !controlFlowByException);
14091409
Navigate($"{ServerPathBase}/routing/ssr-navigate-to");
14101410
Browser.Equal("Click submit to navigate to home", () => Browser.Exists(By.Id("test-info")).Text);
14111411
Browser.Click(By.Id("redirectButton"));

src/Components/test/E2ETest/ServerRenderingTests/NoInteractivityTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public void CanUseServerAuthenticationStateByDefault()
7272
[InlineData(false, true)]
7373
public void NavigatesWithoutInteractivityByRequestRedirection(bool controlFlowByException, bool isStreaming)
7474
{
75-
AppContext.SetSwitch("Microsoft.AspNetCore.Components.Endpoints.NavigationManager.EnableThrowNavigationException", isEnabled: controlFlowByException);
75+
AppContext.SetSwitch("Microsoft.AspNetCore.Components.Endpoints.NavigationManager.DisableThrowNavigationException", isEnabled: !controlFlowByException);
7676
string streaming = isStreaming ? $"streaming-" : "";
7777
Navigate($"{ServerPathBase}/routing/ssr-{streaming}navigate-to");
7878
Browser.Equal("Click submit to navigate to home", () => Browser.Exists(By.Id("test-info")).Text);

src/ProjectTemplates/Web.ProjectTemplates/BlazorWeb-CSharp.Client.csproj.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<StaticWebAssetProjectMode>Default</StaticWebAssetProjectMode>
99
<RootNamespace Condition="'$(name)' != '$(name{-VALUE-FORMS-}safe_namespace)'">BlazorWeb-CSharp.Client</RootNamespace>
1010
<AssemblyName Condition="'$(name)' != '$(name{-VALUE-FORMS-}safe_namespace)'">`$(AssemblyName.Replace(' ', '_'))</AssemblyName>
11+
<BlazorDisableThrowNavigationException>true</BlazorDisableThrowNavigationException>
1112
</PropertyGroup>
1213

1314
<ItemGroup>

0 commit comments

Comments
 (0)