Skip to content

Commit 3d20fa9

Browse files
committed
Remove comments, test on CI
1 parent ab0d029 commit 3d20fa9

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/Components/test/E2ETest/ServerRenderingTests/NoInteractivityTest.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -160,9 +160,9 @@ public void NotFoundSetOnInitialization_ResponseNotStarted_SSR(bool hasReExecuti
160160
// the headers contain enhanced-nav, redirection is not needed and the original url will be preserved.
161161

162162
[Theory]
163-
[InlineData(true, true)] // manual testing works, why Selenium does not?
163+
[InlineData(true, true)]
164164
[InlineData(true, false)]
165-
[InlineData(false, true)] // manual testing works, why Selenium does not?
165+
[InlineData(false, true)]
166166
[InlineData(false, false)]
167167
// enhanced navigation is switched off for browser navigation
168168
public void NotFoundSetOnInitialization_ResponseStarted_BrowserNavigation_SSR(bool hasReExecutionMiddleware, bool hasCustomNotFoundPageSet)
@@ -194,15 +194,15 @@ private void AssertNotFoundRendered_ResponseStarted_Or_POST(bool hasReExecutionM
194194
}
195195
else
196196
{
197-
// this throws an exception logged the server
197+
// this throws an exception logged on the server
198198
AssertNotFoundContentNotRendered();
199199
}
200200
}
201201

202202
[Theory]
203-
//[InlineData(true, true)] // ActiveIssue("NotFoundPageRoute is not set in Router")
203+
[InlineData(true, true)]
204204
[InlineData(true, false)]
205-
//[InlineData(false, true)] // ActiveIssue("NotFoundPageRoute is not set in Router")
205+
[InlineData(false, true)]
206206
[InlineData(false, false)]
207207
// enhanced navigation is switched on for link navigation
208208
public void NotFoundSetOnInitialization_ResponseStarted_LinkNavigation_SSR(bool hasReExecutionMiddleware, bool hasCustomNotFoundPageSet)
@@ -225,9 +225,9 @@ private string NavigateByLinkToPageTestingNotFound(string action, bool hasReExec
225225
}
226226

227227
[Theory]
228-
//[InlineData(true, true)] // ActiveIssue("NotFoundPageRoute is not set in Router")
228+
[InlineData(true, true)]
229229
[InlineData(true, false)]
230-
//[InlineData(false, true)] // ActiveIssue("NotFoundPageRoute is not set in Router")
230+
[InlineData(false, true)]
231231
[InlineData(false, false)]
232232
// NotFound triggered by POST cannot get rendered in the same batch and we rely on the client to render it
233233
// However, because it is triggered by form POST, it won't have enhanced-nav headers
@@ -251,9 +251,9 @@ public void NotFoundSetOnFormSubmit_ResponseNotStarted_SSR(bool hasReExecutionMi
251251
}
252252

253253
[Theory]
254-
//[InlineData(true, true)] // ActiveIssue("NotFoundPageRoute is not set in Router")
254+
[InlineData(true, true)]
255255
[InlineData(true, false)]
256-
//[InlineData(false, true)] // ActiveIssue("NotFoundPageRoute is not set in Router")
256+
[InlineData(false, true)]
257257
[InlineData(false, false)]
258258
public void NotFoundSetOnFormSubmit_ResponseStarted_SSR(bool hasReExecutionMiddleware, bool hasCustomNotFoundPageSet)
259259
{

0 commit comments

Comments
 (0)