Skip to content

Commit 3e22a24

Browse files
committed
Use arcade download task and also check dotnetcli
1 parent 2ebaa4c commit 3e22a24

File tree

4 files changed

+15
-162
lines changed

4 files changed

+15
-162
lines changed

eng/Versions.props

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -297,10 +297,4 @@
297297
<DotnetServeVersion>1.10.93</DotnetServeVersion>
298298
<MicrosoftPlaywrightCLIVersion>1.2.3</MicrosoftPlaywrightCLIVersion>
299299
</PropertyGroup>
300-
<!-- Restore feeds -->
301-
<PropertyGroup Label="Restore feeds">
302-
<!-- In an orchestrated build, this may be overridden to other Azure feeds. -->
303-
<DotNetAssetRootUrl Condition="'$(DotNetAssetRootUrl)'==''">https://dotnetbuilds.azureedge.net/public/</DotNetAssetRootUrl>
304-
<DotNetPrivateAssetRootUrl Condition="'$(DotNetPrivateAssetRootUrl)'==''">https://dotnetbuilds.azureedge.net/internal/</DotNetPrivateAssetRootUrl>
305-
</PropertyGroup>
306300
</Project>

eng/tools/RepoTasks/DownloadFile.cs

Lines changed: 0 additions & 148 deletions
This file was deleted.

eng/tools/RepoTasks/RepoTasks.tasks

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,4 @@
1010
<UsingTask TaskName="RepoTasks.GenerateSharedFrameworkDepsFile" AssemblyFile="$(_RepoTaskAssembly)" />
1111
<UsingTask TaskName="RepoTasks.CreateFrameworkListFile" AssemblyFile="$(_RepoTaskAssembly)" />
1212
<UsingTask TaskName="RepoTasks.RemoveSharedFrameworkDependencies" AssemblyFile="$(_RepoTaskAssembly)" />
13-
<UsingTask TaskName="RepoTasks.DownloadFile" AssemblyFile="$(_RepoTaskAssembly)" />
1413
</Project>

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ This package is an internal implementation of the .NET Core SDK and is not meant
3232

3333
<!-- Use the BrowserDebugHost as a sentinel for the nonshipping version for .NETCoreApp -->
3434
<DotNetRuntimeArchiveFileName>dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-$(TargetRuntimeIdentifier)$(ArchiveExtension)</DotNetRuntimeArchiveFileName>
35-
<DotNetRuntimeDownloadUrl>$(DotNetAssetRootUrl)Runtime/$(MicrosoftNETCoreBrowserDebugHostTransportVersion)/$(DotNetRuntimeArchiveFileName)</DotNetRuntimeDownloadUrl>
36-
<DotNetRuntimePrivateDownloadUrl>$(DotNetPrivateAssetRootUrl)Runtime/$(MicrosoftNETCoreBrowserDebugHostTransportVersion)/$(DotNetRuntimeArchiveFileName)</DotNetRuntimePrivateDownloadUrl>
35+
<DotNetRuntimeDownloadPath>Runtime/$(MicrosoftNETCoreBrowserDebugHostTransportVersion)/$(DotNetRuntimeArchiveFileName)</DotNetRuntimeDownloadPath>
3736
<DotNetRuntimeArchive>$(BaseIntermediateOutputPath)$(DotNetRuntimeArchiveFileName)</DotNetRuntimeArchive>
3837

3938
<!-- Setting this suppresses getting documentation .xml files in the shared runtime output. -->
@@ -502,11 +501,20 @@ This package is an internal implementation of the .NET Core SDK and is not meant
502501
#########################################
503502
-->
504503
<Target Name="_DownloadAndExtractDotNetRuntime" Condition="'$(DotNetBuildFromSource)' != 'true'">
505-
<DownloadFile Condition=" ! Exists('$(DotNetRuntimeArchive)')"
506-
Uri="$(DotNetRuntimeDownloadUrl)"
507-
PrivateUri="$(DotNetRuntimePrivateDownloadUrl)"
508-
PrivateUriSuffix="$(DotNetAssetRootAccessTokenSuffix)"
509-
DestinationPath="$(DotNetRuntimeArchive)" />
504+
<!-- Try various places to find the runtime. It's either released (use official version),
505+
public but un-released (use dotnetbuilds/public), or internal and unreleased (use dotnetbuilds/internal) -->
506+
<ItemGroup>
507+
<UrisToDownload Include="https://dotnetcli.azureedge.net/dotnet/$(DotNetRuntimeDownloadPath)" />
508+
<UrisToDownload Include="https://dotnetbuilds.azureedge.net/public/$(DotNetRuntimeDownloadPath)" />
509+
<UrisToDownload Include="https://dotnetbuilds.azureedge.net/internal/$(DotNetRuntimeDownloadPath)">
510+
<token>$(DotnetRuntimeSourceFeedKey)</token>
511+
</UrisToDownload>
512+
</ItemGroup>
513+
514+
<DownloadFile Condition=" !Exists('$(DotNetRuntimeArchive)') "
515+
Uris="@(UrisToDownload)"
516+
DestinationPath="%(DotNetRuntimeArchive)" />
517+
510518
<RemoveDir Directories="$(RedistSharedFrameworkLayoutRoot)" />
511519
<MakeDir Directories="$(RedistSharedFrameworkLayoutRoot)" />
512520

0 commit comments

Comments
 (0)