Skip to content

Commit 3e47dcc

Browse files
committed
Skip manually updated versions in CodeCheck.ps1
1 parent 1fb6d09 commit 3e47dcc

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

eng/Version.Details.xml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -346,19 +346,19 @@
346346
</Dependency>
347347
<!-- Dependencies required for source build to lift to the previously-source-built version. -->
348348
<!-- These versions are manually updated -->
349-
<Dependency Name="Microsoft.CodeAnalysis.Common" Version="4.13.0-3.24613.7">
349+
<Dependency Name="Microsoft.CodeAnalysis.Common" Version="4.13.0-3.24613.7" Label="Manual">
350350
<Uri>https://github.com/dotnet/roslyn</Uri>
351-
<Sha>afdd413cee50c16318620252e4e64dc326e2d300</Sha>
351+
<Sha>06f095f368c0ea9d54c80e313279574da9d96ea3</Sha>
352352
</Dependency>
353-
<Dependency Name="Microsoft.CodeAnalysis.ExternalAccess.AspNetCore" Version="4.13.0-3.24613.7">
353+
<Dependency Name="Microsoft.CodeAnalysis.ExternalAccess.AspNetCore" Version="4.13.0-3.24613.7" Label="Manual">
354354
<Uri>https://github.com/dotnet/roslyn</Uri>
355355
<Sha>afdd413cee50c16318620252e4e64dc326e2d300</Sha>
356356
</Dependency>
357-
<Dependency Name="Microsoft.CodeAnalysis.CSharp" Version="4.13.0-3.24613.7">
357+
<Dependency Name="Microsoft.CodeAnalysis.CSharp" Version="4.13.0-3.24613.7" Label="Manual">
358358
<Uri>https://github.com/dotnet/roslyn</Uri>
359359
<Sha>afdd413cee50c16318620252e4e64dc326e2d300</Sha>
360360
</Dependency>
361-
<Dependency Name="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.13.0-3.24613.7">
361+
<Dependency Name="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.13.0-3.24613.7" Label="Manual">
362362
<Uri>https://github.com/dotnet/roslyn</Uri>
363363
<Sha>afdd413cee50c16318620252e4e64dc326e2d300</Sha>
364364
</Dependency>
@@ -432,31 +432,31 @@
432432
</Dependency>
433433
<!-- Dependencies required for source build to lift to the previously-source-built version. -->
434434
<!-- These versions are manually updated -->
435-
<Dependency Name="Microsoft.Build" Version="17.12.36">
435+
<Dependency Name="Microsoft.Build" Version="17.12.36" Label="Manual">
436436
<Uri>https://github.com/dotnet/msbuild</Uri>
437437
<Sha>d1cce8d7cc03c23a4f1bad8e9240714fd9d199a3</Sha>
438438
</Dependency>
439-
<Dependency Name="Microsoft.Build.Framework" Version="17.12.36">
439+
<Dependency Name="Microsoft.Build.Framework" Version="17.12.36" Label="Manual">
440440
<Uri>https://github.com/dotnet/msbuild</Uri>
441441
<Sha>d1cce8d7cc03c23a4f1bad8e9240714fd9d199a3</Sha>
442442
</Dependency>
443-
<Dependency Name="Microsoft.Build.Tasks.Core" Version="17.12.36">
443+
<Dependency Name="Microsoft.Build.Tasks.Core" Version="17.12.36" Label="Manual">
444444
<Uri>https://github.com/dotnet/msbuild</Uri>
445445
<Sha>d1cce8d7cc03c23a4f1bad8e9240714fd9d199a3</Sha>
446446
</Dependency>
447-
<Dependency Name="Microsoft.Build.Utilities.Core" Version="17.12.36">
447+
<Dependency Name="Microsoft.Build.Utilities.Core" Version="17.12.36" Label="Manual">
448448
<Uri>https://github.com/dotnet/msbuild</Uri>
449449
<Sha>d1cce8d7cc03c23a4f1bad8e9240714fd9d199a3</Sha>
450450
</Dependency>
451-
<Dependency Name="NuGet.Frameworks" Version="6.2.4">
451+
<Dependency Name="NuGet.Frameworks" Version="6.2.4" Label="Manual">
452452
<Uri>https://github.com/nuget/nuget.client</Uri>
453453
<Sha>8fef55f5a55a3b4f2c96cd1a9b5ddc51d4b927f8</Sha>
454454
</Dependency>
455-
<Dependency Name="NuGet.Packaging" Version="6.2.4">
455+
<Dependency Name="NuGet.Packaging" Version="6.2.4" Label="Manual">
456456
<Uri>https://github.com/nuget/nuget.client</Uri>
457457
<Sha>8fef55f5a55a3b4f2c96cd1a9b5ddc51d4b927f8</Sha>
458458
</Dependency>
459-
<Dependency Name="NuGet.Versioning" Version="6.2.4">
459+
<Dependency Name="NuGet.Versioning" Version="6.2.4" Label="Manual">
460460
<Uri>https://github.com/nuget/nuget.client</Uri>
461461
<Sha>8fef55f5a55a3b4f2c96cd1a9b5ddc51d4b927f8</Sha>
462462
</Dependency>

eng/scripts/CodeCheck.ps1

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,11 @@ try {
124124
foreach ($dep in $versionDetails.SelectNodes('//Dependency')) {
125125
Write-Verbose "Found $dep"
126126

127+
if ($dep.Label -eq 'Manual') {
128+
# skip dependencies that are manually updated
129+
continue
130+
}
131+
127132
$expectedVersion = $dep.Version
128133

129134
if ($dep.Name -in $globalJson.'msbuild-sdks'.PSObject.Properties.Name) {

0 commit comments

Comments
 (0)