Skip to content

Commit 4575228

Browse files
committed
fixes and feedback
1 parent 56536c1 commit 4575228

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@
7777
private void RenderPlaceholderRow(RenderTreeBuilder __builder, PlaceholderContext placeholderContext)
7878
{
7979
<tr aria-rowindex="@(placeholderContext.Index + 1)">
80-
@foreach (var col in _columns)
80+
@foreach (var col in _columns)
8181
{
8282
var hasCustomPlaceholder = col.PlaceholderTemplate is not null;
83-
var placeholderClass = hasCustomPlaceholder ? "" : "grid-cell-placeholder";
84-
<td class="@placeholderClass @ColumnClass(col)" @key="@col">@{ col.RenderPlaceholderContent(__builder, placeholderContext); }</td>
83+
var placeholderClass = hasCustomPlaceholder ? "grid-cell-placeholder" : "grid-cell-placeholder default";
84+
<td class="@($"{placeholderClass} {ColumnClass(col)}".Trim())" @key="@col">@{ col.RenderPlaceholderContent(__builder, placeholderContext); }</td>
8585
}
8686
</tr>
8787
}

src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/Themes/Default.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
border-radius: 0.3rem;
7676
}
7777

78-
.quickgrid[theme=default] > tbody > tr > td.grid-cell-placeholder:after {
78+
.quickgrid[theme=default] > tbody > tr > td.grid-cell-placeholder.default:after {
7979
content: '\2026';
8080
opacity: 0.75;
8181
}

src/Components/test/E2ETest/Tests/VirtualizationTest.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,15 +128,16 @@ public void PlaceholdersHaveCorrectValue_Async()
128128
Browser.ExecuteJavaScript("const container = document.getElementById('async-container'); container.scrollTop = container.scrollHeight * 0.5;");
129129

130130
Browser.Equal(0, () => GetItemCount());
131+
int placeholderCount = GetPlaceholderCount();
131132
Browser.True(() => GetPlaceholderCount() > 0);
132133

133134
Assert.Equal("\"\"", Browser.ExecuteJavaScript<string>(@"
134-
const p = document.querySelector('td.async-id');
135+
const p = document.querySelector('td.grid-cell-placeholder.default');
135136
return p ? getComputedStyle(p, '::after').content : null;"));
136137
Assert.Equal("none", Browser.ExecuteJavaScript<string>(@"
137-
const p = document.querySelector('td.async-second');
138+
const p = document.querySelector('td.grid-cell-placeholder:not(.default)');
138139
return p ? getComputedStyle(p, '::after').content : null;"));
139-
Browser.Equal("LOADING DATA", () => Browser.Exists(By.CssSelector(".async-second .async-placeholder")).Text);
140+
Browser.Equal("LOADING DATA", () => Browser.Exists(By.CssSelector(".grid-cell-placeholder .async-placeholder")).Text);
140141

141142
int GetItemCount() => Browser.FindElements(By.CssSelector("#async-container tbody td.async-id:not(.grid-cell-placeholder)")).Count;
142143
int GetPlaceholderCount() => Browser.FindElements(By.CssSelector("#async-container tbody .async-id.grid-cell-placeholder")).Count;

0 commit comments

Comments
 (0)