Skip to content

Commit 45b78fe

Browse files
Include all required shims when building in VMR
1 parent eb05c23 commit 45b78fe

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

eng/tools/GenerateFiles/Directory.Build.targets.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464

6565
<ItemGroup>
6666
<!-- Use the same NETCore shared framework as repo built against except when building product code in servicing. -->
67-
<KnownFrameworkReference Update="Microsoft.NETCore.App">
67+
<KnownFrameworkReference Update="Microsoft.NETCore.App" Condition=" '$(PackAsToolShimRuntimeIdentifiers)' == '' ">
6868
<LatestRuntimeFrameworkVersion
6969
Condition=" '%(TargetFramework)' == '${DefaultNetCoreTargetFramework}' ">${MicrosoftNETCoreAppRuntimeVersion}</LatestRuntimeFrameworkVersion>
7070
<TargetingPackVersion
@@ -83,7 +83,7 @@
8383
<RuntimePackRuntimeIdentifiers Condition="'$(DotNetBuild)' == 'true'">%(RuntimePackRuntimeIdentifiers);$(TargetRuntimeIdentifier)</RuntimePackRuntimeIdentifiers>
8484
</KnownFrameworkReference>
8585

86-
<KnownAppHostPack Update="Microsoft.NETCore.App">
86+
<KnownAppHostPack Update="Microsoft.NETCore.App" Condition=" '$(PackAsToolShimRuntimeIdentifiers)' == '' ">
8787
<AppHostPackVersion
8888
Condition=" '%(TargetFramework)' == '${DefaultNetCoreTargetFramework}' ">${MicrosoftNETCoreAppRuntimeVersion}</AppHostPackVersion>
8989
<AppHostRuntimeIdentifiers Condition=" '$(DotNetBuildSourceOnly)' == 'true' ">$(TargetRuntimeIdentifier)</AppHostRuntimeIdentifiers>

src/Tools/Directory.Build.targets

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
<Project>
22
<PropertyGroup Condition=" '$(PackAsTool)' == 'true' ">
33
<!-- Microsoft tool packages are required to target both x64 and x86. -->
4-
<!-- In VMR builds we only use the current RID. -->
5-
<PackAsToolShimRuntimeIdentifiers Condition=" '$(IsShippingPackage)' == 'true' AND '$(DotNetBuild)' != 'true' ">win-x64;win-x86</PackAsToolShimRuntimeIdentifiers>
6-
<PackAsToolShimRuntimeIdentifiers Condition=" '$(IsShippingPackage)' == 'true' AND '$(DotNetBuild)' == 'true' AND '$(TargetOsName)' == 'win' ">$(TargetRid)</PackAsToolShimRuntimeIdentifiers>
4+
<PackAsToolShimRuntimeIdentifiers Condition=" '$(IsShippingPackage)' == 'true' AND ('$(DotNetBuild)' != 'true' OR '$(TargetOsName)' == 'win')">win-x64;win-x86</PackAsToolShimRuntimeIdentifiers>
75
<!-- None of the tool projects are project reference providers. -->
86
<IsProjectReferenceProvider>false</IsProjectReferenceProvider>
97
<!--

0 commit comments

Comments
 (0)