Skip to content

Commit 483cc00

Browse files
Copilotdanmoseley
andcommitted
Fix memory leak in ImportCertificate method by properly disposing X509Certificate2
Co-authored-by: danmoseley <[email protected]>
1 parent 6314908 commit 483cc00

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/Shared/CertificateGeneration/CertificateManager.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,22 +482,25 @@ internal ImportCertificateResult ImportCertificate(string certificatePath, strin
482482
{
483483
Log.NoHttpsDevelopmentCertificate(GetDescription(certificate));
484484
}
485+
certificate.Dispose();
485486
return ImportCertificateResult.NoDevelopmentHttpsCertificate;
486487
}
487488

488489
try
489490
{
490-
SaveCertificate(certificate);
491+
certificate = SaveCertificate(certificate);
491492
}
492493
catch (Exception e)
493494
{
494495
if (Log.IsEnabled())
495496
{
496497
Log.SaveCertificateInStoreError(e.ToString());
497498
}
499+
certificate.Dispose();
498500
return ImportCertificateResult.ErrorSavingTheCertificateIntoTheCurrentUserPersonalStore;
499501
}
500502

503+
certificate.Dispose();
501504
return ImportCertificateResult.Succeeded;
502505
}
503506

0 commit comments

Comments
 (0)