You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merged PR 21869: Correct --architecture in fpm commands
# {PR title}
Correct `--architecture` in `fpm` commands
## Description
Update `fpm` commands to use a supported `--architecture` value. As-is, the x64 .rpm files we produce are incompatible w/ installation on an x64 machine. Problem found during servicing version flow.
## Customer Impact
Unable to build dotnet-installer-ci-official w/ current .rpm files from dotnet-aspnetcore repo.
## Regression?
- [x] Yes
- [ ] No
This is a build regression since 6.0.3. It will also impact our 'main' branch.
## Risk
- [ ] High
- [ ] Medium
- [x] Low
Have verified the chosen values for the command line using available online documentation. Since we know the current .rpm files are busted, things can only get better 😃
## Verification
- [x] Manual (required)
- [ ] Automated
I am locally building this branch and will use `rpmlint` in a `docker` container to verify the goodness of the produced package.
## Packaging changes reviewed?
- [ ] Yes
- [ ] No
- [ ] N/A
Not sure how to answer this because the change is to an internal setting of the RPM installer. If others agree it's the right change, it's been reviewed 😃
----
## When servicing release/2.1
- [ ] Make necessary changes in eng/PatchConfig.props
0 commit comments