Make update types consistent

Author: JamesNK

src/Identity/Extensions.Core/src/UserManager.cs

@@ -997,11 +997,11 @@ public virtual async Task<IdentityResult> UpdateSecurityStampAsync(TUser user)
             ArgumentNullThrowHelper.ThrowIfNull(user);
 
             await UpdateSecurityStampInternal(user).ConfigureAwait(false);
-            return await UpdateUserAndRecordMetricAsync(user, UserUpdateType.SecurityStamp, startTimeStamp).ConfigureAwait(false);
+            return await UpdateUserAndRecordMetricAsync(user, UserUpdateType.UpdateSecurityStamp, startTimeStamp).ConfigureAwait(false);
         }
         catch (Exception ex)
         {
-            _metrics?.UpdateUser(typeof(TUser).FullName!, result: null, UserUpdateType.SecurityStamp, startTimeStamp, ex);
+            _metrics?.UpdateUser(typeof(TUser).FullName!, result: null, UserUpdateType.UpdateSecurityStamp, startTimeStamp, ex);
             throw;
         }
     }
@@ -2217,17 +2217,17 @@ public virtual async Task<IdentityResult> AccessFailedAsync(TUser user)
             var count = await store.IncrementAccessFailedCountAsync(user, CancellationToken).ConfigureAwait(false);
             if (count < Options.Lockout.MaxFailedAccessAttempts)
             {
-                return await UpdateUserAndRecordMetricAsync(user, UserUpdateType.AccessFailed, startTimestamp).ConfigureAwait(false);
+                return await UpdateUserAndRecordMetricAsync(user, UserUpdateType.IncrementAccessFailed, startTimestamp).ConfigureAwait(false);
             }
             Logger.LogDebug(LoggerEventIds.UserLockedOut, "User is locked out.");
             await store.SetLockoutEndDateAsync(user, DateTimeOffset.UtcNow.Add(Options.Lockout.DefaultLockoutTimeSpan),
                 CancellationToken).ConfigureAwait(false);
             await store.ResetAccessFailedCountAsync(user, CancellationToken).ConfigureAwait(false);
-            return await UpdateUserAndRecordMetricAsync(user, UserUpdateType.AccessFailed, startTimestamp).ConfigureAwait(false);
+            return await UpdateUserAndRecordMetricAsync(user, UserUpdateType.IncrementAccessFailed, startTimestamp).ConfigureAwait(false);
         }
         catch (Exception ex)
         {
-            _metrics?.UpdateUser(typeof(TUser).FullName!, result: null, UserUpdateType.AccessFailed, startTimestamp, ex);
+            _metrics?.UpdateUser(typeof(TUser).FullName!, result: null, UserUpdateType.IncrementAccessFailed, startTimestamp, ex);
             throw;
         }
     }

src/Identity/Extensions.Core/src/UserManagerMetrics.cs

@@ -255,7 +255,7 @@ private static string GetUpdateType(UserUpdateType updateType)
             UserUpdateType.SetUserName => "set_user_name",
             UserUpdateType.AddPassword => "add_password",
             UserUpdateType.ChangePassword => "change_password",
-            UserUpdateType.SecurityStamp => "security_stamp",
+            UserUpdateType.UpdateSecurityStamp => "update_security_stamp",
             UserUpdateType.ResetPassword => "reset_password",
             UserUpdateType.RemoveLogin => "remove_login",
             UserUpdateType.AddLogin => "add_login",
@@ -274,7 +274,7 @@ private static string GetUpdateType(UserUpdateType updateType)
             UserUpdateType.SetTwoFactorEnabled => "set_two_factor_enabled",
             UserUpdateType.SetLockoutEnabled => "set_lockout_enabled",
             UserUpdateType.SetLockoutEndDate => "set_lockout_end_date",
-            UserUpdateType.AccessFailed => "access_failed",
+            UserUpdateType.IncrementAccessFailed => "increment_access_failed",
             UserUpdateType.ResetAccessFailedCount => "reset_access_failed_count",
             UserUpdateType.SetAuthenticationToken => "set_authentication_token",
             UserUpdateType.RemoveAuthenticationToken => "remove_authentication_token",

src/Identity/Extensions.Core/src/UserUpdateType.cs

@@ -9,7 +9,7 @@ internal enum UserUpdateType
     SetUserName,
     AddPassword,
     ChangePassword,
-    SecurityStamp,
+    UpdateSecurityStamp,
     ResetPassword,
     RemoveLogin,
     AddLogin,
@@ -28,7 +28,7 @@ internal enum UserUpdateType
     SetTwoFactorEnabled,
     SetLockoutEnabled,
     SetLockoutEndDate,
-    AccessFailed,
+    IncrementAccessFailed,
     ResetAccessFailedCount,
     SetAuthenticationToken,
     RemoveAuthenticationToken,