Sync shared code from runtime (#49480)

github-actions[bot] · Tratcher · web-flow · commit 5a6984400e1b · 2023-07-18T09:20:22.000-07:00
Co-authored-by: Tratcher &lt;Tratcher@users.noreply.github.com&gt;
diff --git a/src/Shared/test/Shared.Tests/runtime/Http3/QPackDecoderTest.cs b/src/Shared/test/Shared.Tests/runtime/Http3/QPackDecoderTest.cs
@@ -15,7 +15,7 @@
 
 namespace System.Net.Http.Unit.Tests.QPack
 {
-    public class QPackDecoderTests
+    public class QPackDecoderTests : IDisposable
     {
         private const int MaxHeaderFieldSize = 8192;
 
@@ -64,6 +64,11 @@ public QPackDecoderTests()
             _decoder = new QPackDecoder(MaxHeaderFieldSize);
         }
 
+        public void Dispose()
+        {
+            _decoder.Dispose();
+        }
+
         [Fact]
         public void DecodesIndexedHeaderField_StaticTableWithValue()
         {
@@ -318,7 +323,7 @@ private static void TestDecodeWithoutIndexing(byte[] encoded, KeyValuePair<strin
 
         private static void TestDecode(byte[] encoded, KeyValuePair<string, string>[] expectedValues, bool expectDynamicTableEntry, int? bytesAtATime)
         {
-            QPackDecoder decoder = new QPackDecoder(MaxHeaderFieldSize);
+            using QPackDecoder decoder = new QPackDecoder(MaxHeaderFieldSize);
             TestHttpHeadersHandler handler = new TestHttpHeadersHandler();
 
             // Read past header

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`
`16`	`16`	`namespace System.Net.Http.Unit.Tests.QPack`
`17`	`17`	`{`
`18`		`- public class QPackDecoderTests`
	`18`	`+ public class QPackDecoderTests : IDisposable`
`19`	`19`	`{`
`20`	`20`	`private const int MaxHeaderFieldSize = 8192;`
`21`	`21`
`@@ -64,6 +64,11 @@ public QPackDecoderTests()`
`64`	`64`	`_decoder = new QPackDecoder(MaxHeaderFieldSize);`
`65`	`65`	`}`
`66`	`66`
	`67`	`+ public void Dispose()`
	`68`	`+ {`
	`69`	`+ _decoder.Dispose();`
	`70`	`+ }`
	`71`	`+`
`67`	`72`	`[Fact]`
`68`	`73`	`public void DecodesIndexedHeaderField_StaticTableWithValue()`
`69`	`74`	`{`
`@@ -318,7 +323,7 @@ private static void TestDecodeWithoutIndexing(byte[] encoded, KeyValuePair<strin`
`318`	`323`
`319`	`324`	`private static void TestDecode(byte[] encoded, KeyValuePair<string, string>[] expectedValues, bool expectDynamicTableEntry, int? bytesAtATime)`
`320`	`325`	`{`
`321`		`- QPackDecoder decoder = new QPackDecoder(MaxHeaderFieldSize);`
	`326`	`+ using QPackDecoder decoder = new QPackDecoder(MaxHeaderFieldSize);`
`322`	`327`	`TestHttpHeadersHandler handler = new TestHttpHeadersHandler();`
`323`	`328`
`324`	`329`	`// Read past header`