Consistent parameter naming and removed a leftover dynamic object test

Author: mkArtakMSFT

src/Features/JsonPatch.SystemTextJson/src/Adapters/ObjectAdapter.cs

@@ -16,27 +16,27 @@ public class ObjectAdapter : IObjectAdapterWithTest
     /// <summary>
     /// Initializes a new instance of <see cref="ObjectAdapter"/>.
     /// </summary>
-    /// <param name="jsonSerializerOptions">The <see cref="JsonSerializerOptions"/>.</param>
+    /// <param name="serializerOptions">The <see cref="JsonSerializerOptions"/>.</param>
     /// <param name="logErrorAction">The <see cref="Action"/> for logging <see cref="JsonPatchError"/>.</param>
     public ObjectAdapter(
-        JsonSerializerOptions jsonSerializerOptions,
+        JsonSerializerOptions serializerOptions,
         Action<JsonPatchError> logErrorAction) :
-        this(jsonSerializerOptions, logErrorAction, Adapters.AdapterFactory.Default)
+        this(serializerOptions, logErrorAction, Adapters.AdapterFactory.Default)
     {
     }
 
     /// <summary>
     /// Initializes a new instance of <see cref="ObjectAdapter"/>.
     /// </summary>
-    /// <param name="jsonSerializerOptions">The <see cref="JsonSerializerOptions"/>.</param>
+    /// <param name="serializerOptions">The <see cref="JsonSerializerOptions"/>.</param>
     /// <param name="logErrorAction">The <see cref="Action"/> for logging <see cref="JsonPatchError"/>.</param>
     /// <param name="adapterFactory">The <see cref="IAdapterFactory"/> to use when creating adaptors.</param>
     public ObjectAdapter(
-       JsonSerializerOptions jsonSerializerOptions,
+       JsonSerializerOptions serializerOptions,
        Action<JsonPatchError> logErrorAction,
        IAdapterFactory adapterFactory)
     {
-        SerializerOptions = jsonSerializerOptions ?? throw new ArgumentNullException(nameof(jsonSerializerOptions));
+        SerializerOptions = serializerOptions ?? throw new ArgumentNullException(nameof(serializerOptions));
         LogErrorAction = logErrorAction;
         AdapterFactory = adapterFactory ?? throw new ArgumentNullException(nameof(adapterFactory));
     }

src/Features/JsonPatch.SystemTextJson/src/Internal/ConversionResultProvider.cs

@@ -18,7 +18,7 @@ public static ConversionResult ConvertTo(object value, Type typeToConvertTo)
         return ConvertTo(value, typeToConvertTo, null);
     }
 
-    internal static ConversionResult ConvertTo(object value, Type typeToConvertTo, JsonSerializerOptions jsonSerializerOptions)
+    internal static ConversionResult ConvertTo(object value, Type typeToConvertTo, JsonSerializerOptions serializerOptions)
     {
         if (value == null)
         {
@@ -39,8 +39,8 @@ internal static ConversionResult ConvertTo(object value, Type typeToConvertTo, J
 
         try
         {
-            var serializedDocument = JsonSerializer.Serialize(value, jsonSerializerOptions);
-            var deserialized = JsonSerializer.Deserialize(serializedDocument, typeToConvertTo, jsonSerializerOptions);
+            var serializedDocument = JsonSerializer.Serialize(value, serializerOptions);
+            var deserialized = JsonSerializer.Deserialize(serializedDocument, typeToConvertTo, serializerOptions);
             return new ConversionResult(true, deserialized);
         }
         catch

src/Features/JsonPatch.SystemTextJson/src/Internal/IAdapter.cs

@@ -14,41 +14,41 @@ public interface IAdapter
     bool TryTraverse(
         object target,
         string segment,
-        JsonSerializerOptions jsonSerializerOptions,
+        JsonSerializerOptions serializerOptions,
         out object nextTarget,
         out string errorMessage);
 
     bool TryAdd(
         object target,
         string segment,
-        JsonSerializerOptions jsonSerializerOptions,
+        JsonSerializerOptions serializerOptions,
         object value,
         out string errorMessage);
 
     bool TryRemove(
         object target,
         string segment,
-        JsonSerializerOptions jsonSerializerOptions,
+        JsonSerializerOptions serializerOptions,
         out string errorMessage);
 
     bool TryGet(
         object target,
         string segment,
-        JsonSerializerOptions jsonSerializerOptions,
+        JsonSerializerOptions serializerOptions,
         out object value,
         out string errorMessage);
 
     bool TryReplace(
         object target,
         string segment,
-        JsonSerializerOptions jsonSerializerOptions,
+        JsonSerializerOptions serializerOptions,
         object value,
         out string errorMessage);
 
     bool TryTest(
         object target,
         string segment,
-        JsonSerializerOptions jsonSerializerOptions,
+        JsonSerializerOptions serializerOptions,
         object value,
         out string errorMessage);
 }