pr review

Author: DeagleGross

src/Servers/HttpSys/src/RequestProcessing/RequestContext.cs

@@ -255,7 +255,7 @@ internal unsafe bool TryGetTlsClientHelloMessageBytes(
                 bytesReturned: (IntPtr)bytesReturnedPointer,
                 overlapped: IntPtr.Zero);
 
-            bytesReturned = (int)bytesReturnedValue;
+            bytesReturned = checked((int)bytesReturnedValue);
 
             if (statusCode is ErrorCodes.ERROR_SUCCESS)
             {

src/Servers/HttpSys/test/FunctionalTests/HttpsTests.cs

@@ -241,7 +241,7 @@ public async Task Https_ITlsHandshakeFeature_MatchesIHttpSysExtensionInfoFeature
 
     [ConditionalFact]
     [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10_20H2)]
-    public void Https_SetsIHttpSysRequestPropertyFeature()
+    public async Task Https_SetsIHttpSysRequestPropertyFeature()
     {
         using (Utilities.CreateDynamicHttpsServer(out var address, async httpContext =>
         {
@@ -256,7 +256,8 @@ public void Https_SetsIHttpSysRequestPropertyFeature()
             }
         }, LoggerFactory))
         {
-            // nothing
+            string response = await SendRequestAsync(address);
+            Assert.Equal(string.Empty, response);
         }
     }
 

src/Servers/Kestrel/Core/src/ListenOptionsHttpsExtensions.cs

@@ -188,7 +188,7 @@ public static ListenOptions UseHttps(this ListenOptions listenOptions, Action<Ht
     /// <see cref="KestrelServerOptions.ConfigureHttpsDefaults(Action{HttpsConnectionAdapterOptions})"/>.
     /// </summary>
     /// <param name="listenOptions">The <see cref="ListenOptions"/> to configure.</param>
-    /// <param name="httpsOptions">Options to configure HTTPS.</param>  
+    /// <param name="httpsOptions">Options to configure HTTPS.</param>
     /// <returns>The <see cref="ListenOptions"/>.</returns>
     public static ListenOptions UseHttps(this ListenOptions listenOptions, HttpsConnectionAdapterOptions httpsOptions)
     {