Check length of TypeArguments before accessing via index

benhopkinstech · benhopkinstech · commit 6b67fcd4c5f5 · 2025-03-04T21:22:18.000Z
diff --git a/src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/DisallowNonParsableComplexTypesOnParameters.cs b/src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/DisallowNonParsableComplexTypesOnParameters.cs
@@ -128,7 +128,8 @@ static bool ReportFromAttributeDiagnostic(OperationAnalysisContext context, Well
             }
 
             // If it is nullable, unwrap it.
-            if (parameterTypeSymbol!.ConstructedFrom.SpecialType == SpecialType.System_Nullable_T)
+            if (parameterTypeSymbol!.ConstructedFrom.SpecialType == SpecialType.System_Nullable_T &&
+                parameterTypeSymbol.TypeArguments.Length > 0)
             {
                 parameterTypeSymbol = parameterTypeSymbol.TypeArguments[0] as INamedTypeSymbol;
             }

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,8 @@ static bool ReportFromAttributeDiagnostic(OperationAnalysisContext context, Well`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`// If it is nullable, unwrap it.`
`131`		`- if (parameterTypeSymbol!.ConstructedFrom.SpecialType == SpecialType.System_Nullable_T)`
	`131`	`+ if (parameterTypeSymbol!.ConstructedFrom.SpecialType == SpecialType.System_Nullable_T &&`
	`132`	`+ parameterTypeSymbol.TypeArguments.Length > 0)`
`132`	`133`	`{`
`133`	`134`	`parameterTypeSymbol = parameterTypeSymbol.TypeArguments[0] as INamedTypeSymbol;`
`134`	`135`	`}`