Add obsolete attributes to IActionContextAccessor and suppress warnings in framework code

Co-authored-by: captainsafia <[email protected]>

Author: Copilot

src/Mvc/Mvc.Core/src/Infrastructure/ActionContextAccessor.cs

@@ -10,6 +10,7 @@ namespace Microsoft.AspNetCore.Mvc.Infrastructure;
 /// <summary>
 /// Type that provides access to an <see cref="ActionContext"/>.
 /// </summary>
+[Obsolete("ActionContextAccessor is obsolete. Use IHttpContextAccessor instead and access the endpoint information from HttpContext.GetEndpoint(). This type will be removed in a future version.")]
 public class ActionContextAccessor : IActionContextAccessor
 {
     internal static readonly IActionContextAccessor Null = new NullActionContextAccessor();

src/Mvc/Mvc.Core/src/Infrastructure/ControllerActionInvoker.cs

@@ -30,7 +30,9 @@ internal partial class ControllerActionInvoker : ResourceInvoker, IActionInvoker
     internal ControllerActionInvoker(
         ILogger logger,
         DiagnosticListener diagnosticListener,
+#pragma warning disable CS0618 // Type or member is obsolete
         IActionContextAccessor actionContextAccessor,
+#pragma warning restore CS0618 // Type or member is obsolete
         IActionResultTypeMapper mapper,
         ControllerContext controllerContext,
         ControllerActionInvokerCacheEntry cacheEntry,

src/Mvc/Mvc.Core/src/Infrastructure/ControllerActionInvokerProvider.cs

@@ -23,7 +23,9 @@ internal sealed class ControllerActionInvokerProvider : IActionInvokerProvider
     private readonly ILogger _logger;
     private readonly DiagnosticListener _diagnosticListener;
     private readonly IActionResultTypeMapper _mapper;
+#pragma warning disable CS0618 // Type or member is obsolete
     private readonly IActionContextAccessor _actionContextAccessor;
+#pragma warning restore CS0618 // Type or member is obsolete
 
     public ControllerActionInvokerProvider(
         ControllerActionInvokerCache controllerActionInvokerCache,
@@ -41,7 +43,9 @@ public ControllerActionInvokerProvider(
         ILoggerFactory loggerFactory,
         DiagnosticListener diagnosticListener,
         IActionResultTypeMapper mapper,
+#pragma warning disable CS0618 // Type or member is obsolete
         IActionContextAccessor? actionContextAccessor)
+#pragma warning restore CS0618 // Type or member is obsolete
     {
         _controllerActionInvokerCache = controllerActionInvokerCache;
         _valueProviderFactories = optionsAccessor.Value.ValueProviderFactories.ToArray();
@@ -51,7 +55,9 @@ public ControllerActionInvokerProvider(
         _logger = loggerFactory.CreateLogger(typeof(ControllerActionInvoker));
         _diagnosticListener = diagnosticListener;
         _mapper = mapper;
+#pragma warning disable CS0618 // Type or member is obsolete
         _actionContextAccessor = actionContextAccessor ?? ActionContextAccessor.Null;
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     public int Order => -1000;

src/Mvc/Mvc.Core/src/Infrastructure/IActionContextAccessor.cs

@@ -10,6 +10,7 @@ namespace Microsoft.AspNetCore.Mvc.Infrastructure;
 /// <summary>
 /// Defines an interface for exposing an <see cref="ActionContext"/>.
 /// </summary>
+[Obsolete("IActionContextAccessor is obsolete. Use IHttpContextAccessor instead and access the endpoint information from HttpContext.GetEndpoint(). This type will be removed in a future version.")]
 public interface IActionContextAccessor
 {
     /// <summary>

src/Mvc/Mvc.Core/src/Infrastructure/ResourceInvoker.cs

@@ -15,7 +15,9 @@ internal abstract partial class ResourceInvoker
 {
     protected readonly DiagnosticListener _diagnosticListener;
     protected readonly ILogger _logger;
+#pragma warning disable CS0618 // Type or member is obsolete
     protected readonly IActionContextAccessor _actionContextAccessor;
+#pragma warning restore CS0618 // Type or member is obsolete
     protected readonly IActionResultTypeMapper _mapper;
     protected readonly ActionContext _actionContext;
     protected readonly IFilterMetadata[] _filters;
@@ -37,7 +39,9 @@ internal abstract partial class ResourceInvoker
     public ResourceInvoker(
         DiagnosticListener diagnosticListener,
         ILogger logger,
+#pragma warning disable CS0618 // Type or member is obsolete
         IActionContextAccessor actionContextAccessor,
+#pragma warning restore CS0618 // Type or member is obsolete
         IActionResultTypeMapper mapper,
         ActionContext actionContext,
         IFilterMetadata[] filters,

src/Mvc/Mvc.Core/src/Routing/ControllerRequestDelegateFactory.cs

@@ -24,7 +24,9 @@ internal sealed class ControllerRequestDelegateFactory : IRequestDelegateFactory
     private readonly ILogger _logger;
     private readonly DiagnosticListener _diagnosticListener;
     private readonly IActionResultTypeMapper _mapper;
+#pragma warning disable CS0618 // Type or member is obsolete
     private readonly IActionContextAccessor _actionContextAccessor;
+#pragma warning restore CS0618 // Type or member is obsolete
     private readonly bool _enableActionInvokers;
 
     public ControllerRequestDelegateFactory(
@@ -43,7 +45,9 @@ public ControllerRequestDelegateFactory(
         ILoggerFactory loggerFactory,
         DiagnosticListener diagnosticListener,
         IActionResultTypeMapper mapper,
+#pragma warning disable CS0618 // Type or member is obsolete
         IActionContextAccessor? actionContextAccessor)
+#pragma warning restore CS0618 // Type or member is obsolete
     {
         _controllerActionInvokerCache = controllerActionInvokerCache;
         _valueProviderFactories = optionsAccessor.Value.ValueProviderFactories.ToArray();
@@ -54,7 +58,9 @@ public ControllerRequestDelegateFactory(
         _logger = loggerFactory.CreateLogger<ControllerActionInvoker>();
         _diagnosticListener = diagnosticListener;
         _mapper = mapper;
+#pragma warning disable CS0618 // Type or member is obsolete
         _actionContextAccessor = actionContextAccessor ?? ActionContextAccessor.Null;
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     public RequestDelegate? CreateRequestDelegate(ActionDescriptor actionDescriptor, RouteValueDictionary? dataTokens)

src/Mvc/Mvc.Core/test/Filters/MiddlewareFilterTest.cs

@@ -398,7 +398,9 @@ public TestControllerActionInvoker(
             : base(
                   logger,
                   diagnosticListener,
+#pragma warning disable CS0618 // Type or member is obsolete
                   ActionContextAccessor.Null,
+#pragma warning restore CS0618 // Type or member is obsolete
                   mapper,
                   CreateControllerContext(actionContext, valueProviderFactories, maxAllowedErrorsInModelState),
                   CreateCacheEntry((ControllerActionDescriptor)actionContext.ActionDescriptor, controllerFactory),

src/Mvc/Mvc.Core/test/Infrastructure/ControllerActionInvokerTest.cs

@@ -1432,7 +1432,9 @@ public async Task Invoke_UsesDefaultValuesIfNotBound()
         var invoker = new ControllerActionInvoker(
             new NullLoggerFactory().CreateLogger<ControllerActionInvoker>(),
             new DiagnosticListener("Microsoft.AspNetCore"),
+#pragma warning disable CS0618 // Type or member is obsolete
             ActionContextAccessor.Null,
+#pragma warning restore CS0618 // Type or member is obsolete
             new ActionResultTypeMapper(),
             controllerContext,
             cacheEntry,
@@ -1769,7 +1771,9 @@ private ControllerActionInvoker CreateInvoker(
         var invoker = new ControllerActionInvoker(
             logger,
             diagnosticSource,
+#pragma warning disable CS0618 // Type or member is obsolete
             ActionContextAccessor.Null,
+#pragma warning restore CS0618 // Type or member is obsolete
             new ActionResultTypeMapper(),
             controllerContext,
             cacheEntry,

src/Mvc/Mvc.RazorPages/src/Infrastructure/PageActionInvoker.cs

@@ -35,7 +35,9 @@ public PageActionInvoker(
         IPageHandlerMethodSelector handlerMethodSelector,
         DiagnosticListener diagnosticListener,
         ILogger logger,
+#pragma warning disable CS0618 // Type or member is obsolete
         IActionContextAccessor actionContextAccessor,
+#pragma warning restore CS0618 // Type or member is obsolete
         IActionResultTypeMapper mapper,
         PageContext pageContext,
         IFilterMetadata[] filterMetadata,

src/Mvc/Mvc.RazorPages/src/Infrastructure/PageActionInvokerProvider.cs

@@ -25,7 +25,9 @@ internal sealed class PageActionInvokerProvider : IActionInvokerProvider
     private readonly DiagnosticListener _diagnosticListener;
     private readonly ILogger<PageActionInvoker> _logger;
     private readonly IActionResultTypeMapper _mapper;
+#pragma warning disable CS0618 // Type or member is obsolete
     private readonly IActionContextAccessor _actionContextAccessor;
+#pragma warning restore CS0618 // Type or member is obsolete
 
     public PageActionInvokerProvider(
         PageLoader pageLoader,
@@ -38,7 +40,9 @@ public PageActionInvokerProvider(
         DiagnosticListener diagnosticListener,
         ILoggerFactory loggerFactory,
         IActionResultTypeMapper mapper,
+#pragma warning disable CS0618 // Type or member is obsolete
         IActionContextAccessor? actionContextAccessor = null)
+#pragma warning restore CS0618 // Type or member is obsolete
     {
         _pageLoader = pageLoader;
         _pageActionInvokerCache = pageActionInvokerCache;
@@ -50,7 +54,9 @@ public PageActionInvokerProvider(
         _diagnosticListener = diagnosticListener;
         _logger = loggerFactory.CreateLogger<PageActionInvoker>();
         _mapper = mapper;
+#pragma warning disable CS0618 // Type or member is obsolete
         _actionContextAccessor = actionContextAccessor ?? ActionContextAccessor.Null;
+#pragma warning restore CS0618 // Type or member is obsolete
     }
 
     // For testing