Skip to content

Commit 761eec9

Browse files
[release/7.0] Fixing XML documentation (#44523)
* Update IHttpRequestFeature.cs * Update ApiParameterDescription.cs * Update IProblemDetailsService.cs * Update ApiConventionApplicationModelConvention.cs * Update CircuitHandler.cs * Update CorsPolicyBuilder.cs * Update TypedResults.cs Co-authored-by: Bruno Oliveira <[email protected]>
1 parent a79ce19 commit 761eec9

File tree

7 files changed

+30
-28
lines changed

7 files changed

+30
-28
lines changed

src/Components/Server/src/Circuits/CircuitHandler.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,20 @@ namespace Microsoft.AspNetCore.Components.Server.Circuits;
66
/// <summary>
77
/// A <see cref="CircuitHandler"/> allows running code during specific lifetime events of a <see cref="Circuit"/>.
88
/// <list type="bullet">
9-
/// <item>
9+
/// <item><description>
1010
/// <see cref="OnCircuitOpenedAsync(Circuit, CancellationToken)"/> is invoked after an initial circuit to the client
1111
/// has been established.
12-
/// </item>
13-
/// <item>
12+
/// </description></item>
13+
/// <item><description>
1414
/// <see cref="OnConnectionUpAsync(Circuit, CancellationToken)"/> is invoked immediately after the completion of
1515
/// <see cref="OnCircuitOpenedAsync(Circuit, CancellationToken)"/>. In addition, the method is invoked each time a connection is re-established
1616
/// with a client after it's been dropped. <see cref="OnConnectionDownAsync(Circuit, CancellationToken)"/> is invoked each time a connection
1717
/// is dropped.
18-
/// </item>
19-
/// <item>
18+
/// </description></item>
19+
/// <item><description>
2020
/// <see cref="OnCircuitClosedAsync(Circuit, CancellationToken)"/> is invoked prior to the server evicting the circuit to the client.
2121
/// Application users may use this event to save state for a client that can be later rehydrated.
22-
/// </item>
22+
/// </description></item>
2323
/// </list>
2424
/// </summary>
2525
public abstract class CircuitHandler

src/Http/Http.Abstractions/src/ProblemDetails/IProblemDetailsService.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,10 @@ public interface IProblemDetailsService
1616
/// <param name="context">The <see cref="ProblemDetailsContext"/> associated with the current request/response.</param>
1717
/// <remarks>The <see cref="IProblemDetailsWriter"/> registered services
1818
/// are processed in sequence and the processing is completed when:
19-
/// <list type="bullet">One of them reports that the response was written successfully, or.</list>
20-
/// <list type="bullet">All <see cref="IProblemDetailsWriter"/> were executed and none of them was able to write the response successfully.</list>
19+
/// <list type="bullet">
20+
/// <item><description>One of them reports that the response was written successfully, or.</description></item>
21+
/// <item><description>All <see cref="IProblemDetailsWriter"/> were executed and none of them was able to write the response successfully.</description></item>
22+
/// </list>
2123
/// </remarks>
2224
ValueTask WriteAsync(ProblemDetailsContext context);
2325
}

src/Http/Http.Features/src/IHttpRequestFeature.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ public interface IHttpRequestFeature
7171
/// <para>
7272
/// The values are not split or merged across header lines. E.g. The following headers:
7373
/// <list type="bullet">
74-
/// <item>HeaderA: value1, value2</item>
75-
/// <item>HeaderA: value3</item>
74+
/// <item><description>HeaderA: value1, value2</description></item>
75+
/// <item><description>HeaderA: value3</description></item>
7676
/// </list>
7777
/// Result in Headers["HeaderA"] = { "value1, value2", "value3" }
7878
/// </para>

src/Http/Http.Results/src/TypedResults.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -543,9 +543,9 @@ public static VirtualFileHttpResult VirtualFile(
543543
/// <summary>
544544
/// Redirects to the specified <paramref name="url"/>.
545545
/// <list type="bullet">
546-
/// <item>When <paramref name="permanent"/> and <paramref name="preserveMethod"/> are set, sets the <see cref="StatusCodes.Status308PermanentRedirect"/> status code.</item>
547-
/// <item>When <paramref name="preserveMethod"/> is set, sets the <see cref="StatusCodes.Status307TemporaryRedirect"/> status code.</item>
548-
/// <item>When <paramref name="permanent"/> is set, sets the <see cref="StatusCodes.Status301MovedPermanently"/> status code.</item>
546+
/// <item><description>When <paramref name="permanent"/> and <paramref name="preserveMethod"/> are set, sets the <see cref="StatusCodes.Status308PermanentRedirect"/> status code.</description></item>
547+
/// <item><description>When <paramref name="preserveMethod"/> is set, sets the <see cref="StatusCodes.Status307TemporaryRedirect"/> status code.</description></item>
548+
/// <item><description>When <paramref name="permanent"/> is set, sets the <see cref="StatusCodes.Status301MovedPermanently"/> status code.</description></item>
549549
/// <item>Otherwise, configures <see cref="StatusCodes.Status302Found"/>.</item>
550550
/// </list>
551551
/// </summary>
@@ -566,9 +566,9 @@ public static RedirectHttpResult Redirect(string url, bool permanent = false, bo
566566
/// <summary>
567567
/// Redirects to the specified <paramref name="localUrl"/>.
568568
/// <list type="bullet">
569-
/// <item>When <paramref name="permanent"/> and <paramref name="preserveMethod"/> are set, sets the <see cref="StatusCodes.Status308PermanentRedirect"/> status code.</item>
570-
/// <item>When <paramref name="preserveMethod"/> is set, sets the <see cref="StatusCodes.Status307TemporaryRedirect"/> status code.</item>
571-
/// <item>When <paramref name="permanent"/> is set, sets the <see cref="StatusCodes.Status301MovedPermanently"/> status code.</item>
569+
/// <item><description>When <paramref name="permanent"/> and <paramref name="preserveMethod"/> are set, sets the <see cref="StatusCodes.Status308PermanentRedirect"/> status code.</description></item>
570+
/// <item><description>When <paramref name="preserveMethod"/> is set, sets the <see cref="StatusCodes.Status307TemporaryRedirect"/> status code.</description></item>
571+
/// <item><description>When <paramref name="permanent"/> is set, sets the <see cref="StatusCodes.Status301MovedPermanently"/> status code.</description></item>
572572
/// <item>Otherwise, configures <see cref="StatusCodes.Status302Found"/>.</item>
573573
/// </list>
574574
/// </summary>
@@ -589,10 +589,10 @@ public static RedirectHttpResult LocalRedirect(string localUrl, bool permanent =
589589
/// <summary>
590590
/// Redirects to the specified route.
591591
/// <list type="bullet">
592-
/// <item>When <paramref name="permanent"/> and <paramref name="preserveMethod"/> are set, sets the <see cref="StatusCodes.Status308PermanentRedirect"/> status code.</item>
593-
/// <item>When <paramref name="preserveMethod"/> is set, sets the <see cref="StatusCodes.Status307TemporaryRedirect"/> status code.</item>
594-
/// <item>When <paramref name="permanent"/> is set, sets the <see cref="StatusCodes.Status301MovedPermanently"/> status code.</item>
595-
/// <item>Otherwise, configures <see cref="StatusCodes.Status302Found"/>.</item>
592+
/// <item><description>When <paramref name="permanent"/> and <paramref name="preserveMethod"/> are set, sets the <see cref="StatusCodes.Status308PermanentRedirect"/> status code.</description></item>
593+
/// <item><description>When <paramref name="preserveMethod"/> is set, sets the <see cref="StatusCodes.Status307TemporaryRedirect"/> status code.</description></item>
594+
/// <item><description>When <paramref name="permanent"/> is set, sets the <see cref="StatusCodes.Status301MovedPermanently"/> status code.</description></item>
595+
/// <item><description>Otherwise, configures <see cref="StatusCodes.Status302Found"/>.</description></item>
596596
/// </list>
597597
/// </summary>
598598
/// <param name="routeName">The name of the route.</param>

src/Middleware/CORS/src/Infrastructure/CorsPolicyBuilder.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,13 @@ public CorsPolicyBuilder(CorsPolicy policy)
4141
/// the normalization performed by the browser on the value sent in the <c>ORIGIN</c> header.
4242
/// <list type="bullet">
4343
/// <item>
44-
/// If the specified origin has an internationalized domain name (IDN), the punycoded value is used. If the origin
44+
/// <description>If the specified origin has an internationalized domain name (IDN), the punycoded value is used. If the origin
4545
/// specifies a default port (e.g. 443 for HTTPS or 80 for HTTP), this will be dropped as part of normalization.
4646
/// Finally, the scheme and punycoded host name are culture invariant lower cased before being added to the <see cref="CorsPolicy.Origins"/>
47-
/// collection.
47+
/// collection.</description>
4848
/// </item>
4949
/// <item>
50-
/// For all other origins, normalization involves performing a culture invariant lower casing of the host name.
50+
/// <description>For all other origins, normalization involves performing a culture invariant lower casing of the host name.</description>
5151
/// </item>
5252
/// </list>
5353
/// </remarks>

src/Mvc/Mvc.Abstractions/src/ApiExplorer/ApiParameterDescription.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ public class ApiParameterDescription
5252
/// <remarks>
5353
/// A parameter is considered required if
5454
/// <list type="bullet">
55-
/// <item>it's bound from the request body (<see cref="BindingSource.Body"/>).</item>
56-
/// <item>it's a required route value.</item>
57-
/// <item>it has annotations (e.g. BindRequiredAttribute) that indicate it's required.</item>
55+
/// <item><description>it's bound from the request body (<see cref="BindingSource.Body"/>).</description></item>
56+
/// <item><description>it's a required route value.</description></item>
57+
/// <item><description>it has annotations (e.g. BindRequiredAttribute) that indicate it's required.</description></item>
5858
/// </list>
5959
/// </remarks>
6060
public bool IsRequired { get; set; }

src/Mvc/Mvc.Core/src/ApplicationModels/ApiConventionApplicationModelConvention.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ namespace Microsoft.AspNetCore.Mvc.ApplicationModels;
1010
/// <summary>
1111
/// An <see cref="IActionModelConvention"/> that discovers
1212
/// <list type="bullet">
13-
/// <item><see cref="ApiConventionResult"/> from applied <see cref="ApiConventionTypeAttribute"/> or <see cref="ApiConventionMethodAttribute"/>.</item>
14-
/// <item><see cref="ProducesErrorResponseTypeAttribute"/> that applies to the action.</item>
13+
/// <item><description><see cref="ApiConventionResult"/> from applied <see cref="ApiConventionTypeAttribute"/> or <see cref="ApiConventionMethodAttribute"/>.</description></item>
14+
/// <item><description><see cref="ProducesErrorResponseTypeAttribute"/> that applies to the action.</description></item>
1515
/// </list>
1616
/// </summary>
1717
public class ApiConventionApplicationModelConvention : IActionModelConvention

0 commit comments

Comments
 (0)