Make XML file discovery less eager

Author: captainsafia

src/OpenApi/build/Microsoft.AspNetCore.OpenApi.targets

@@ -10,8 +10,7 @@
         Include="@(ReferencePath->'%(RootDir)%(Directory)%(Filename).xml')"
         Condition="'%(ReferencePath.Extension)' == '.dll' AND
         Exists('%(ReferencePath.RootDir)%(ReferencePath.Directory)%(ReferencePath.Filename).xml') AND
-        ('%(ReferencePath.ReferenceSourceTarget)' == 'ProjectReference' OR
-         '%(ReferencePath.NuGetSourceType)' == 'Package')"
+        ('%(ReferencePath.ReferenceSourceTarget)' == 'ProjectReference')"
          KeepMetadata="Identity" />
     </ItemGroup>
   </Target>

src/OpenApi/test/Microsoft.AspNetCore.OpenApi.Build.Tests/GenerateAdditionalXmlFilesForOpenApiTests.cs

@@ -37,9 +37,7 @@ public void VerifiesTargetGeneratesXmlFiles()
         // Captures ProjectReferences and PackageReferences in project.
         var identities = additionalFiles.Select(x => x["Identity"]).ToArray();
         Assert.Collection(identities,
-            x => Assert.EndsWith("ClassLibrary.xml", x),
-            x => Assert.EndsWith("Microsoft.AspNetCore.OpenApi.xml", x),
-            x => Assert.EndsWith("Microsoft.OpenApi.xml", x)
+            x => Assert.EndsWith("ClassLibrary.xml", x)
         );
     }