Replaced comparison with -1 w/ equivalent comparison to 0

This allows the cpu to fuse the compare and jump.

Author: gfoidl

src/Components/Endpoints/src/FormMapping/FormDataReader.cs

@@ -138,7 +138,7 @@ internal IReadOnlyDictionary<FormKey, HashSet<FormKey>> ProcessFormKeys()
             while (startIndex >= 0)
             {
                 var endIndex = key.Value.Span[startIndex..].IndexOf(']') + startIndex;
-                if (endIndex == -1)
+                if (endIndex < 0)
                 {
                     // Ignore malformed keys
                     break;
@@ -157,7 +157,7 @@ internal IReadOnlyDictionary<FormKey, HashSet<FormKey>> ProcessFormKeys()
 
                 var nextOpenBracket = key.Value.Span[(endIndex + 1)..].IndexOf('[');
 
-                startIndex = nextOpenBracket != -1 ? endIndex + 1 + nextOpenBracket : -1;
+                startIndex = nextOpenBracket >= 0 ? endIndex + 1 + nextOpenBracket : -1;
             }
         }
 
@@ -264,7 +264,7 @@ internal readonly bool TryGetValues(out StringValues values) =>
     internal string GetLastPrefixSegment()
     {
         var index = _currentPrefixBuffer.Span.LastIndexOfAny(".[");
-        if (index == -1)
+        if (index < 0)
         {
             return _currentPrefixBuffer.ToString();
         }

src/Components/Server/src/Circuits/ServerComponentDeserializer.cs

@@ -113,7 +113,7 @@ public bool TryDeserializeComponentDescriptorCollection(string serializedCompone
             // check covers that the sequence starts by 0.
             if (lastSequence != serverComponent.Sequence - 1)
             {
-                if (lastSequence == -1)
+                if (lastSequence < 0)
                 {
                     Log.DescriptorSequenceMustStartAtZero(_logger, serverComponent.Sequence);
                 }
@@ -125,7 +125,7 @@ public bool TryDeserializeComponentDescriptorCollection(string serializedCompone
                 return false;
             }
 
-            if (lastSequence != -1 && !previousInstance.InvocationId.Equals(serverComponent.InvocationId))
+            if (lastSequence >= 0 && !previousInstance.InvocationId.Equals(serverComponent.InvocationId))
             {
                 Log.MismatchedInvocationId(_logger, previousInstance.InvocationId.ToString("N"), serverComponent.InvocationId.ToString("N"));
                 descriptors.Clear();

src/DataProtection/DataProtection/src/TypeForwardingActivator.cs

@@ -79,11 +79,11 @@ protected static string RemoveVersionFromAssemblyName(string forwardedTypeName)
         // Type, Assembly, Version={Version}, Culture={Culture}, PublicKeyToken={Token}
 
         var versionStartIndex = forwardedTypeName.IndexOf(", Version=", StringComparison.Ordinal);
-        while (versionStartIndex != -1)
+        while (versionStartIndex >= 0)
         {
             var versionEndIndex = forwardedTypeName.IndexOf(',', versionStartIndex + ", Version=".Length);
 
-            if (versionEndIndex == -1)
+            if (versionEndIndex < 0)
             {
                 // No end index, so are done and can remove the rest
                 return forwardedTypeName.Substring(0, versionStartIndex);

src/DefaultBuilder/src/WebApplicationBuilder.cs

@@ -501,7 +501,7 @@ sourceValue is List<string> sourceDescriptions &&
             destinationValue is List<string> destinationDescriptions)
         {
             var wireUpIndex = destinationDescriptions.IndexOf(typeof(WireSourcePipeline).FullName!);
-            if (wireUpIndex != -1)
+            if (wireUpIndex >= 0)
             {
                 destinationDescriptions.RemoveAt(wireUpIndex);
                 destinationDescriptions.InsertRange(wireUpIndex, sourceDescriptions);

src/FileProviders/Embedded/src/EmbeddedFileProvider.cs

@@ -180,7 +180,7 @@ public IChangeToken Watch(string pattern)
 
     private static bool HasInvalidPathChars(string path)
     {
-        return path.IndexOfAny(_invalidFileNameChars) != -1;
+        return path.IndexOfAny(_invalidFileNameChars) >= 0;
     }
 
     #region Helper methods

src/FileProviders/Embedded/src/Manifest/EmbeddedFilesManifest.cs

@@ -63,13 +63,13 @@ internal EmbeddedFilesManifest(ManifestDirectory rootDirectory)
     private static StringSegment RemoveLeadingAndTrailingDirectorySeparators(string path)
     {
         Debug.Assert(path.Length > 0);
-        var start = Array.IndexOf(_separators, path[0]) == -1 ? 0 : 1;
+        var start = Array.IndexOf(_separators, path[0]) < 0 ? 0 : 1;
         if (start == path.Length)
         {
             return StringSegment.Empty;
         }
 
-        var end = Array.IndexOf(_separators, path[path.Length - 1]) == -1 ? path.Length : path.Length - 1;
+        var end = Array.IndexOf(_separators, path[path.Length - 1]) < 0 ? path.Length : path.Length - 1;
         var trimmed = new StringSegment(path, start, end - start);
         return trimmed;
     }
@@ -84,5 +84,5 @@ internal EmbeddedFilesManifest Scope(string path)
         throw new InvalidOperationException($"Invalid path: '{path}'");
     }
 
-    private static bool HasInvalidPathChars(string path) => path.IndexOfAny(_invalidFileNameChars) != -1;
+    private static bool HasInvalidPathChars(string path) => path.IndexOfAny(_invalidFileNameChars) >= 0;
 }

src/Http/Headers/src/ContentDispositionHeaderValue.cs

@@ -487,7 +487,7 @@ private StringSegment EncodeAndQuoteMime(StringSegment input)
 
         if (needsQuotes)
         {
-            if (result.IndexOfAny(EscapeChars) != -1)
+            if (result.IndexOfAny(EscapeChars) >= 0)
             {
                 // '\' and '"' must be escaped in a quoted string
                 result = result.ToString().Replace(@"\", @"\\").Replace(@"""", @"\""");

src/Http/Headers/src/HeaderUtilities.cs

@@ -196,7 +196,7 @@ private static int AdvanceCacheDirectiveIndex(int current, string headerValue)
         // Find the next delimiter
         current = headerValue.IndexOf(',', current);
 
-        if (current == -1)
+        if (current < 0)
         {
             // If no delimiter found, skip to the end
             return headerValue.Length;

src/Http/Headers/src/MediaTypeHeaderValue.cs

@@ -278,7 +278,7 @@ public StringSegment SubTypeWithoutSuffix
         {
             var subType = SubType;
             var startOfSuffix = subType.LastIndexOf(PlusCharacter);
-            if (startOfSuffix == -1)
+            if (startOfSuffix < 0)
             {
                 return subType;
             }
@@ -303,7 +303,7 @@ public StringSegment Suffix
         {
             var subType = SubType;
             var startOfSuffix = subType.LastIndexOf(PlusCharacter);
-            if (startOfSuffix == -1)
+            if (startOfSuffix < 0)
             {
                 return default(StringSegment);
             }
@@ -718,7 +718,7 @@ private bool MatchesSubtype(StringSegment mediaType)
 
         StringSegment suffix;
         var startOfSuffix = subType.LastIndexOf(PlusCharacter);
-        if (startOfSuffix == -1)
+        if (startOfSuffix < 0)
         {
             suffix = default(StringSegment);
         }
@@ -756,7 +756,7 @@ private bool MatchesSubtypeWithoutSuffix(MediaTypeHeaderValue set)
     private bool MatchesSubtypeWithoutSuffix(StringSegment subType, int startOfSuffix)
     {
         StringSegment subTypeWithoutSuffix;
-        if (startOfSuffix == -1)
+        if (startOfSuffix < 0)
         {
             subTypeWithoutSuffix = subType;
         }

src/Http/Http.Abstractions/src/Internal/HeaderSegmentCollection.cs

@@ -141,7 +141,7 @@ public bool MoveNext()
                     _trailingStart = -1;
 
                     if (_offset == _headerLength &&
-                        _leadingStart != -1 &&
+                        _leadingStart >= 0 &&
                         _leadingStart != _offset)
                     {
                         // Also produce trailing whitespace
@@ -186,9 +186,9 @@ public bool MoveNext()
                             switch (attr)
                             {
                                 case Attr.Delimiter:
-                                    _valueStart = _valueStart == -1 ? _offset : _valueStart;
-                                    _valueEnd = _valueEnd == -1 ? _offset : _valueEnd;
-                                    _trailingStart = _trailingStart == -1 ? _offset : _trailingStart;
+                                    _valueStart = _valueStart < 0 ? _offset : _valueStart;
+                                    _valueEnd = _valueEnd < 0 ? _offset : _valueEnd;
+                                    _trailingStart = _trailingStart < 0 ? _offset : _trailingStart;
                                     _leadingEnd = _offset;
                                     _mode = Mode.Produce;
                                     break;