Skip to content

Commit 8bb2b20

Browse files
authored
Baseline tests should check for all possible extensions of not expected files (#62752)
1 parent 3816f31 commit 8bb2b20

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

src/ProjectTemplates/test/Templates.Tests/BaselineTest.cs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,7 @@ public async Task Template_Produces_The_Right_Set_Of_FilesAsync(string arguments
8888
foreach (var file in filesInFolder)
8989
{
9090
var relativePath = file.Replace(Project.TemplateOutputDir, "").Replace("\\", "/").Trim('/');
91-
if (relativePath.EndsWith(".csproj", StringComparison.Ordinal) ||
92-
relativePath.EndsWith(".fsproj", StringComparison.Ordinal) ||
93-
relativePath.EndsWith(".props", StringComparison.Ordinal) ||
94-
relativePath.EndsWith(".sln", StringComparison.Ordinal) ||
95-
relativePath.EndsWith(".targets", StringComparison.Ordinal) ||
96-
relativePath.StartsWith("bin/", StringComparison.Ordinal) ||
97-
relativePath.StartsWith("obj/", StringComparison.Ordinal) ||
98-
relativePath.Contains("/bin/", StringComparison.Ordinal) ||
99-
relativePath.Contains("/obj/", StringComparison.Ordinal))
91+
if (IsIgnoredPath(relativePath))
10092
{
10193
continue;
10294
}
@@ -118,6 +110,12 @@ public async Task Template_Produces_The_Right_Set_Of_FilesAsync(string arguments
118110
}
119111
}
120112

113+
private static bool IsIgnoredPath(string relativePath) =>
114+
relativePath.StartsWith("bin/", StringComparison.Ordinal) ||
115+
relativePath.StartsWith("obj/", StringComparison.Ordinal) ||
116+
relativePath.Contains("/bin/", StringComparison.Ordinal) ||
117+
relativePath.Contains("/obj/", StringComparison.Ordinal);
118+
121119
private void AssertFileExists(string basePath, string path, bool shouldExist)
122120
{
123121
var fullPath = Path.Combine(basePath, path);

0 commit comments

Comments
 (0)