Quarantining ReceivingMessagesPreventsConnectionTimeoutFromOccuring (#24226)

sebastienros · web-flow · commit 8c89172ba35c · 2020-08-13T13:17:51.000-07:00
diff --git a/src/SignalR/server/SignalR/test/HubConnectionHandlerTests.cs b/src/SignalR/server/SignalR/test/HubConnectionHandlerTests.cs
@@ -20,6 +20,7 @@
 using Microsoft.AspNetCore.Http.Connections.Features;
 using Microsoft.AspNetCore.SignalR.Internal;
 using Microsoft.AspNetCore.SignalR.Protocol;
+using Microsoft.AspNetCore.Testing;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Logging.Testing;
@@ -2772,6 +2773,7 @@ public async Task ConnectionTimesOutIfInitialPingAndThenNoMessages()
         }
 
         [Fact]
+        [Flaky("https://github.com/dotnet/aspnetcore-internal/issues/3651", FlakyOn.Helix.All)]
         public async Task ReceivingMessagesPreventsConnectionTimeoutFromOccuring()
         {
             using (StartVerifiableLog())

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@`
`20`	`20`	`using Microsoft.AspNetCore.Http.Connections.Features;`
`21`	`21`	`using Microsoft.AspNetCore.SignalR.Internal;`
`22`	`22`	`using Microsoft.AspNetCore.SignalR.Protocol;`
	`23`	`+using Microsoft.AspNetCore.Testing;`
`23`	`24`	`using Microsoft.Extensions.DependencyInjection;`
`24`	`25`	`using Microsoft.Extensions.Logging;`
`25`	`26`	`using Microsoft.Extensions.Logging.Testing;`
`@@ -2772,6 +2773,7 @@ public async Task ConnectionTimesOutIfInitialPingAndThenNoMessages()`
`2772`	`2773`	`}`
`2773`	`2774`
`2774`	`2775`	`[Fact]`
	`2776`	`+ [Flaky("https://github.com/dotnet/aspnetcore-internal/issues/3651", FlakyOn.Helix.All)]`
`2775`	`2777`	`public async Task ReceivingMessagesPreventsConnectionTimeoutFromOccuring()`
`2776`	`2778`	`{`
`2777`	`2779`	`using (StartVerifiableLog())`