Skip to content

Commit 93beadb

Browse files
committed
Generate GUIDs for ANCM DepProviders
1 parent ba57e4e commit 93beadb

File tree

6 files changed

+27
-8
lines changed

6 files changed

+27
-8
lines changed

src/Installers/Windows/AspNetCoreModule-Setup/ANCMIISExpressV2/AncmIISExpressV2.wixproj

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,12 @@
1818
<ImportDirectoryBuildTargets>false</ImportDirectoryBuildTargets>
1919
</PropertyGroup>
2020

21+
<PropertyGroup>
22+
<ANCMDepProviderKey Condition="'$(Platform)' == 'x86'">IISExpress_AspNetCore_Module_V2,x86</ANCMDepProviderKey>
23+
<ANCMDepProviderKey Condition="'$(Platform)' != 'x86'">IISExpress_AspNetCore_Module_V2,x64</ANCMDepProviderKey>
24+
<DefineConstants>$(DefineConstants);ANCMDepProviderKey=$(ANCMDepProviderKey)</DefineConstants>
25+
</PropertyGroup>
26+
2127
<ItemGroup>
2228
<Compile Include="$(IIS-Setup)iisca\wix5\iisca.wxs">
2329
<Link>iisca.wxs</Link>

src/Installers/Windows/AspNetCoreModule-Setup/ANCMIISExpressV2/ancm_iis_expressv2.wxs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@
88
<?define ProductCode = "*" ?>
99
<?if $(var.IsWin64)=no ?>
1010
<?define ANCMUpgradeCode = "de400ae0-3cd7-4a35-a234-b5a41b90893c" ?>
11-
<?define ANCMDepProviderKey = "IISExpress_AspNetCore_Module_V2,x86" ?>
1211
<?else?>
1312
<?define ANCMUpgradeCode = "da062c0f-12c2-4703-8ed7-0cad342a53a1" ?>
14-
<?define ANCMDepProviderKey = "IISExpress_AspNetCore_Module_V2,x64" ?>
1513
<?endif?>
1614

1715
<?define ProductShortName="IIS Express AspNetCore Module V2" ?>
@@ -506,8 +504,8 @@
506504

507505
<Fragment>
508506
<Feature Id="FT_DepProvider_$(var.ProductNameShort)" AllowAdvertise="no" Description="Used for Ref Counting" Display="hidden" InstallDefault="local" Level="1" Title="RefCounting" TypicalDefault="install" AllowAbsent="no">
509-
<Component Id="C_DepProvider_$(var.ProductNameShort)" Directory="TARGETDIR" Bitness="always32" Guid="*">
510-
<Provides Key="$(var.ANCMDepProviderKey)" dep:Check="yes" />
507+
<Component Id="C_DepProvider_$(var.ProductNameShort)" Directory="TARGETDIR" Bitness="always32" Guid="$(DepProviderGuid)">
508+
<Provides Key="$(ANCMDepProviderKey)" dep:Check="yes" />
511509
</Component>
512510
</Feature>
513511
</Fragment>

src/Installers/Windows/AspNetCoreModule-Setup/ANCMV2/AncmV2.wixproj

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@
1515
<ImportDirectoryBuildTargets>false</ImportDirectoryBuildTargets>
1616
</PropertyGroup>
1717

18+
<PropertyGroup>
19+
<ANCMDepProviderKey Condition="'$(Platform)' == 'x86'">IIS_AspNetCore_Module_V2,x86</ANCMDepProviderKey>
20+
<ANCMDepProviderKey Condition="'$(Platform)' != 'x86'">IIS_AspNetCore_Module_V2,x64</ANCMDepProviderKey>
21+
<DefineConstants>$(DefineConstants);ANCMDepProviderKey=$(ANCMDepProviderKey)</DefineConstants>
22+
</PropertyGroup>
23+
1824
<ItemGroup>
1925
<Compile Include="$(IIS-Setup)iisca\wix5\iisca.wxs">
2026
<Link>iisca.wxs</Link>

src/Installers/Windows/AspNetCoreModule-Setup/ANCMV2/aspnetcoremodulev2.wxs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@
88
<?define ProductCode = "*" ?>
99
<?if $(var.IsWin64)=no ?>
1010
<?define ANCMUpgradeCode = "d7168f76-9dd0-407d-bf22-0b450139e6a7" ?>
11-
<?define ANCMDepProviderKey = "IIS_AspNetCore_Module_V2,x86" ?>
1211
<?else?>
1312
<?define ANCMUpgradeCode = "8d50fde7-0b84-4900-b60d-bd952979ba0b" ?>
14-
<?define ANCMDepProviderKey = "IIS_AspNetCore_Module_V2,x64" ?>
1513
<?endif?>
1614
<?define ProductShortName="IIS AspNetCore Module V2" ?>
1715
<?define ProductNameShort="IIS_ANCM_V2" ?>
@@ -293,8 +291,8 @@
293291
<ComponentRef Id="C_DepProvider_$(var.ProductNameShort)" />
294292
</Feature>
295293

296-
<Component Id="C_DepProvider_$(var.ProductNameShort)" Directory="TARGETDIR" Bitness="always32">
297-
<Provides Key="$(var.ANCMDepProviderKey)" dep:Check="yes" />
294+
<Component Id="C_DepProvider_$(var.ProductNameShort)" Directory="TARGETDIR" Bitness="always32" Guid="$(DepProviderGuid)">
295+
<Provides Key="$(ANCMDepProviderKey)" dep:Check="yes" />
298296
</Component>
299297
</Fragment>
300298

src/Installers/Windows/Wix.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
<!-- Namespace used to generate stable UUID3 GUIDs for MSI ProductCode, etc. DO NOT CHANGE THESE. -->
2323
<HostingBundleNamespaceGuid>E1FD1271-E0F0-4B8B-B4BE-01F2EBA58F4E</HostingBundleNamespaceGuid>
2424
<SharedFrameworkNamespaceGuid>C43D5520-11B3-4D62-B6FE-5D6840B04101</SharedFrameworkNamespaceGuid>
25+
<ANCMNamespaceGuid>EC59D6F5-B7E6-4E46-A617-EC8329960614</ANCMNamespaceGuid>
2526
</PropertyGroup>
2627

2728
<PropertyGroup>

src/Installers/Windows/Wix.targets

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,16 @@
8282
</PropertyGroup>
8383
</Target>
8484

85+
<Target Name="_GenerateANCMGuids" Condition="'$(ANCMDepProviderKey)' != ''" BeforeTargets="CoreCompile">
86+
<GenerateGuid NamespaceGuid="$(ANCMNamespaceGuid)" Values="$(ANCMDepProviderKey)">
87+
<Output TaskParameter="Guid" PropertyName="DepProviderGuid" />
88+
</GenerateGuid>
89+
90+
<PropertyGroup>
91+
<DefineConstants>$(DefineConstants);DepProviderGuid=$(DepProviderGuid)</DefineConstants>
92+
</PropertyGroup>
93+
</Target>
94+
8595
<Target Name="_CheckPackageFileNameIsSet" BeforeTargets="PrepareForBuild">
8696
<Error Text="Missing required property: PackageFileName" Condition="'$(PackageFileName)' == ''" />
8797
</Target>

0 commit comments

Comments
 (0)