Skip to content

Commit 9c13f45

Browse files
authored
Reenable SignalR HTTPs tests (#52967)
Follow up work from the NPM move
1 parent 047ef7a commit 9c13f45

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/SignalR/clients/ts/FunctionalTests/scripts/run-tests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ function runJest(httpsUrl: string, httpUrl: string) {
216216
return new Promise<number>((resolve, reject) => {
217217
const logStream = fs.createWriteStream(path.resolve(LOGS_DIR, "node.functionaltests.log"));
218218
// Use NODE_TLS_REJECT_UNAUTHORIZED to allow our test cert to be used by the Node tests (NEVER use this environment variable outside of testing)
219-
const p = exec(`"${process.execPath}" "${jestPath}" --config "${configPath}"`, { env: { SERVER_URL: `${httpsUrl};${httpUrl}`, NODE_TLS_REJECT_UNAUTHORIZED: "false" }, timeout: 200000, maxBuffer: 10 * 1024 * 1024 },
219+
const p = exec(`"${process.execPath}" "${jestPath}" --config "${configPath}"`, { env: { SERVER_URL: `${httpsUrl};${httpUrl}`, NODE_TLS_REJECT_UNAUTHORIZED: 0 as any }, timeout: 200000, maxBuffer: 10 * 1024 * 1024 },
220220
(error: any, stdout, stderr) => {
221221
console.log("Finished Node tests.");
222222
if (error) {

src/SignalR/clients/ts/FunctionalTests/ts/Common.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export function eachHttpClient(action: (transport: HttpClient) => void): void {
135135
}
136136

137137
// Run test in Node or Chrome, but not on macOS
138-
export const shouldRunHttpsTests = false &&
138+
export const shouldRunHttpsTests =
139139
// Need to have an HTTPS URL
140140
!!ENDPOINT_BASE_HTTPS_URL &&
141141

0 commit comments

Comments
 (0)