Address code review feedback: move IsEqualityContract to ISymbolExtensions and use WellKnownTypes

Co-authored-by: captainsafia <[email protected]>

Author: Copilot

src/Shared/RoslynUtils/WellKnownTypeData.cs

@@ -123,6 +123,7 @@ public enum WellKnownType
         System_ComponentModel_DataAnnotations_ValidationAttribute,
         System_ComponentModel_DataAnnotations_RequiredAttribute,
         System_ComponentModel_DataAnnotations_CustomValidationAttribute,
+        System_Type,
     }
 
     public static string[] WellKnownTypeNames =
@@ -243,5 +244,6 @@ public enum WellKnownType
         "System.ComponentModel.DataAnnotations.ValidationAttribute",
         "System.ComponentModel.DataAnnotations.RequiredAttribute",
         "System.ComponentModel.DataAnnotations.CustomValidationAttribute",
+        "System.Type",
     ];
 }

src/Validation/gen/Extensions/ISymbolExtensions.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Linq;
+using Microsoft.AspNetCore.App.Analyzers.Infrastructure;
 using Microsoft.CodeAnalysis;
 
 namespace Microsoft.Extensions.Validation;
@@ -32,4 +33,9 @@ attribute.AttributeClass is { } attributeClass &&
 
         return property.Name;
     }
+
+    public static bool IsEqualityContract(this IPropertySymbol prop, WellKnownTypes wellKnownTypes) =>
+        prop.Name == "EqualityContract"
+        && SymbolEqualityComparer.Default.Equals(prop.Type, wellKnownTypes.Get(WellKnownTypeData.WellKnownType.System_Type))
+        && prop.DeclaredAccessibility == Accessibility.Protected;
 }

src/Validation/gen/Parsers/ValidationsGenerator.TypesParser.cs

@@ -105,11 +105,6 @@ internal bool TryExtractValidatableType(ITypeSymbol incomingTypeSymbol, WellKnow
         return true;
     }
 
-    private static bool IsEqualityContract(IPropertySymbol prop) =>
-        prop.Name == "EqualityContract"
-        && prop.Type.ToDisplayString() == "System.Type"
-        && prop.DeclaredAccessibility == Accessibility.Protected;
-
     internal ImmutableArray<ValidatableProperty> ExtractValidatableMembers(ITypeSymbol typeSymbol, WellKnownTypes wellKnownTypes, ref HashSet<ValidatableType> validatableTypes, ref List<ITypeSymbol> visitedTypes)
     {
         var members = new List<ValidatableProperty>();
@@ -168,7 +163,7 @@ internal ImmutableArray<ValidatableProperty> ExtractValidatableMembers(ITypeSymb
             // Skip compiler generated properties and properties already processed via
             // the record processing logic above.
             if (member.IsImplicitlyDeclared 
-                || IsEqualityContract(member) 
+                || member.IsEqualityContract(wellKnownTypes) 
                 || resolvedRecordProperty.Contains(member, SymbolEqualityComparer.Default))
             {
                 continue;

src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/ValidationsGenerator.RecordType.cs

@@ -370,31 +370,4 @@ async Task ValidInputProducesNoWarnings(Endpoint endpoint)
         });
 
     }
-
-    [Fact]
-    public async Task RecordTypes_DoNotIncludeEqualityContractProperty()
-    {
-        // Arrange
-        var source = """
-using System;
-using System.ComponentModel.DataAnnotations;
-using Microsoft.AspNetCore.Builder;
-using Microsoft.AspNetCore.Http;
-using Microsoft.Extensions.Validation;
-using Microsoft.Extensions.DependencyInjection;
-
-var builder = WebApplication.CreateBuilder();
-builder.Services.AddValidation();
-var app = builder.Build();
-
-app.MapPost("/test-record", (TestRecord record) => Results.Ok("Passed"));
-
-app.Run();
-
-public record TestRecord([Required] string Name);
-""";
-
-        // Act & Assert - Verify the generated code doesn't include EqualityContract
-        await Verify(source, out var compilation);
-    }
 }