Skip to content

Commit a721dcb

Browse files
captainsafiacaptainsafia
committed
Feedback and snapshots update
1 parent 7db45ac commit a721dcb

9 files changed

+18
-18
lines changed

‎src/OpenApi/gen/XmlCommentGenerator.Emitter.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,7 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
448448
&& metadata.ContainerType is { } containerType
449449
&& metadata.PropertyName is { } propertyName)
450450
{
451-
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName!);
451+
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName);
452452
if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyDocId), out var propertyComment))
453453
{
454454
var parameter = operation.Parameters?.SingleOrDefault(p => p.Name == metadata.Name);
@@ -460,11 +460,11 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
460460
if (propertyComment.Examples?.FirstOrDefault() is { } jsonString)
461461
{
462462
var content = operation.RequestBody.Content?.Values;
463-
var parsedExample = jsonString.Parse();
464463
if (content is null)
465464
{
466465
continue;
467466
}
467+
var parsedExample = jsonString.Parse();
468468
foreach (var mediaType in content)
469469
{
470470
mediaType.Example = parsedExample;

‎src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/AddOpenApiTests.CanInterceptAddOpenApi#OpenApiXmlCommentSupport.generated.verified.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
430430
&& metadata.ContainerType is { } containerType
431431
&& metadata.PropertyName is { } propertyName)
432432
{
433-
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName!);
433+
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName);
434434
if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyDocId), out var propertyComment))
435435
{
436436
var parameter = operation.Parameters?.SingleOrDefault(p => p.Name == metadata.Name);
@@ -442,11 +442,11 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
442442
if (propertyComment.Examples?.FirstOrDefault() is { } jsonString)
443443
{
444444
var content = operation.RequestBody.Content?.Values;
445-
var parsedExample = jsonString.Parse();
446445
if (content is null)
447446
{
448447
continue;
449448
}
449+
var parsedExample = jsonString.Parse();
450450
foreach (var mediaType in content)
451451
{
452452
mediaType.Example = parsedExample;

‎src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/AdditionalTextsTests.CanHandleXmlForSchemasInAdditionalTexts#OpenApiXmlCommentSupport.generated.verified.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
459459
&& metadata.ContainerType is { } containerType
460460
&& metadata.PropertyName is { } propertyName)
461461
{
462-
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName!);
462+
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName);
463463
if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyDocId), out var propertyComment))
464464
{
465465
var parameter = operation.Parameters?.SingleOrDefault(p => p.Name == metadata.Name);
@@ -471,11 +471,11 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
471471
if (propertyComment.Examples?.FirstOrDefault() is { } jsonString)
472472
{
473473
var content = operation.RequestBody.Content?.Values;
474-
var parsedExample = jsonString.Parse();
475474
if (content is null)
476475
{
477476
continue;
478477
}
478+
var parsedExample = jsonString.Parse();
479479
foreach (var mediaType in content)
480480
{
481481
mediaType.Example = parsedExample;

‎src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/CompletenessTests.SupportsAllXmlTagsOnSchemas#OpenApiXmlCommentSupport.generated.verified.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,7 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
551551
&& metadata.ContainerType is { } containerType
552552
&& metadata.PropertyName is { } propertyName)
553553
{
554-
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName!);
554+
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName);
555555
if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyDocId), out var propertyComment))
556556
{
557557
var parameter = operation.Parameters?.SingleOrDefault(p => p.Name == metadata.Name);
@@ -563,11 +563,11 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
563563
if (propertyComment.Examples?.FirstOrDefault() is { } jsonString)
564564
{
565565
var content = operation.RequestBody.Content?.Values;
566-
var parsedExample = jsonString.Parse();
567566
if (content is null)
568567
{
569568
continue;
570569
}
570+
var parsedExample = jsonString.Parse();
571571
foreach (var mediaType in content)
572572
{
573573
mediaType.Example = parsedExample;

‎src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/OperationTests.SupportsXmlCommentsOnOperationsFromControllers#OpenApiXmlCommentSupport.generated.verified.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
434434
&& metadata.ContainerType is { } containerType
435435
&& metadata.PropertyName is { } propertyName)
436436
{
437-
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName!);
437+
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName);
438438
if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyDocId), out var propertyComment))
439439
{
440440
var parameter = operation.Parameters?.SingleOrDefault(p => p.Name == metadata.Name);
@@ -446,11 +446,11 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
446446
if (propertyComment.Examples?.FirstOrDefault() is { } jsonString)
447447
{
448448
var content = operation.RequestBody.Content?.Values;
449-
var parsedExample = jsonString.Parse();
450449
if (content is null)
451450
{
452451
continue;
453452
}
453+
var parsedExample = jsonString.Parse();
454454
foreach (var mediaType in content)
455455
{
456456
mediaType.Example = parsedExample;

‎src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/OperationTests.SupportsXmlCommentsOnOperationsFromMinimalApis#OpenApiXmlCommentSupport.generated.verified.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
474474
&& metadata.ContainerType is { } containerType
475475
&& metadata.PropertyName is { } propertyName)
476476
{
477-
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName!);
477+
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName);
478478
if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyDocId), out var propertyComment))
479479
{
480480
var parameter = operation.Parameters?.SingleOrDefault(p => p.Name == metadata.Name);
@@ -486,11 +486,11 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
486486
if (propertyComment.Examples?.FirstOrDefault() is { } jsonString)
487487
{
488488
var content = operation.RequestBody.Content?.Values;
489-
var parsedExample = jsonString.Parse();
490489
if (content is null)
491490
{
492491
continue;
493492
}
493+
var parsedExample = jsonString.Parse();
494494
foreach (var mediaType in content)
495495
{
496496
mediaType.Example = parsedExample;

‎src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/SchemaTests.SupportsXmlCommentsOnSchemas#OpenApiXmlCommentSupport.generated.verified.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
460460
&& metadata.ContainerType is { } containerType
461461
&& metadata.PropertyName is { } propertyName)
462462
{
463-
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName!);
463+
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName);
464464
if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyDocId), out var propertyComment))
465465
{
466466
var parameter = operation.Parameters?.SingleOrDefault(p => p.Name == metadata.Name);
@@ -472,11 +472,11 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
472472
if (propertyComment.Examples?.FirstOrDefault() is { } jsonString)
473473
{
474474
var content = operation.RequestBody.Content?.Values;
475-
var parsedExample = jsonString.Parse();
476475
if (content is null)
477476
{
478477
continue;
479478
}
479+
var parsedExample = jsonString.Parse();
480480
foreach (var mediaType in content)
481481
{
482482
mediaType.Example = parsedExample;

‎src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/SchemaTests.XmlCommentsOnPropertiesShouldApplyToSchemaReferences#OpenApiXmlCommentSupport.generated.verified.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
439439
&& metadata.ContainerType is { } containerType
440440
&& metadata.PropertyName is { } propertyName)
441441
{
442-
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName!);
442+
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName);
443443
if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyDocId), out var propertyComment))
444444
{
445445
var parameter = operation.Parameters?.SingleOrDefault(p => p.Name == metadata.Name);
@@ -451,11 +451,11 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
451451
if (propertyComment.Examples?.FirstOrDefault() is { } jsonString)
452452
{
453453
var content = operation.RequestBody.Content?.Values;
454-
var parsedExample = jsonString.Parse();
455454
if (content is null)
456455
{
457456
continue;
458457
}
458+
var parsedExample = jsonString.Parse();
459459
foreach (var mediaType in content)
460460
{
461461
mediaType.Example = parsedExample;

‎src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/XmlCommentDocumentationIdTests.CanMergeXmlCommentsWithDifferentDocumentationIdFormats#OpenApiXmlCommentSupport.generated.verified.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
431431
&& metadata.ContainerType is { } containerType
432432
&& metadata.PropertyName is { } propertyName)
433433
{
434-
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName!);
434+
var propertyDocId = DocumentationCommentIdHelper.CreateDocumentationId(containerType, propertyName);
435435
if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyDocId), out var propertyComment))
436436
{
437437
var parameter = operation.Parameters?.SingleOrDefault(p => p.Name == metadata.Name);
@@ -443,11 +443,11 @@ public Task TransformAsync(OpenApiOperation operation, OpenApiOperationTransform
443443
if (propertyComment.Examples?.FirstOrDefault() is { } jsonString)
444444
{
445445
var content = operation.RequestBody.Content?.Values;
446-
var parsedExample = jsonString.Parse();
447446
if (content is null)
448447
{
449448
continue;
450449
}
450+
var parsedExample = jsonString.Parse();
451451
foreach (var mediaType in content)
452452
{
453453
mediaType.Example = parsedExample;

0 commit comments

Comments
 (0)