Add certificate disposal in exception catch block for ImportCertificate method

Copilot · danmoseley · Copilot · commit a76f546262ee · 2025-08-19T00:19:48.000Z
Co-authored-by: danmoseley &lt;6385855+danmoseley@users.noreply.github.com&gt;
diff --git a/src/Shared/CertificateGeneration/CertificateManager.cs b/src/Shared/CertificateGeneration/CertificateManager.cs
@@ -454,7 +454,7 @@ internal ImportCertificateResult ImportCertificate(string certificatePath, strin
             return ImportCertificateResult.ExistingCertificatesPresent;
         }
 
-        X509Certificate2 certificate;
+        X509Certificate2? certificate = null;
         try
         {
             Log.LoadCertificateStart(certificatePath);
@@ -470,6 +470,7 @@ internal ImportCertificateResult ImportCertificate(string certificatePath, strin
             {
                 Log.LoadCertificateError(e.ToString());
             }
+            certificate?.Dispose();
             return ImportCertificateResult.InvalidCertificate;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -454,7 +454,7 @@ internal ImportCertificateResult ImportCertificate(string certificatePath, strin`
`454`	`454`	`return ImportCertificateResult.ExistingCertificatesPresent;`
`455`	`455`	`}`
`456`	`456`
`457`		`- X509Certificate2 certificate;`
	`457`	`+ X509Certificate2? certificate = null;`
`458`	`458`	`try`
`459`	`459`	`{`
`460`	`460`	`Log.LoadCertificateStart(certificatePath);`
`@@ -470,6 +470,7 @@ internal ImportCertificateResult ImportCertificate(string certificatePath, strin`
`470`	`470`	`{`
`471`	`471`	`Log.LoadCertificateError(e.ToString());`
`472`	`472`	`}`
	`473`	`+ certificate?.Dispose();`
`473`	`474`	`return ImportCertificateResult.InvalidCertificate;`
`474`	`475`	`}`
`475`	`476`