Added fixing CallOnParametersSetAsync

Author: dariatiurina

src/Components/Components/src/ComponentBase.cs

@@ -322,7 +322,10 @@ private Task CallOnParametersSetAsync()
 
         // We always call StateHasChanged here as we want to trigger a rerender after OnParametersSet and
         // the synchronous part of OnParametersSetAsync has run.
-        StateHasChanged();
+        if (task.Status != TaskStatus.Faulted)
+        {
+            StateHasChanged();
+        }
 
         return shouldAwaitTask ?
             CallStateHasChangedOnAsyncCompletion(task) :

src/Components/Components/test/ComponentBaseTest.cs

@@ -387,6 +387,7 @@ public async Task ErrorBoundaryHandlesOnInitializedAsyncReturnFaultedTask()
             builder.AddComponentParameter(1, nameof(TestErrorBoundary.ChildContent), (RenderFragment)(childBuilder =>
             {
                 childBuilder.OpenComponent<TestComponentErrorBuildRenderTree>(0);
+                childBuilder.AddComponentParameter(1, nameof(TestComponentErrorBuildRenderTree.FaultedTaskOnInitializedAsync), true);
                 childBuilder.CloseComponent();
             }));
             builder.AddComponentReferenceCapture(2, inst => capturedBoundary = (TestErrorBoundary)inst);
@@ -403,6 +404,94 @@ public async Task ErrorBoundaryHandlesOnInitializedAsyncReturnFaultedTask()
         Assert.Equal(typeof(InvalidTimeZoneException), capturedBoundary!.ReceivedException.GetType());
     }
 
+    [Fact]
+    public async Task ErrorBoundaryHandlesCallOnParametersSetAsyncReturnFaultedTask()
+    {
+        // Arrange
+        var renderer = new TestRenderer();
+        TestErrorBoundary capturedBoundary = null;
+
+        // Create root component that wraps the TestComponentErrorBuildRenderTree in an TestErrorBoundary
+        var rootComponent = new TestComponent();
+        rootComponent.ChildContent = builder =>
+        {
+            builder.OpenComponent<TestErrorBoundary>(0);
+            builder.AddComponentParameter(1, nameof(TestErrorBoundary.ChildContent), (RenderFragment)(childBuilder =>
+            {
+                childBuilder.OpenComponent<TestComponentErrorBuildRenderTree>(0);
+                childBuilder.AddComponentParameter(1, nameof(TestComponentErrorBuildRenderTree.FaultedTaskOnParametersSetAsync), true);
+                childBuilder.CloseComponent();
+            }));
+            builder.AddComponentReferenceCapture(2, inst => capturedBoundary = (TestErrorBoundary)inst);
+            builder.CloseComponent();
+        };
+
+        // Act
+        var rootComponentId = renderer.AssignRootComponentId(rootComponent);
+        await renderer.RenderRootComponentAsync(rootComponentId);
+
+        // Assert
+        Assert.NotNull(capturedBoundary);
+        Assert.NotNull(capturedBoundary!.ReceivedException);
+        Assert.Equal(typeof(InvalidTimeZoneException), capturedBoundary!.ReceivedException.GetType());
+    }
+
+    [Fact]
+    public async Task ComponentBaseDoesntRenderWhenOnInitializedAsyncFaultedTask()
+    {
+        // Arrange
+        var renderer = new TestRenderer();
+        renderer.ShouldHandleExceptions = true;
+        TestComponentErrorBuildRenderTree testComponentErrorBuildRenderTree = null;
+
+        // Create root component that wraps the TestComponentErrorBuildRenderTree in an TestErrorBoundary
+        var rootComponent = new TestComponent();
+        rootComponent.ChildContent = builder =>
+        {
+            builder.OpenComponent<TestComponentErrorBuildRenderTree>(0);
+            builder.AddComponentParameter(1, nameof(TestComponentErrorBuildRenderTree.FaultedTaskOnInitializedAsync), true);
+            builder.AddComponentReferenceCapture(2, inst => testComponentErrorBuildRenderTree = (TestComponentErrorBuildRenderTree)inst);
+            builder.CloseComponent();
+        };
+
+        // Act
+        var rootComponentId = renderer.AssignRootComponentId(rootComponent);
+        await renderer.RenderRootComponentAsync(rootComponentId);
+
+        // Assert
+        Assert.IsType<InvalidTimeZoneException>(renderer.HandledExceptions[0]);
+        Assert.NotNull(testComponentErrorBuildRenderTree);
+        Assert.Equal(0, testComponentErrorBuildRenderTree.StateHasChangedCalled);
+    }
+
+    [Fact]
+    public async Task ComponentBaseDoesntRenderWhenOnSetParametersSetAsyncFaultedTask()
+    {
+        // Arrange
+        var renderer = new TestRenderer();
+        renderer.ShouldHandleExceptions = true;
+        TestComponentErrorBuildRenderTree testComponentErrorBuildRenderTree = null;
+
+        // Create root component that wraps the TestComponentErrorBuildRenderTree in an TestErrorBoundary
+        var rootComponent = new TestComponent();
+        rootComponent.ChildContent = builder =>
+        {
+            builder.OpenComponent<TestComponentErrorBuildRenderTree>(0);
+            builder.AddComponentParameter(1, nameof(TestComponentErrorBuildRenderTree.FaultedTaskOnParametersSetAsync), true);
+            builder.AddComponentReferenceCapture(2, inst => testComponentErrorBuildRenderTree = (TestComponentErrorBuildRenderTree)inst);
+            builder.CloseComponent();
+        };
+
+        // Act
+        var rootComponentId = renderer.AssignRootComponentId(rootComponent);
+        await renderer.RenderRootComponentAsync(rootComponentId);
+
+        // Assert
+        Assert.IsType<InvalidTimeZoneException>(renderer.HandledExceptions[0]);
+        Assert.NotNull(testComponentErrorBuildRenderTree);
+        Assert.Equal(0, testComponentErrorBuildRenderTree.StateHasChangedCalled);
+    }
+
     [Fact]
     public async Task DoesNotRenderAfterOnParametersSetAsyncTaskIsCanceled()
     {
@@ -637,14 +726,38 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
 
     private class TestComponentErrorBuildRenderTree : ComponentBase
     {
+        [Parameter] public bool FaultedTaskOnInitializedAsync { get; set; } = false;
+        [Parameter] public bool FaultedTaskOnParametersSetAsync { get; set; } = false;
+
+        public int StateHasChangedCalled { get; set; } = 0;
+
+        protected new void StateHasChanged()
+        {
+            StateHasChangedCalled++;
+            base.StateHasChanged();
+        }
+
         protected override void BuildRenderTree(RenderTreeBuilder builder)
         {
             throw new InvalidOperationException("Error in BuildRenderTree");
         }
 
         protected override Task OnInitializedAsync()
         {
-            return Task.FromException(new InvalidTimeZoneException());
+            if (FaultedTaskOnInitializedAsync)
+            {
+                return Task.FromException(new InvalidTimeZoneException());
+            }
+            return Task.CompletedTask;
+        }
+
+        protected override Task OnParametersSetAsync()
+        {
+            if (FaultedTaskOnParametersSetAsync)
+            {
+                return Task.FromException(new InvalidTimeZoneException());
+            }
+            return Task.CompletedTask;
         }
     }
 }