Don't generate TypeInfo for invalidatable types

Author: captainsafia

src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.ValidationsGenerator/Parsers/ValidationsGenerator.TypesParser.cs

@@ -50,9 +50,10 @@ internal bool TryExtractValidatableType(ITypeSymbol typeSymbol, RequiredSymbols
 
         // Extract validatable types discovered in base types of this type and add them to the top-level list.
         var current = typeSymbol.BaseType;
+        var hasValidatableBaseType = false;
         while (current != null && current.SpecialType != SpecialType.System_Object)
         {
-            _ = TryExtractValidatableType(current, requiredSymbols, ref validatableTypes, ref visitedTypes);
+            hasValidatableBaseType |= TryExtractValidatableType(current, requiredSymbols, ref validatableTypes, ref visitedTypes);
             current = current.BaseType;
         }
 
@@ -61,9 +62,16 @@ internal bool TryExtractValidatableType(ITypeSymbol typeSymbol, RequiredSymbols
 
         // Extract the validatable types discovered in the JsonDerivedTypeAttributes of this type and add them to the top-level list.
         var derivedTypes = typeSymbol.GetJsonDerivedTypes(requiredSymbols.JsonDerivedTypeAttribute);
+        var hasValidatableDerivedTypes = false;
         foreach (var derivedType in derivedTypes ?? [])
         {
-            _ = TryExtractValidatableType(derivedType, requiredSymbols, ref validatableTypes, ref visitedTypes);
+            hasValidatableDerivedTypes |= TryExtractValidatableType(derivedType, requiredSymbols, ref validatableTypes, ref visitedTypes);
+        }
+
+        // No validatable members or derived types found, so we don't need to add this type.
+        if (members.IsDefaultOrEmpty && !hasValidatableBaseType && !hasValidatableDerivedTypes)
+        {
+            return false;
         }
 
         // Add the type itself as a validatable type itself.
@@ -81,6 +89,11 @@ internal ImmutableArray<ValidatableProperty> ExtractValidatableMembers(ITypeSymb
         {
             var hasValidatableType = TryExtractValidatableType(member.Type.UnwrapType(requiredSymbols.IEnumerable), requiredSymbols, ref validatableTypes, ref visitedTypes);
             var attributes = ExtractValidationAttributes(member, requiredSymbols, out var isRequired);
+            // If the member has no validation attributes or validatable types and is not required, skip it.
+            if (attributes.IsDefaultOrEmpty && !hasValidatableType && !isRequired)
+            {
+                continue;
+            }
             members.Add(new ValidatableProperty(
                 ContainingType: member.ContainingType,
                 Type: member.Type,
@@ -129,7 +142,6 @@ internal static ImmutableArray<ValidationAttribute> ExtractValidationAttributes(
             return [];
         }
 
-        // Continue with existing logic...
         var validationAttributes = attributes
             .Where(attribute => attribute.AttributeClass != null)
             .Where(attribute => attribute.AttributeClass!.ImplementsValidationAttribute(requiredSymbols.ValidationAttribute));

src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.ValidationsGenerator/ValidationsGenerator.cs

@@ -11,13 +11,6 @@ public sealed partial class ValidationsGenerator : IIncrementalGenerator
 {
     public void Initialize(IncrementalGeneratorInitializationContext context)
     {
-//         while (!System.Diagnostics.Debugger.IsAttached)
-//         {
-//             System.Threading.Thread.Sleep(1000);
-// #pragma warning disable RS1035 // Do not use APIs banned for analyzers
-//             System.Console.WriteLine($"Waiting for debugger to attach on {System.Diagnostics.Process.GetCurrentProcess().Id}...");
-// #pragma warning restore RS1035 // Do not use APIs banned for analyzers
-//         }
         // Resolve the symbols that will be required when making comparisons
         // in future steps.
         var requiredSymbols = context.CompilationProvider.Select(ExtractRequiredSymbols);

src/Http/Http.Extensions/test/ValidationsGenerator/snapshots/ValidationsGeneratorTests.CanValidateIValidatableObject#ValidatableInfoResolver.g.verified.cs

@@ -108,29 +108,14 @@ private ValidatableTypeInfo CreateValidatableSubType()
         {
             return new GeneratedValidatableTypeInfo(
                 type: typeof(global::ValidatableSubType),
-                members: [
-                    new GeneratedValidatablePropertyInfo(
-                        containingType: typeof(global::ValidatableSubType),
-                        propertyType: typeof(string),
-                        name: "Value3",
-                        displayName: "Value3",
-                        validationAttributes: []
-                    ),
-                ]
+                members: []
             );
         }
         private ValidatableTypeInfo CreateComplexValidatableType()
         {
             return new GeneratedValidatableTypeInfo(
                 type: typeof(global::ComplexValidatableType),
                 members: [
-                    new GeneratedValidatablePropertyInfo(
-                        containingType: typeof(global::ComplexValidatableType),
-                        propertyType: typeof(int),
-                        name: "Value1",
-                        displayName: "Value 1",
-                        validationAttributes: []
-                    ),
                     new GeneratedValidatablePropertyInfo(
                         containingType: typeof(global::ComplexValidatableType),
                         propertyType: typeof(string),

src/Http/Http.Extensions/test/ValidationsGenerator/snapshots/ValidationsGeneratorTests.CanValidatePolymorphicTypes#ValidatableInfoResolver.g.verified.cs

@@ -148,15 +148,7 @@ private ValidatableTypeInfo CreateBaseValidatableType()
         {
             return new GeneratedValidatableTypeInfo(
                 type: typeof(global::BaseValidatableType),
-                members: [
-                    new GeneratedValidatablePropertyInfo(
-                        containingType: typeof(global::BaseValidatableType),
-                        propertyType: typeof(int),
-                        name: "Value1",
-                        displayName: "Value 1",
-                        validationAttributes: []
-                    ),
-                ]
+                members: []
             );
         }
         private ValidatableTypeInfo CreateContainerType()