Skip to content

Commit ab06730

Browse files
committed
another test fix
1 parent 4f6bc2b commit ab06730

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/Servers/Kestrel/test/InMemory.FunctionalTests/TlsListenerMiddlewareTests.Units.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,10 @@ public async Task RunTlsClientHelloCallbackTest_DeterministinglyReads()
9393
Assert.True(nextMiddlewareInvoked);
9494
Assert.False(tlsClientHelloCallbackInvoked);
9595

96-
// ensuring that we have read only 4 times (ReadAsync() is called 4 times)
96+
// ensuring that we have read limited number of times
9797
var observableTransport = transportConnection.Transport as ObservableDuplexPipe;
9898
Assert.NotNull(observableTransport);
99-
Assert.Equal(4, observableTransport.ReadAsyncCounter);
99+
Assert.True(observableTransport.ReadAsyncCounter is > 2 && observableTransport.ReadAsyncCounter is <= 5);
100100
}
101101

102102
private async Task RunTlsClientHelloCallbackTest_WithMultipleSegments(

src/Servers/Kestrel/test/InMemory.FunctionalTests/TlsListenerMiddlewareTests.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ namespace InMemory.FunctionalTests;
2323

2424
public partial class TlsListenerMiddlewareTests : TestApplicationErrorLoggerLoggedTest
2525
{
26+
private static readonly X509Certificate2 _x509Certificate2 = TestResources.GetTestCertificate();
27+
2628
[Fact]
2729
public async Task TlsClientHelloBytesCallback_InvokedAndHasTlsMessageBytes()
2830
{
@@ -33,9 +35,9 @@ public async Task TlsClientHelloBytesCallback_InvokedAndHasTlsMessageBytes()
3335
testContext,
3436
listenOptions =>
3537
{
36-
listenOptions.UseHttps((HttpsConnectionAdapterOptions options) =>
38+
listenOptions.UseHttps(_x509Certificate2, httpsOptions =>
3739
{
38-
options.TlsClientHelloBytesCallback = (connection, clientHelloBytes) =>
40+
httpsOptions.TlsClientHelloBytesCallback = (connection, clientHelloBytes) =>
3941
{
4042
Logger.LogDebug("[Received TlsClientHelloBytesCallback] Connection: {0}; TLS client hello buffer: {1}", connection.ConnectionId, clientHelloBytes.Length);
4143
tlsClientHelloCallbackInvoked = true;

0 commit comments

Comments
 (0)