Skip to content

Commit b043102

Browse files
authored
Update CODEOWNERS to include doc writers and reduce duplication
This PR adds @Rick-Anderson and @tdykstra as CODEOWNERS for `/**/PublicAPI.*Shipped.txt`, so they get notified for any PR that adds new API so they can review the doc comments. Alternatively, they could join @aspnet-api-review, but that may be used for more than just PRs. I also took the opportunity to remove some redundancy with the assumption that the [last matched pattern wins](https://graphite.dev/guides/in-depth-guide-github-codeowners#patterns-and-precedence-in-the-codeowners-file). If we find that's not the case, we can revert that part later and add @Rick-Anderson and @tdykstra to all the relevant lines.
1 parent febd7e8 commit b043102

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

.github/CODEOWNERS

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# Users referenced in this file will automatically be requested as reviewers for PRs that modify the given paths.
22
# See https://help.github.com/articles/about-code-owners/
33

4-
/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review
54
/global.json @dotnet/aspnet-build @wtgodbe
65
/.azure/ @dotnet/aspnet-build @wtgodbe
76
/.azuredevops/ @dotnet/aspnet-build @wtgodbe
@@ -18,34 +17,23 @@
1817
/eng/Version.Details.xml @dotnet-maestro-bot @dotnet/aspnet-build @wtgodbe
1918
/eng/SourceBuild* @dotnet/source-build
2019
/src/Caching/ @captainsafia @halter73 @mgravell
21-
/src/Caching/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @captainsafia @halter73 @mgravell
2220
/src/Components/ @dotnet/aspnet-blazor-eng
23-
/src/Components/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @dotnet/aspnet-blazor-eng
2421
/src/DefaultBuilder/ @halter73
25-
/src/DefaultBuilder/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review
2622
/src/Grpc/ @JamesNK @captainsafia @mgravell
27-
/src/Grpc/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @JamesNK @captainsafia @mgravell
2823
/src/Hosting/ @halter73
29-
/src/Hosting/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review
3024
/src/Http/ @BrennanConroy @halter73 @captainsafia
31-
/src/Http/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @BrennanConroy
3225
/src/Http/Routing/ @halter73
33-
/src/Http/Routing/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @halter73
3426
/src/HttpClientFactory/ @captainsafia @halter73
35-
/src/HttpClientFactory/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @captainsafia @halter73
3627
/src/Installers/ @dotnet/aspnet-build @wtgodbe
3728
/src/JSInterop/ @dotnet/aspnet-blazor-eng
3829
/src/Middleware/ @BrennanConroy
39-
/src/Middleware/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @BrennanConroy
4030
/src/Mvc/ @dotnet/minimal-apis
41-
/src/Mvc/Mvc.ApiExplorer @captainsafia @halter73 @brunolins16
42-
/src/Mvc/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @dotnet/aspnet-blazor-eng
31+
/src/Mvc/Mvc.ApiExplorer @captainsafia @halter73
4332
/src/OpenApi @captainsafia @dotnet/minimal-apis
4433
/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorServerWeb-CSharp/ @dotnet/aspnet-blazor-eng
4534
/src/ProjectTemplates/Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/ @dotnet/aspnet-blazor-eng
46-
/src/Security/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review
35+
/src/Security/ @halter73
4736
/src/Servers/ @halter73 @BrennanConroy @JamesNK @mgravell
48-
/src/Servers/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @halter73 @BrennanConroy @JamesNK @mgravell
4937
/src/SignalR/ @BrennanConroy @halter73
50-
/src/SignalR/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @BrennanConroy @halter73
5138
/src/submodules @dotnet/aspnet-build @wtgodbe
39+
/**/PublicAPI.*Shipped.txt @dotnet/aspnet-api-review @Rick-Anderson @tdykstra

0 commit comments

Comments
 (0)