Use NullLogger instead of NullLoggerFactory (#59281)

WeihanLi · web-flow · commit b0b6d1dbcde6 · 2024-12-06T10:21:45.000-08:00
diff --git a/src/SignalR/clients/csharp/Http.Connections.Client/src/Internal/WebSocketsTransport.cs b/src/SignalR/clients/csharp/Http.Connections.Client/src/Internal/WebSocketsTransport.cs
@@ -75,7 +75,7 @@ public WebSocketsTransport(HttpConnectionOptions httpConnectionOptions, ILoggerF
         bool useStatefulReconnect = false)
     {
         _useStatefulReconnect = useStatefulReconnect;
-        _logger = (loggerFactory ?? NullLoggerFactory.Instance).CreateLogger(typeof(WebSocketsTransport));
+        _logger = loggerFactory?.CreateLogger(typeof(WebSocketsTransport)) ?? NullLogger.Instance;
         _httpConnectionOptions = httpConnectionOptions ?? new HttpConnectionOptions();
 
         _closeTimeout = _httpConnectionOptions.CloseTimeout;

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public WebSocketsTransport(HttpConnectionOptions httpConnectionOptions, ILoggerF`
`75`	`75`	`bool useStatefulReconnect = false)`
`76`	`76`	`{`
`77`	`77`	`_useStatefulReconnect = useStatefulReconnect;`
`78`		`- _logger = (loggerFactory ?? NullLoggerFactory.Instance).CreateLogger(typeof(WebSocketsTransport));`
	`78`	`+ _logger = loggerFactory?.CreateLogger(typeof(WebSocketsTransport)) ?? NullLogger.Instance;`
`79`	`79`	`_httpConnectionOptions = httpConnectionOptions ?? new HttpConnectionOptions();`
`80`	`80`
`81`	`81`	`_closeTimeout = _httpConnectionOptions.CloseTimeout;`